From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E09FC433E2 for ; Tue, 8 Sep 2020 13:18:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 16EEA224D4 for ; Tue, 8 Sep 2020 13:18:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ov/ZXMw/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16EEA224D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 184606B005A; Tue, 8 Sep 2020 09:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 134726B005C; Tue, 8 Sep 2020 09:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA2006B005D; Tue, 8 Sep 2020 09:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id BFDAB6B005A for ; Tue, 8 Sep 2020 09:18:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7E4573626 for ; Tue, 8 Sep 2020 13:18:17 +0000 (UTC) X-FDA: 77239947834.09.tree11_4b069d7270d5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 533CA180AD81A for ; Tue, 8 Sep 2020 13:18:17 +0000 (UTC) X-HE-Tag: tree11_4b069d7270d5 X-Filterd-Recvd-Size: 4304 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Sep 2020 13:18:16 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id j34so4631175pgi.7 for ; Tue, 08 Sep 2020 06:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0vIgYTSyDPV3iR6+cw+LdVUS1ZrYeuTmFBotSM5CblM=; b=ov/ZXMw/AKOs8jo09rA2hYZSxInsT3OMFVq89whQo7cYYu2SCkDSKDxy0gcKVbVn7t hFYOgCbfDVCtB1NDLGjAf471ThUkNGJM9gXwPedc1dFFgCJ+KLGWLjhlmFiCTwlIJbic wc9pyM7t6SceOLnil91wfK2poKJPGBRPN3XmiaGTw7yGS8phORQ95GUv2UtX4oEXZMPc nHgtFAQlkf5qKrRYD4x75Qn3bMbrk0QI0czVR1MYPLmaKef/ZY+yhb1u2qQk4nAFniiY qAaMXOv8TQY4xmSAcOzvdKoT2YVDknIApH8CKySjRjGDfQmhwfxU+gvw2bwl+D6+dMED igpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0vIgYTSyDPV3iR6+cw+LdVUS1ZrYeuTmFBotSM5CblM=; b=Mvd+YQwcZW+XD2uLPzRKqfUAwTDQoXcq/lmeQSs+Gc0vT/z9LArMU8HcQCUNi3eU22 Zg5XYgHpBEXVDs/mY5Eh3cuUPwnZ7MxXMhBppbIoFFBY9iUIKEXZ1f9p15/8hLbrk7ny oUPiHTwlm9TOhL+mqTVXf/TDfU6Nhpv7cNdbBZak7zS9SHte/xCNUxJPy7jWnt74+3MC +HddNGkR/oATUUkbBy+LmOwIXuzKsJAbWm1WcVqnlsy2aLF7j3DovXgwfZP5taCF9Fok +vqykkueM1j8NIzGj83KUZaLk9kETszVfSKYOYQ2MxVoleEd0M5coX/lvKnxYLE+F0za Xv8Q== X-Gm-Message-State: AOAM5339kcVl7kL/FlLAHMamMQjcYCWj3Ht9ZrJoze7CYabYBe75QbAA OB7ZHCHK2vBHZN8PvmEMp9uB3/8WkcO5Z2eo+nFCCg== X-Google-Smtp-Source: ABdhPJzxi6yQj0Q2YVkwR7BwzG5jGX9Kv30i0fI1k3zMgffaPeCcvt33Dkc1PTDpk7PvaFohhQSk8DzIdn8G1e0e6HU= X-Received: by 2002:a17:902:988f:: with SMTP id s15mr23932254plp.26.1599571095681; Tue, 08 Sep 2020 06:18:15 -0700 (PDT) MIME-Version: 1.0 References: <518da1e5169a4e343caa3c37feed5ad551b77a34.1597425745.git.andreyknvl@google.com> <20200827104033.GF29264@gaia> In-Reply-To: <20200827104033.GF29264@gaia> From: Andrey Konovalov Date: Tue, 8 Sep 2020 15:18:04 +0200 Message-ID: Subject: Re: [PATCH 26/35] kasan, arm64: Enable TBI EL1 To: Catalin Marinas Cc: Dmitry Vyukov , Vincenzo Frascino , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 533CA180AD81A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 12:40 PM Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:08PM +0200, Andrey Konovalov wrote: > > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > > index 152d74f2cc9c..6880ddaa5144 100644 > > --- a/arch/arm64/mm/proc.S > > +++ b/arch/arm64/mm/proc.S > > @@ -38,7 +38,7 @@ > > /* PTWs cacheable, inner/outer WBWA */ > > #define TCR_CACHE_FLAGS TCR_IRGN_WBWA | TCR_ORGN_WBWA > > > > -#ifdef CONFIG_KASAN_SW_TAGS > > +#if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > > #define TCR_KASAN_FLAGS TCR_TBI1 > > #else > > #define TCR_KASAN_FLAGS 0 > > I prefer to turn TBI1 on only if MTE is present. So on top of the v8 > user series, just do this in __cpu_setup. Started working on this, but realized that I don't understand what exactly is suggested here. TCR_KASAN_FLAGS are used in __cpu_setup(), so this already happens in __cpu_setup(). Do you mean that TBI1 should be enabled when CONFIG_ARM64_MTE is enabled, but CONFIG_KASAN_HW_TAGS is disabled?