From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F089FC433E7 for ; Fri, 16 Oct 2020 13:05:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D989207DE for ; Fri, 16 Oct 2020 13:05:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tNSpsnAo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D989207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A7BA940009; Fri, 16 Oct 2020 09:05:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 631A3900002; Fri, 16 Oct 2020 09:05:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5463D940009; Fri, 16 Oct 2020 09:05:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 38FC3900002 for ; Fri, 16 Oct 2020 09:05:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ECEA6362E for ; Fri, 16 Oct 2020 13:05:08 +0000 (UTC) X-FDA: 77377809096.12.force96_3c1714c2721d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 553371801A4D6 for ; Fri, 16 Oct 2020 13:04:52 +0000 (UTC) X-HE-Tag: force96_3c1714c2721d X-Filterd-Recvd-Size: 4930 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 13:04:51 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id b19so1264111pld.0 for ; Fri, 16 Oct 2020 06:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kg/AR7kJChmFU99Vav3gO3g+4etmp4JgAFXVamIUngo=; b=tNSpsnAoXl6hnh96DoeAuiP+9EOUyTZtTcPY/OwkinZmpO3A7HkrjrcYP18LRKMST+ jnHWvwX0skjh8w4jk/LeK03RSW/+9dXJo1bTYdZTS330kul6zZn1hGnRy1DdcYw9glmT /RvIywwu0NxUVftMTJgQkc5eJfyFQleUYJWIa0K7zIp+fatBiTxkM1CG3Wux06+AqpP6 LHOGxJ4QBfh53o3U11gCUZnviexiIXAW6p2ytXlM17ldL44hZQkPb+gnCMdhy50U5tuP p/MPnVKVGHxyThS/eN5IImJYY4Q/ClRgblX0lVf+nlcYCtnRd5Wmv9sOw2mKIo1WmWU8 l8EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kg/AR7kJChmFU99Vav3gO3g+4etmp4JgAFXVamIUngo=; b=AUVaF3epYRzIktcrNapeZNgdnt/2ANcNCfdKJ0LwzcDiom8KBgVfEVamy8PwlOzxpO jpPvYFwOWD/OZnU8OeWdHgXXt1xdwVP5Zx6fHWjHZb0TXcw7MgD7nm0G9vP5RxT0H5f2 OETFQq6dP393w1kvJIu/Kkbc54cEFPk3lMc1oj54k+N1pfgiXT3kdkeIYufSxs9awEuT gZGc7W8ttY4UYDuYf3xk2focruiPNR5IHUActyc0HSH+yWUwU0Km+O0LRagjBjR1SM8q o0AoxMr4xztozkxW1/ul/JTmiENNJes3ZQ8yWZCWdCPDVeA+RRIHNp5PlVuq/PaDDceF 0Fkw== X-Gm-Message-State: AOAM530pirVacy4sonXqzIQLHiaoKdGmjcPGsJ4fla1W09OnPp1B17OD 55KcqKbqG3R8m5L0D+Q9CqbaruQft3jpSAJ7tzSOBg== X-Google-Smtp-Source: ABdhPJxVYeRhYPu4dH98pYdokuk3AKpxRPtCJ5gB3SyjbOn7ZDs5f9+7efIAkIsh5YvuYG2A0YWuC0QInF2LjuGml8Y= X-Received: by 2002:a17:902:9681:b029:d5:cdbd:c38c with SMTP id n1-20020a1709029681b02900d5cdbdc38cmr201999plp.85.1602853490651; Fri, 16 Oct 2020 06:04:50 -0700 (PDT) MIME-Version: 1.0 References: <8fe7b641027ea3151bc84e0d7c81d2d8104d50d7.1602708025.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 16 Oct 2020 15:04:39 +0200 Message-ID: Subject: Re: [PATCH RFC 5/8] kasan: mark kasan_init_tags as __init To: Marco Elver Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 15, 2020 at 12:23 PM Marco Elver wrote: > > On Wed, 14 Oct 2020 at 22:44, Andrey Konovalov wrote: > > > > Similarly to kasan_init() mark kasan_init_tags() as __init. > > > > Signed-off-by: Andrey Konovalov > > Link: https://linux-review.googlesource.com/id/I8792e22f1ca5a703c5e979969147968a99312558 > > --- > > include/linux/kasan.h | 4 ++-- > > mm/kasan/hw_tags.c | 2 +- > > mm/kasan/sw_tags.c | 2 +- > > 3 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > index 7be9fb9146ac..af8317b416a8 100644 > > --- a/include/linux/kasan.h > > +++ b/include/linux/kasan.h > > @@ -185,7 +185,7 @@ static inline void kasan_record_aux_stack(void *ptr) {} > > > > #if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > > > > -void kasan_init_tags(void); > > +void __init kasan_init_tags(void); > > > > void *kasan_reset_tag(const void *addr); > > > > @@ -194,7 +194,7 @@ bool kasan_report(unsigned long addr, size_t size, > > > > #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ > > > > -static inline void kasan_init_tags(void) { } > > +static inline void __init kasan_init_tags(void) { } > > Should we mark empty static inline functions __init? __init comes with > a bunch of other attributes, but hopefully they don't interfere with > inlining? I think it's a good idea to drop __init, as the function call should be optimized away anyway. Thanks!