From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 678AAC433DB for ; Fri, 15 Jan 2021 18:09:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCDE823A58 for ; Fri, 15 Jan 2021 18:09:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCDE823A58 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 568088D01C4; Fri, 15 Jan 2021 13:09:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F17D8D01B2; Fri, 15 Jan 2021 13:09:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E0328D01C4; Fri, 15 Jan 2021 13:09:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 25E148D01B2 for ; Fri, 15 Jan 2021 13:09:12 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DE89082C1571 for ; Fri, 15 Jan 2021 18:09:11 +0000 (UTC) X-FDA: 77708796102.15.day43_520efed27531 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 7C67E1830EF4D for ; Fri, 15 Jan 2021 18:09:11 +0000 (UTC) X-HE-Tag: day43_520efed27531 X-Filterd-Recvd-Size: 4274 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 18:09:10 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id q4so5097662plr.7 for ; Fri, 15 Jan 2021 10:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GeuXFTMHH/dqlLS30TqVtIZ+iZRqb8fjBFP+mG2mN+E=; b=Xpx51qo9Kemp9C08NnM+/vvKtmkeN700Xd2RXiEx9imbbsKJrIovSuD9Eq+cLLBRSG 1myDAIHn1uYpi5wMOauhn1wJxnNKW88XyT4P3oeRvlHrKKAO6WX/DdOWCy9nxbzUEpNK VR9FIK54FhxjPif+hcQY5QqwWE1FuJCf1EujuCzF0VTmu1Muyf8aEdMya+psKYcEP2FC bSBoMaZoyHxMWhdIs1mQ4NUFMYXG3alZvxPtMkXayqpan5YI7VZPLrVsZCuYpn+ZXvOm 776ncNs78b2pCIQnWyyj6XGlnZk9LOHuWXxqr02wc06nGO6A7Xo3QX8O9ShXN4PIhTlf LBRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GeuXFTMHH/dqlLS30TqVtIZ+iZRqb8fjBFP+mG2mN+E=; b=hs78pBaR7kDHkOQykcIgc1z/Mv/3WOYrbOuJa2e1uWwQXNQroiHnvkccmWg9NkpDE8 POywzBnWr0KXJ4CEelBqzmxlsz4w5jS3jyqAmTD1w7EkkDEGLmjY+Cqrj3bWHILe4NDH I8NdZPHV6bp5pqXRZLAFJHtjVxJ7Y8nHT+ibTi5XR31c4fekFaELomMQO/z1jKozE1Qz CRyAxyrNr3rPMWgU67QA2YDVRjm5z8cMuG6aqH61vqMtq8LhMom8xv6DFrIrHPpguKJe a07XrtSjD4RhQUoWD8cnTkDnzXAKO2J2D0e0kJaY+1jE1a1aAqvUPzB9WovLY3EvTmRI nWjg== X-Gm-Message-State: AOAM530bjyXmqvhnE43/baOFEeLs/9PSstgPW8sEj1bfOgTNebQ2hy8C M6+GTMUWh5rEbFO+XcAKzfbpvR88VsuoyI6kSVFv/Q== X-Google-Smtp-Source: ABdhPJzNbllQto9hwL/hLOtREAy9hdEgCBOaHkZMrbkIngkRxP3KA/e7z9cQRQcPdWhR3yD4nVi9m8qtj4aod37PQo8= X-Received: by 2002:a17:902:ff06:b029:de:362c:bd0b with SMTP id f6-20020a170902ff06b02900de362cbd0bmr13048327plj.13.1610734149962; Fri, 15 Jan 2021 10:09:09 -0800 (PST) MIME-Version: 1.0 References: <20210115175922.GI16707@gaia> In-Reply-To: <20210115175922.GI16707@gaia> From: Andrey Konovalov Date: Fri, 15 Jan 2021 19:08:59 +0100 Message-ID: Subject: Re: [PATCH v3 2/2] kasan, arm64: fix pointer tags in KASAN reports To: Catalin Marinas Cc: Andrew Morton , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 15, 2021 at 6:59 PM Catalin Marinas wrote: > > On Fri, Jan 15, 2021 at 06:41:53PM +0100, Andrey Konovalov wrote: > > As of the "arm64: expose FAR_EL1 tag bits in siginfo" patch, the address > > that is passed to report_tag_fault has pointer tags in the format of 0x0X, > > while KASAN uses 0xFX format (note the difference in the top 4 bits). > > > > Fix up the pointer tag for kernel pointers in do_tag_check_fault by > > setting them to the same value as bit 55. Explicitly use __untagged_addr() > > instead of untagged_addr(), as the latter doesn't affect TTBR1 addresses. > > > > Link: https://linux-review.googlesource.com/id/I9ced973866036d8679e8f4ae325de547eb969649 > > Reviewed-by: Catalin Marinas > > Unless there are other comments, I'll queue this for -rc5 through the > arm64 tree (I already finalised the arm64 for-next/fixes branch for this > week). Sounds good, thank you!