From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4500EC388F7 for ; Tue, 3 Nov 2020 15:34:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C23D920757 for ; Tue, 3 Nov 2020 15:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iP5XPK46" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C23D920757 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 17FDA6B0072; Tue, 3 Nov 2020 10:34:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1078D6B0073; Tue, 3 Nov 2020 10:34:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9B4F6B0074; Tue, 3 Nov 2020 10:34:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id AD41F6B0072 for ; Tue, 3 Nov 2020 10:34:07 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 400AD181AEF00 for ; Tue, 3 Nov 2020 15:34:07 +0000 (UTC) X-FDA: 77443502934.07.lunch37_2102212272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 1D7641803F9A9 for ; Tue, 3 Nov 2020 15:34:07 +0000 (UTC) X-HE-Tag: lunch37_2102212272b9 X-Filterd-Recvd-Size: 6079 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 15:34:06 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id r10so13936260pgb.10 for ; Tue, 03 Nov 2020 07:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HjUJI0OrjkWbAH3DienhZxTmqOna3ueAap2yYKG4ygM=; b=iP5XPK46EpWfmFeOfqdSZXFt9WYlJwjIRfQh65p0d3dVRcIyM9s2ElGMNxskEY7gGI C6zcH4JLnwQD9+c2B7DXyZ3KBi1IogrhWe3J61hRkd83t0spqehvY9PhEOlCpfdL98Kx DFvscLUxSS9yFHh6Mc/7cJeICEkM4VkZvJQ7i6LOieQz0UZxKS0MEup2NUbmD7Fcq36X v2FYom/i18e6HNWRLfsjcJiS3ONoPtx+xHvtoPI0LBpa/ngE83ylRJvxnbAN+/jJYKYc htV+HyLmcdvtfE4pV6IHGbkebT/L4/sJt+8xqAZnc/FSK0zfQaT0rzUR45Jdfhndgq4h 6x2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HjUJI0OrjkWbAH3DienhZxTmqOna3ueAap2yYKG4ygM=; b=T5DwIia2mngMh9cGCWDTdqzPI66rdT8mrxbsi2mDFDKe0i5TmVaSRPpZ5XGsbj6h1H TznHYua6IwWSFiB9TPuYGJKncXmCXg2otFje8kOELkEU0Ng6P1Sw6ZLtE4pPzZfCykM+ rBNSMigTr7LyR5BxX1Bu5fyOnMIUlZOLYfUsgc1cqz+09nx9Bt4/27LsqYkGiuDRM60w nL0v8P2DmPlSycFMi0u2X0YxmnfrlJprvHvub+Ddu/oun0/EwDxdigPLHAEl0QmkOwxd 2uQYbxx3YDdgx2v0cA9X7YHdm067YK6hXxB9lp1abw1CL40nJq5L0MX1cSSZcKwx5g/L 6VfQ== X-Gm-Message-State: AOAM533wbrYKBB7oio95kDxiiGrI2xsaDm2fCaSRL8pHNd35macI61Jm MomCfYNI8KmZ/6bp1GRKcHmiYdkmiKRp8U4CMEm0pg== X-Google-Smtp-Source: ABdhPJzj1KMRjCYm5PpARPnsanIfGJWoAOGU0mlig6qsZqXkvEODTi7bt8BldV8NNJqam4jCoEgpdUuz85GdWMmx7/c= X-Received: by 2002:a17:90a:eb02:: with SMTP id j2mr356174pjz.136.1604417645395; Tue, 03 Nov 2020 07:34:05 -0800 (PST) MIME-Version: 1.0 References: <1d87f0d5a282d9e8d14d408ac6d63462129f524c.1603372719.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 3 Nov 2020 16:33:54 +0100 Message-ID: Subject: Re: [PATCH RFC v2 07/21] kasan, arm64: move initialization message To: Dmitry Vyukov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 9:14 PM Andrey Konovalov wrote: > > On Wed, Oct 28, 2020 at 11:56 AM Dmitry Vyukov wrote: > > > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > > > > > Tag-based KASAN modes are fully initialized with kasan_init_tags(), > > > while the generic mode only requireds kasan_init(). Move the > > > initialization message for tag-based modes into kasan_init_tags(). > > > > > > Also fix pr_fmt() usage for KASAN code: generic mode doesn't need it, > > > > Why doesn't it need it? What's the difference with tag modes? > > I need to reword the patch descriptions: it's not the mode that > doesn't need it, it's the generic.c file, as it doesn't use any pr_*() > functions. > > > > > > tag-based modes should use "kasan:" instead of KBUILD_MODNAME. > > > > With generic KASAN I currently see: > > > > [ 0.571473][ T0] kasan: KernelAddressSanitizer initialized > > > > So KBUILD_MODNAME somehow works. Is there some difference between files? > > That code is printed from arch/xxx/mm/kasan_init*.c, which has its own > pr_fmt defined. > > > > > > Signed-off-by: Andrey Konovalov > > > Link: https://linux-review.googlesource.com/id/Idfd1e50625ffdf42dfc3dbf7455b11bd200a0a49 > > > --- > > > arch/arm64/mm/kasan_init.c | 3 +++ > > > mm/kasan/generic.c | 2 -- > > > mm/kasan/hw_tags.c | 4 ++++ > > > mm/kasan/sw_tags.c | 4 +++- > > > 4 files changed, 10 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > > > index b6b9d55bb72e..8f17fa834b62 100644 > > > --- a/arch/arm64/mm/kasan_init.c > > > +++ b/arch/arm64/mm/kasan_init.c > > > @@ -290,5 +290,8 @@ void __init kasan_init(void) > > > { > > > kasan_init_shadow(); > > > kasan_init_depth(); > > > +#if defined(CONFIG_KASAN_GENERIC) > > > + /* CONFIG_KASAN_SW/HW_TAGS also requires kasan_init_tags(). */ > > > > A bit cleaner way may be to introduce kasan_init_early() and > > kasan_init_late(). Late() will do tag init and always print the > > message. > > It appears we'll also need kasan_init_even_later() for some > MTE-related stuff. I'll try to figure out some sane naming scheme here > and include it into the next version. Actually, it looks like some arches already have kasan_init_early/late() along with kasan_init(). I'd say we better keep those for generic KASAN mode, and kasan_init_tags() for tag-based modes.