From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10068C433E0 for ; Mon, 11 Jan 2021 19:30:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9238622473 for ; Mon, 11 Jan 2021 19:30:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9238622473 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B4DF6B01F7; Mon, 11 Jan 2021 14:30:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03E806B01F9; Mon, 11 Jan 2021 14:30:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E48286B01FA; Mon, 11 Jan 2021 14:30:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id CA6BB6B01F7 for ; Mon, 11 Jan 2021 14:30:41 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 94EB0180AD815 for ; Mon, 11 Jan 2021 19:30:41 +0000 (UTC) X-FDA: 77694486282.28.bears04_03160b42750f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 46A766C3A for ; Mon, 11 Jan 2021 19:30:41 +0000 (UTC) X-HE-Tag: bears04_03160b42750f X-Filterd-Recvd-Size: 4785 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 19:30:40 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id 30so315680pgr.6 for ; Mon, 11 Jan 2021 11:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qo2fQAXd+OsMiLPHSUfSpNVkpbDbRR3kE8tJYakNl9E=; b=ax0g20+io9+hknWBPpMxAQv86e3BV9BnGMFgIqXJ9pFv1sGGayp8i3795ZIxSkMX8w sbhmLQZbNam8/SGqG8EAQzIj2k55phmPp6LF3oUCv0Ys+SZvKDJPdZpq7/YAVAXY8s62 c+LidHl99KI5JXqsljDZrcrpJPEMVXH4vAL6MtI56FSRor4vCDSD3vv0bg3IWq5cVANZ GLDHUEO3zwD0hgxSKUdlCf1dsNIbmaiekqEHoyzlSXmDfWpvhMESBCOXOTlLrxsfjlJv Y8Y43ATIACr24S3GqGb6p3pg5RaYkhN0eHtAvg/DD7XAGQCRN6gUP267twpShI2WGMvP QX6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qo2fQAXd+OsMiLPHSUfSpNVkpbDbRR3kE8tJYakNl9E=; b=KBQHhe7mf1d+yhC853UVKDZuuFj6bmmuwk76cWUv6Va/nYDZGV2v6g14LNHtsaa4J+ yHCYICgGONhnIPG8ZmYtf+G3WT8l5QnQ7nXB9QOxQwMJEN+5pinC/GBz6WEJK+OWf9YA 0CqyQ/LP2PiSVmf5HqheF2T9D+q0uyG2xOj7MA7htlv9WDL023uzV1CYjG4vhHEbYsVw crVzLQfHNmLymVnvWfwUmhpLHIVx8a75APPKxhvpT80BVv29qNV+ZLy2zqizDjmT7Cug RMtyK1Ej52a6g4qETFgAfrE1LQfddnfWHQiXTprFb0sCDiM52dq3e18PBzb5QMOCJA3k L5PA== X-Gm-Message-State: AOAM532Eu1Ikkyhk39X9DCStNBw3uBp6r8vTkoZTdJX5dK36IvS9XnI6 pwENXnFlBMDKoDTCmhMBnfoIWbgjLvPrHPNH+M4eGw== X-Google-Smtp-Source: ABdhPJxfnVekwDDs7W26tTKMU0LtLEZSR7eufar20rcVzDPc4DtJT/9lOoaOHA5Sf6AozuXRQZaWL4OnIHnX0NlzO/4= X-Received: by 2002:a62:e309:0:b029:1ae:5b4a:3199 with SMTP id g9-20020a62e3090000b02901ae5b4a3199mr927134pfh.24.1610393439604; Mon, 11 Jan 2021 11:30:39 -0800 (PST) MIME-Version: 1.0 References: <20210108040940.1138-1-walter-zh.wu@mediatek.com> <20210111185902.GA2112090@ubuntu-m3-large-x86> <20210111191154.GA2941328@ubuntu-m3-large-x86> In-Reply-To: <20210111191154.GA2941328@ubuntu-m3-large-x86> From: Andrey Konovalov Date: Mon, 11 Jan 2021 20:30:28 +0100 Message-ID: Subject: Re: [PATCH v3] kasan: remove redundant config option To: Nathan Chancellor Cc: Walter Wu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , "moderated list:ARM/Mediatek SoC..." Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 8:11 PM Nathan Chancellor wrote: > > On Mon, Jan 11, 2021 at 08:03:29PM +0100, Andrey Konovalov wrote: > > On Mon, Jan 11, 2021 at 7:59 PM Nathan Chancellor > > wrote: > > > > > > > > -config KASAN_STACK_ENABLE > > > > > +config KASAN_STACK > > > > > bool "Enable stack instrumentation (unsafe)" if CC_IS_CLANG && !COMPILE_TEST > > > > > > > > Does this syntax mean that KASAN_STACK is only present for > > > > CC_IS_CLANG? Or that it can only be disabled for CC_IS_CLANG? > > > > > > It means that the option can only be disabled for clang. > > > > OK, got it. > > > > > > Anyway, I think it's better to 1. allow to control KASAN_STACK > > > > regardless of the compiler (as it was possible before), and 2. avoid > > > > > > It has never been possible to control KASAN_STACK for GCC because of the > > > bool ... if ... syntax. This patch does not change that logic. Making it > > > possible to control KASAN_STACK with GCC seems fine but that is going to > > > be a new change that would probably be suited for a new patch on top of > > > this one. > > > > The if syntax was never applied to KASAN_STACK, only to > > KASAN_STACK_ENABLE, so it should have been possible (although I've > > never specifically tried it). > > CONFIG_KASAN_STACK was not a user selectable symbol so it was always 1 > for GCC. Ah, indeed. Thanks for the clarification!