From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BD1C43463 for ; Fri, 18 Sep 2020 10:39:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFB6222208 for ; Fri, 18 Sep 2020 10:39:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bZzEE8ST" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFB6222208 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D5828E0005; Fri, 18 Sep 2020 06:39:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 185B18E0001; Fri, 18 Sep 2020 06:39:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09BE18E0005; Fri, 18 Sep 2020 06:39:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id E91118E0001 for ; Fri, 18 Sep 2020 06:39:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A7FDC8249980 for ; Fri, 18 Sep 2020 10:39:52 +0000 (UTC) X-FDA: 77275836624.07.chain85_1d0a5082712a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 8886C1803F9A0 for ; Fri, 18 Sep 2020 10:39:52 +0000 (UTC) X-HE-Tag: chain85_1d0a5082712a X-Filterd-Recvd-Size: 4686 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 10:39:51 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id l191so3235600pgd.5 for ; Fri, 18 Sep 2020 03:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0BA74pq9Zk+EY0B+5KtILBM++vfiF9LClb1TtG0VGMg=; b=bZzEE8ST+6WycOr5Rst39I67wilv5k5SvyGkHPsn3mRhe7ruYp7AzIfSmSL5YMy4+J r+dGj4oYaHC1ALs8NiHp/twhAU0qUWSNOATnubN3m21ylxDXxcTqxofc3KPTdKZad1WQ IEHIsCsDpbojqgbChTdgpPxyX+MWPJEX92ERMR2ZEIEyGhcMVmzM4smWPMNyiYGGdwkj ly6cdPI8/Wsd16ztLensD3N8jRUmelx6HviINExWraokAC0MFiMos0HLdnF9XbWcMUjN RXQqO8k2yiR1wbncuo2s7NM5dEqmzgEaMXaZ1YFX+WAUrMd96adcYIW9Sj0ekeZZli91 q2ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0BA74pq9Zk+EY0B+5KtILBM++vfiF9LClb1TtG0VGMg=; b=HQ39qBheq4q1ejTjzHcLVbM0VgxoIN9cpCnhFl7D6ArJHzLMCMocgyInIm/g/LMbA1 0ydQvPv0es+MfVoAEI4ZvrxGCyRGhwn6HTUr471QwsUFMuxZtrU9WsHpg4iD6c6X4mZl 4cIVNJnBob9JLUh3TePQxL0NllqFA1XQkpbXkJhR0oXMNKEoi9fFQNMnB99GLAg7SU98 b2P769O/v7GLHD27BFuUIjjmPwpOHX1nPheUKUuYyXZRe8x2TVY4b5Wipggx42W8ARO7 ONW4RC4Puc3szv2cZ3MsvVe/Qr+MUpSUw/l5tVy1vJfSraArp0aPq4fqCV5Zp8/z54BF zg/Q== X-Gm-Message-State: AOAM5319rTCTAvihGe36uqh5xPFxS4vzvDTq5N4UKtssAPv/fgpRPJeQ lSrN6Qvoa4+ABAncP0LU2zp15eJc73pgB41AbxmepQ== X-Google-Smtp-Source: ABdhPJxsNJ1/ALFvU9Viq7TgmQqLSQxHS+99JGvGaazSkYkpuVJz6AGEjcS6JGjChCrWVe3VKznLhUu3jPZIQtmbWro= X-Received: by 2002:a62:ee10:0:b029:142:2501:3972 with SMTP id e16-20020a62ee100000b029014225013972mr14985432pfi.55.1600425590587; Fri, 18 Sep 2020 03:39:50 -0700 (PDT) MIME-Version: 1.0 References: <88c275dc4eef13c8bcbe74ecec661733dcbc67b8.1600204505.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 18 Sep 2020 12:39:39 +0200 Message-ID: Subject: Re: [PATCH v2 07/37] kasan: split out shadow.c from common.c To: Alexander Potapenko Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 10:17 AM Alexander Potapenko wrote: > > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > > new file mode 100644 > > index 000000000000..4888084ecdfc > > --- /dev/null > > +++ b/mm/kasan/shadow.c > > @@ -0,0 +1,509 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * This file contains KASAN shadow runtime code. > > I think it will be nice to mention here which KASAN modes are going to > use this file. Will do in v3. > > +#undef memset > > +void *memset(void *addr, int c, size_t len) > > +{ > > + if (!check_memory_region((unsigned long)addr, len, true, _RET_IP_)) > > + return NULL; > > + > > + return __memset(addr, c, len); > > +} > > + > > OOC, don't we need memset and memmove implementations in the > hardware-based mode as well? Hardware mode uses native memset implementation as all memory access instructions are checked by the hardware anyway. > > + region_start = ALIGN(start, PAGE_SIZE * KASAN_GRANULE_SIZE); > > + region_end = ALIGN_DOWN(end, PAGE_SIZE * KASAN_GRANULE_SIZE); > > "PAGE_SIZE * KASAN_GRANULE_SIZE" seems to be a common thing, can we > give it a name? This patch just moves the already existing code, but I can fix this in a separate patch.