From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A086AC433E0 for ; Mon, 8 Mar 2021 14:16:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4494D6512B for ; Mon, 8 Mar 2021 14:16:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4494D6512B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CCA1A8D002F; Mon, 8 Mar 2021 09:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1FA8D001D; Mon, 8 Mar 2021 09:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B69658D002F; Mon, 8 Mar 2021 09:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 9C4368D001D for ; Mon, 8 Mar 2021 09:16:49 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5E7AB824999B for ; Mon, 8 Mar 2021 14:16:49 +0000 (UTC) X-FDA: 77896908138.03.6B68252 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf18.hostedemail.com (Postfix) with ESMTP id BCA242000383 for ; Mon, 8 Mar 2021 14:16:48 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id g4so6493075pgj.0 for ; Mon, 08 Mar 2021 06:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=o+U3uLj/MTWI/WnVGPqlD6bxQPjQLWYNbYeWyg5OtXhJZtnF5QsfwC6uq/PN/KqSBv L89RvIDZAM3pr6p4HBVvuwVIxP30I6MI2oVGpDIPZ4MWGA4EIUD/DYBLe1G/DlhbyyO0 GAQGMqfv8JxfVGyUqE/fRYcXPD2hKSNZvHR7MaBPuVCBR781NmjLLKKeCoNyuvxEIunj TkOz4nN/4iO7zf1Xg/osQmzUIG/2foVQ9VdONOGwCBPMVykxqhDI/kjKkaxXB2dMjaEw FJCBnL7b6tevkBWuzSrS300s5XtR62ewi1NA3iF1wlsx10TEtAwiv0pY4sJN1+xcXi7W Su5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEz/5tRpd1vxpBiKzm6wcWNrysLEXvrjN5n42Rt2ppk=; b=HPH3WhjFjmKiUDxLf3ex9JktsxugT+41sYYEvuqj/vBOLVVlsfsmOt/wjoAYph5Kmz jX6d6unp1vYiuZyIsxwTwE8QrwywAws/5rJD9qVkxlrwTuCFSAcSCEWU4WXqvK7hu3ep SkeiQSTLRr6clfj3HlifwSu8CNCm4dqQnInJSrOhHxK6+QhAYQ02v1y+4RbFJvjyXkFK xMnpblLyKWAu7GVtVXyzoLDdlQSG8YS2TcCDEEZekcvYlZunMHsYess5zf3JO7chgCkX a+o4qaJ6VD8WYmVNxqBnwt6PDqsBf4J81mtsAlHvw+XFH4wx6Z3/b8GhA77crPJAwxN8 FAGA== X-Gm-Message-State: AOAM533BC0z3L3xgAkeJzklF/hDkYpiGe4Zmamv8MRRfKz88UADY01Pv Td3TEsM2cNu+/FfkZBNOtnLbk0s3mJd/bk3pw18xbg== X-Google-Smtp-Source: ABdhPJyAp/P5kFJMxbcLsevox5U3CG3+Kx9o3JHlkHdZvbegTiBwdTL3Q4As4bAkrSTLq5PRYZOymxznMF9dggO3H3U= X-Received: by 2002:a63:f14b:: with SMTP id o11mr20763989pgk.440.1615213006419; Mon, 08 Mar 2021 06:16:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 8 Mar 2021 15:16:35 +0100 Message-ID: Subject: Re: [PATCH 5/5] kasan, mm: integrate slab init_on_free with HW_TAGS To: Marco Elver Cc: Alexander Potapenko , Andrew Morton , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 59z1j8fjxrtfc8qckopfs6ibnxrkyx4b X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BCA242000383 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-pg1-f179.google.com; client-ip=209.85.215.179 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615213008-538921 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 8, 2021 at 12:45 PM Marco Elver wrote: > > > > > - if (unlikely(slab_want_init_on_free(cachep))) > > + /* > > + * As memory initialization is integrated with hardware tag-based > > This may no longer be true if the HW-tags architecture doesn't support > init (although currently it is certainly true). > > Perhaps: "As memory initialization may be accelerated by some KASAN > implementations (such as some HW_TAGS architectures) ..." > > or whatever else is appropriate. Will change the comment here and in other patches, thanks!