From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E510C433DB for ; Tue, 12 Jan 2021 20:04:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A5EDF22CAD for ; Tue, 12 Jan 2021 20:04:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5EDF22CAD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 197C56B00BF; Tue, 12 Jan 2021 15:04:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 147FE6B00C1; Tue, 12 Jan 2021 15:04:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0361C6B00C2; Tue, 12 Jan 2021 15:04:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id E330D6B00BF for ; Tue, 12 Jan 2021 15:04:54 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AC8901EE6 for ; Tue, 12 Jan 2021 20:04:54 +0000 (UTC) X-FDA: 77698201308.25.talk09_3b0ee8e27518 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 3066D1804E55C for ; Tue, 12 Jan 2021 20:04:47 +0000 (UTC) X-HE-Tag: talk09_3b0ee8e27518 X-Filterd-Recvd-Size: 4161 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 20:04:46 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id q4so1994914plr.7 for ; Tue, 12 Jan 2021 12:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hLTG8Xi/M9/KLF1jIe2hcQQ+UFUOXooQujW3N5lnPGo=; b=Cs+4su4TJkM8QcOSmf0OcuHbESzt6w52kRbeUZamzlyoFwYvoll9zEhkOZveAYuCM+ Eu4sCnw4sn8/zHQxtY9yGVm1ndHlBVJ+/wsmnusUu0SvtVkGlIaOo8AHfduaWZao5NOw C2tq0o4CVrk60JxPesRFOB7f3uMf4a2Kk018t70tas3/41eADOJiuVyckst7tIkX05RJ qYtJW/L6l6mHyYAG0ds7lphmJbHYhQAtvUgy0RjYIX8XPh/psWdZdPHKWnPH1ajqUjUC wy+D5JV2GlFUC2NcGOq0Grm/S1ejHC7clYhKUFUceykGabKD9o4Tzy4VRGHs1Eh9IShM nyLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hLTG8Xi/M9/KLF1jIe2hcQQ+UFUOXooQujW3N5lnPGo=; b=RIor0WeijOLOBsKuBXQqPwVdf0ttHJD489HsH/bjJzLw6Zu1ypYKt8NkRP/anv32P5 7ctk14NBHADBJXwDK/L6FbjS/eA8XRIDGoOUaHjigjjX0gY7CKmA1DhbkhLobY54dm+P L1AUG1hBNo8gBDAeo7hwK/1swLu1ToSbCLHljIBXBaCKS/gy8HBSjzxt6f29QJX2CAYH RpVbVITqHfL7qcmPEsXm3XDoiQKDTgDMlLTCLmeqk8kpDbTbhcvPRwZBznFLBGHmfwp7 QKwqI6wSnw68Bxd+qRgWG1dCyiJqmM+dluYm3sizyVCj40yBNak8xt1D1DwM8H23JahF saBg== X-Gm-Message-State: AOAM532wPs+9ShTYVzPI8ena1CjrAdJE4+wFAxewunEicFZGVO2bhE7e FsAXdZsQm16aNuv8Oe1BDRZPsSNmKxMoZku1tZ1h/g== X-Google-Smtp-Source: ABdhPJxkdxK1pakMNPh5u9Y88KHsc9X/m/5rZ5VmLzgq01yUHKx7e6nwWFvKQONa6Zc+hCGiVVA4jFpgf8nnPAUv7oc= X-Received: by 2002:a17:902:c144:b029:dc:292e:a8a1 with SMTP id 4-20020a170902c144b02900dc292ea8a1mr826431plj.13.1610481885659; Tue, 12 Jan 2021 12:04:45 -0800 (PST) MIME-Version: 1.0 References: <9a4f47fe8717b4b249591b307cdd1f26c46dcb82.1609871239.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 12 Jan 2021 21:04:34 +0100 Message-ID: Subject: Re: [PATCH 08/11] kasan: adopt kmalloc_uaf2 test to HW_TAGS mode To: Alexander Potapenko Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Marco Elver , Andrew Morton , Will Deacon , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 12, 2021 at 9:26 AM Alexander Potapenko wrote: > > Nit: s/adopt/adapt in the title. > > > > +again: > > ptr1 = kmalloc(size, GFP_KERNEL); > > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr1); > > > > @@ -384,6 +386,13 @@ static void kmalloc_uaf2(struct kunit *test) > > ptr2 = kmalloc(size, GFP_KERNEL); > > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr2); > > > > + /* > > + * For tag-based KASAN ptr1 and ptr2 tags might happen to be the same. > > + * Allow up to 4 attempts at generating different tags. > > + */ > > + if (!IS_ENABLED(CONFIG_KASAN_GENERIC) && ptr1 == ptr2 && counter++ < 4) > > + goto again; > > + > > Looks like we are leaking memory allocated for ptr2 here? Will fix in v2, thanks!