From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E44C4741F for ; Thu, 29 Oct 2020 20:14:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3DB320720 for ; Thu, 29 Oct 2020 20:14:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ds1NXPTL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3DB320720 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0965D6B005C; Thu, 29 Oct 2020 16:14:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 047056B0062; Thu, 29 Oct 2020 16:14:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E76C46B0068; Thu, 29 Oct 2020 16:14:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id BA52E6B005C for ; Thu, 29 Oct 2020 16:14:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5035B181AEF0B for ; Thu, 29 Oct 2020 20:14:25 +0000 (UTC) X-FDA: 77426065290.29.wound70_0c01cce27290 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 2F26B180868EC for ; Thu, 29 Oct 2020 20:14:25 +0000 (UTC) X-HE-Tag: wound70_0c01cce27290 X-Filterd-Recvd-Size: 5621 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 20:14:24 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id r10so3259003pgb.10 for ; Thu, 29 Oct 2020 13:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l77n7oC/IyxQLfCBGbQpiCRFFdLcSomb1vOdKMROYRs=; b=ds1NXPTLGAXIZvjdJi8ugrSM70FcHWuCIwYhaH9mhI0HA2QijV79tt6Un83nE1oEtt r7Y+dzoiRxdMlrHyTfcqQgImddaXj3XlqhWWqsGwcu2xttvbypodQ1yJ26YGBEA+aWJP mQVxPDIZ7xqLXmW0cU4LeyBmE5rqJ3Qsjglgq/rJdcwLdvHOMRLoRB9p7k0aJqp8svWb OngF2h0IigTb1bVv+YWfkgUqjB+yFO3CJ20NB1RewecioLbCJiogpIK/WlBmbXLKzkS/ dtLY/IYCtE5jowS4o6YN5IOIJWOUNzK8/oVJfM8zhr8DkB6vxsF6wOITqqPRSAUzKKT3 3hsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l77n7oC/IyxQLfCBGbQpiCRFFdLcSomb1vOdKMROYRs=; b=O70vdKWAEtj5OUxcE8lRnq+9tBLCt5KHsEzA50+gaH+/eGu92Dy3+VlRnv4+rw9Qoj t1T2yubhmn0dZSB6Z9ohTxCBSeDtLXAcq807biS5V6kas7TCX1cmPxlEVdiRj0R9h8Fl K5zCyTORUMaDMJLWa7vrTU+AWeon8NAdDTjuH3qW1HZ8uNxDBlhAFDTnhbyNajlyRA13 wFgPO/GPcGCVxDGj+yJhrSTVItRd4LZ+RTdJBSPsWum5M5UyApTq3CUSXL2HGye2Vu9+ mZ74bmUhgyZpby1tg+tEWfIFKnRlXBUtGX6WBXl3gVyu/YpagSoxX12znbjeviWOdQBm IMOg== X-Gm-Message-State: AOAM533pcVJKUoJbug7wt15gcLGoE0126pZmCaEBQ614ZSPVNUnj/HFn qv7ImJ+9Yb0zyTB9sa+Zn1PHmecjEz1VfTKqWpZAfA== X-Google-Smtp-Source: ABdhPJx9GJFDbjQtalHbXpz4QpT9HD1QKsnubeBrC4C75nQUTCYmo2axiD2dLWceppBeCeuRufluBFF+z94cSUugzCc= X-Received: by 2002:a17:90a:cb92:: with SMTP id a18mr1508972pju.136.1604002463411; Thu, 29 Oct 2020 13:14:23 -0700 (PDT) MIME-Version: 1.0 References: <1d87f0d5a282d9e8d14d408ac6d63462129f524c.1603372719.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 29 Oct 2020 21:14:12 +0100 Message-ID: Subject: Re: [PATCH RFC v2 07/21] kasan, arm64: move initialization message To: Dmitry Vyukov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 28, 2020 at 11:56 AM Dmitry Vyukov wrote: > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > > > Tag-based KASAN modes are fully initialized with kasan_init_tags(), > > while the generic mode only requireds kasan_init(). Move the > > initialization message for tag-based modes into kasan_init_tags(). > > > > Also fix pr_fmt() usage for KASAN code: generic mode doesn't need it, > > Why doesn't it need it? What's the difference with tag modes? I need to reword the patch descriptions: it's not the mode that doesn't need it, it's the generic.c file, as it doesn't use any pr_*() functions. > > > tag-based modes should use "kasan:" instead of KBUILD_MODNAME. > > With generic KASAN I currently see: > > [ 0.571473][ T0] kasan: KernelAddressSanitizer initialized > > So KBUILD_MODNAME somehow works. Is there some difference between files? That code is printed from arch/xxx/mm/kasan_init*.c, which has its own pr_fmt defined. > > > Signed-off-by: Andrey Konovalov > > Link: https://linux-review.googlesource.com/id/Idfd1e50625ffdf42dfc3dbf7455b11bd200a0a49 > > --- > > arch/arm64/mm/kasan_init.c | 3 +++ > > mm/kasan/generic.c | 2 -- > > mm/kasan/hw_tags.c | 4 ++++ > > mm/kasan/sw_tags.c | 4 +++- > > 4 files changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > > index b6b9d55bb72e..8f17fa834b62 100644 > > --- a/arch/arm64/mm/kasan_init.c > > +++ b/arch/arm64/mm/kasan_init.c > > @@ -290,5 +290,8 @@ void __init kasan_init(void) > > { > > kasan_init_shadow(); > > kasan_init_depth(); > > +#if defined(CONFIG_KASAN_GENERIC) > > + /* CONFIG_KASAN_SW/HW_TAGS also requires kasan_init_tags(). */ > > A bit cleaner way may be to introduce kasan_init_early() and > kasan_init_late(). Late() will do tag init and always print the > message. It appears we'll also need kasan_init_even_later() for some MTE-related stuff. I'll try to figure out some sane naming scheme here and include it into the next version.