From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C28C433E0 for ; Tue, 4 Aug 2020 12:27:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B90EB22BED for ; Tue, 4 Aug 2020 12:27:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NcQ2Qf6i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B90EB22BED Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C1828D0154; Tue, 4 Aug 2020 08:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 072548D0081; Tue, 4 Aug 2020 08:27:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA2D18D0154; Tue, 4 Aug 2020 08:27:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id D09F28D0081 for ; Tue, 4 Aug 2020 08:27:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6215A1EF1 for ; Tue, 4 Aug 2020 12:27:41 +0000 (UTC) X-FDA: 77112812322.16.boy11_3712a0b26fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id A9751100E690C for ; Tue, 4 Aug 2020 12:27:40 +0000 (UTC) X-HE-Tag: boy11_3712a0b26fa6 X-Filterd-Recvd-Size: 5173 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 12:27:38 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id t6so22008324pgq.1 for ; Tue, 04 Aug 2020 05:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BSEtcZMeEfd836sEUlnMwgLoZphV8omnRj5UAHtlG3M=; b=NcQ2Qf6i6p0NsVefmKlSDeQGR0LxrvqW/MhO+giMOwwmpXOiESMnpG/4G/LNzKITX5 IdO44RhspOLAdVbDji/3twZBufSBi07TadDGckBsTb/YAoBJOAf0OHzsGOfa/LudQ4p8 tjEeTgYs4QcQ1kcPlUK7JUIszd50AorZexxq52+rFQA2yzQ1cHfe+iHgMCYqIMcAt486 ltUwGI90BEnzsgcPfQwnYimgQstHjeLm7M6s+OnjlXzmjutcNL7cP1F5WT/2JtMIbftv 4yDoPO9uAVmVZ5+5bPswV6uhqICoBODDlh2/KgNDs8qNGCPNtz5XtJ2MDQepmk+uuMr9 CV9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BSEtcZMeEfd836sEUlnMwgLoZphV8omnRj5UAHtlG3M=; b=GVXliKMVPNOcFCuv+1jO6cCCDqM8yjL6d73ZMY8vAqgSecjQ8NvltHhxlYm9SY0uPR F/xtRIFwQOrxdjtXcWFOM5PVsPaaT7Z1pHZGYr4tVqfLSylzlaSminBUrXGUAF8nYDns p1PmqZUB04iNOrMrfY7MPQBkDKQHWRBmVun9I9nI+68Zews3zBcNgKhCXCFuQ4O0ylM6 AGjgOf8OgZMgpSzZfqESRyJB986dwi0d/OGRMWLaUUlyLBfT3aad7dXR8efwAcGNCC9E 6ruKSiMKFpNRjxIEWyYQzfEcqN4W40usXw2eKb5IGI4fDp9D1g+ZSn5BG/fLSkp8YEtR ADog== X-Gm-Message-State: AOAM533ywfANLMEpgodaqgR23/mAun/RbaQONBYw1SdqxXF3AYhhJk7g ZIZ6BucCzO/lldeH/Pg3IXwphp8q0ePSXEfiQz6hng== X-Google-Smtp-Source: ABdhPJyXgZYHbw7Ug34k6Xe4thc7d74c1Y2g/5Ry8C4VwXrnQ70vm/WuZoCvs3qVyJ7svWsaAL7mIri32LVnz90BFrE= X-Received: by 2002:aa7:97a3:: with SMTP id d3mr20240734pfq.178.1596544057176; Tue, 04 Aug 2020 05:27:37 -0700 (PDT) MIME-Version: 1.0 References: <202008020649.TJ8Zu7ei%lkp@intel.com> <20200803180358.GA1299225@rani.riverdale.lan> In-Reply-To: <20200803180358.GA1299225@rani.riverdale.lan> From: Andrey Konovalov Date: Tue, 4 Aug 2020 14:27:26 +0200 Message-ID: Subject: Re: [hnaz-linux-mm:master 168/421] init/main.c:1012: undefined reference to `efi_enter_virtual_mode' To: Arvind Sankar , Ard Biesheuvel Cc: linux-efi@vger.kernel.org, Dmitry Vyukov , Alexander Potapenko , kasan-dev , Andrey Ryabinin , kbuild-all@lists.01.org, Johannes Weiner , Andrew Morton , Linux Memory Management List , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A9751100E690C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 3, 2020 at 8:04 PM Arvind Sankar wrote: > > On Mon, Aug 03, 2020 at 05:37:32PM +0200, Andrey Konovalov wrote: > > On Sun, Aug 2, 2020 at 12:25 AM kernel test robot wrote: > > > > > > tree: https://github.com/hnaz/linux-mm master > > > head: 2932a9e66c580f3c8d95ec27716d437198fb4c94 > > > commit: 7c0265f304de3c3acd02d0015b56a076357bcce3 [168/421] kasan, arm64: don't instrument functions that enable kasan > > > config: x86_64-randconfig-r036-20200802 (attached as .config) > > > compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 > > > reproduce (this is a W=1 build): > > > git checkout 7c0265f304de3c3acd02d0015b56a076357bcce3 > > > # save the attached .config to linux build tree > > > make W=1 ARCH=x86_64 > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All errors (new ones prefixed by >>): > > > > > > ld: init/main.o: in function `start_kernel': > > > >> init/main.c:1012: undefined reference to `efi_enter_virtual_mode' > > > > Hm, I can reproduce the issue, but I don't understand why it happens. > > > > +EFI and KASAN people, maybe someone has an idea. > > > > This is the guilty patch: > > > > https://github.com/hnaz/linux-mm/commit/7c0265f304de3c3acd02d0015b56a076357bcce3 > > > > The issue is only with efi_enter_virtual_mode() AFAIU, not with any of > > the other functions. > > > > Thanks! > > > > After adding __no_sanitize_address, gcc doesn't inline efi_enabled() on > a KASAN build, even when CONFIG_EFI is disabled, and the function is > just > return false; > and so it isn't optimizing out the call to efi_enter_virtual_mode(). > > Making efi_enabled() __always_inline fixes this, but not sure if that is > the correct fix? Ah, makes sense. We could also do #if defined(CONFIG_X86) && defined(CONFIG_EFI) in start_kernel(). Or provide an empty efi_enter_virtual_mode() implementation when CONFIG_EFI isn't enabled. Ard, WDYT? Thanks!