From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E35C00A89 for ; Fri, 30 Oct 2020 16:35:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7CB9420756 for ; Fri, 30 Oct 2020 16:35:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="niyYm0qY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CB9420756 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D62EA6B005C; Fri, 30 Oct 2020 12:35:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1BAD6B0071; Fri, 30 Oct 2020 12:35:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDA156B0073; Fri, 30 Oct 2020 12:35:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 8FEFE6B005C for ; Fri, 30 Oct 2020 12:35:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 338118249980 for ; Fri, 30 Oct 2020 16:35:09 +0000 (UTC) X-FDA: 77429141538.07.grape56_3715de927297 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 0550E1803F9A2 for ; Fri, 30 Oct 2020 16:35:08 +0000 (UTC) X-HE-Tag: grape56_3715de927297 X-Filterd-Recvd-Size: 4512 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 30 Oct 2020 16:35:08 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id e7so5724657pfn.12 for ; Fri, 30 Oct 2020 09:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OEG72fK9A86Aj1ReEdXuRoNmABKVsj8ImdviwWVYFfY=; b=niyYm0qY8CzMDjQFR0wk09rUFovgBIJqmkwyaohlBE8Xuf8D7EO7pmDLYAO52Q4Yvf 82ZicSGjt6o0IgPJp09nq6DevXQ3+b0pAc6z3ZqEeQ0GHi8yBJqz7ty1e2sfPbG4sRz0 1cOaAbENqXkyChFeCj5oGwedqUrwkqIaA9N4iN672mYgSp7HTiftJKBg2bOrWNpBz5lk +nGWSc2U2T0NPgIVEdW7PNQfTxFEhRqbbQXWLZf9txYposExkV0K1+kTiiGfuaJoxMC1 eIkI2PvlQzLqzG2m5l2vTTq9uk9P+OGmAemu02kGvkUJyLwA/lOZsJ8GWC0Bf3jSpdGa AE5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OEG72fK9A86Aj1ReEdXuRoNmABKVsj8ImdviwWVYFfY=; b=RG/C5moMSBpXqjRaNEjdVtgpMM7NQtRii0tpmIuunK/W7pARvIekcgPzpnDRd4UW2v L8L4I57O/ChY5iareKWvv3FaHJ/ZFoQujXxceD5F8Db/s43IAa/PSVkpguKk6gkOerB6 LukEr7aFXr2MujIRcRRN5jbfALVdwF7FDojGF9Isf186lFfD7gYo4nNsSFhU9E+wOvU+ DCe0awfGlSfrI7dHZYy0mT1IQMqFM0MhvnyQYClFV7bTLlWDsdch48ixtOQ6i2D8QG6W YA/NTo2kzBETkIX4H/tKGxUjLIit8OFRcr2WlGpyr3ygxH54xbfxFbMGgiU1ycZ39ApG ieEA== X-Gm-Message-State: AOAM531TECWUQdLvlD0ORN3LQls9VGkVCGNTYNIKwRILEiIWE6U3ifY0 lz4YZN1pWplQbEEBU7Bq0WkSt9589o5SEIEhw7du9Q== X-Google-Smtp-Source: ABdhPJypb5pDbULIOedvBhhhhPVQ4Wd1RYf+aGclJw2Xgj+SjC3Hpi43QPbQ/asszFlJWnfh3RXkLp7IystdA99AI/E= X-Received: by 2002:a63:d456:: with SMTP id i22mr2896479pgj.440.1604075707465; Fri, 30 Oct 2020 09:35:07 -0700 (PDT) MIME-Version: 1.0 References: <6f87cb86aeeca9f4148d435ff01ad7d21af4bdfc.1603372719.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 30 Oct 2020 17:34:56 +0100 Message-ID: Subject: Re: [PATCH RFC v2 12/21] kasan: inline and rename kasan_unpoison_memory To: Dmitry Vyukov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 28, 2020 at 12:36 PM Dmitry Vyukov wrote: > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > > > Currently kasan_unpoison_memory() is used as both an external annotation > > and as internal memory poisoning helper. Rename external annotation to > > kasan_unpoison_data() and inline the internal helper for for hardware > > tag-based mode to avoid undeeded function calls. > > > > There's the external annotation kasan_unpoison_slab() that is currently > > defined as static inline and uses kasan_unpoison_memory(). With this > > change it's turned into a function call. Overall, this results in the > > same number of calls for hardware tag-based mode as > > kasan_unpoison_memory() is now inlined. > > Can't we leave kasan_unpoison_slab as is? Or there are other reasons > to uninline it? Just to have cleaner kasan.h callbacks definitions. > It seems that uninling it is orthogonal to the rest of this patch. I can split it out into a separate patch if you think this makes sense?