From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCCDC55ABD for ; Thu, 12 Nov 2020 19:38:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 29EE922241 for ; Thu, 12 Nov 2020 19:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UaHMcC73" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29EE922241 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 339EB6B0036; Thu, 12 Nov 2020 14:38:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E9076B005C; Thu, 12 Nov 2020 14:38:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B2956B0068; Thu, 12 Nov 2020 14:38:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id DD5A36B0036 for ; Thu, 12 Nov 2020 14:38:42 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8CD14180AD801 for ; Thu, 12 Nov 2020 19:38:42 +0000 (UTC) X-FDA: 77476778484.08.eggs69_01015ff27308 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id EBE4F1819E785 for ; Thu, 12 Nov 2020 19:38:41 +0000 (UTC) X-HE-Tag: eggs69_01015ff27308 X-Filterd-Recvd-Size: 5196 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 19:38:41 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id j5so3321623plk.7 for ; Thu, 12 Nov 2020 11:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wcGaGdNjvzbWsM/1VlFfBlGElmPXvO3Myj4l26gebaE=; b=UaHMcC73bqlweF20yyhuSOecd8L/pYt6mDoNZhyPNwm7NL0fx2MmHkrQAALHa3Gfk3 3gEYco8Pg+cDJvbeDn/zphQtsjJvI0LFuUldxAOFqhsnzzFt5seRcliywEi4x30idZku HPwPRasVkNMOv92fTjGeR748hRxavgKX8gEniwRKqMGSi6i4WS+TvaGWrrxqQ14Wqayw oa6Uq42hSGMhSDMpECwlt2Ip272K9oIfQ+5OOEBscde11Lb39l+YDOD27zKc+IJY0OG6 H5cTJ72+vuKTarQh/l2uVlrD0oPx9Wwox7PJwUpJ9asm1wqnayztd9ghHK6vmnPzDrMb ZOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wcGaGdNjvzbWsM/1VlFfBlGElmPXvO3Myj4l26gebaE=; b=SUARrOcZUQB7UPGZKUgqO6eq/PoY63kDn3qyI1oRYdt2C5jEY+Kg7WZBimkBIgwwqC faxD9Gg+44elOqM/hUmfEzPuWlhl7P6F4K3anmm7JbomTKzdsEz3j9Ih9JxpERIaKll7 egp2oHCE2atFqUHV2qU3uyQnuRBjL4VfJWnVp/7GbDSso3r7OkSGiSDJgdEvKlkNtG2m unCo1+VPvlTAxRCsDpnGJCYWyMeguHdIp2seMon8sdNqn1oAM/rCu51BgS0dfQoqDoNS 4b8CkZyemjYqbrdSUwh0hr6csj0rIQ4GKrkumZIBOvUZncg0wGA8fV9toUw9+e4u8s2r IuyQ== X-Gm-Message-State: AOAM5316hxxTO8MjZ45z4F1ZYRRNuBAHBvrx2Efj81WVxML4QVdeQnPc Ndkr7+FFQb9kjWfDPnT08x+wzEvyt91y2NOBs4ThGA== X-Google-Smtp-Source: ABdhPJw3EggJuJym6L46mb4rsq/rHrQlrqJpcdplZS7f6XLN7t2N1sDujX0apEw8lwdtdOBo0+6BEaQTDI5inPJvc6E= X-Received: by 2002:a17:902:bb95:b029:d7:db34:2ddb with SMTP id m21-20020a170902bb95b02900d7db342ddbmr742376pls.85.1605209920187; Thu, 12 Nov 2020 11:38:40 -0800 (PST) MIME-Version: 1.0 References: <7e95d4739f5617b2c1acf52f37e01f1ca83750b5.1605046662.git.andreyknvl@google.com> <20201112095134.GI29613@gaia> In-Reply-To: <20201112095134.GI29613@gaia> From: Andrey Konovalov Date: Thu, 12 Nov 2020 20:38:29 +0100 Message-ID: Subject: Re: [PATCH v2 04/20] kasan, arm64: unpoison stack only with CONFIG_KASAN_STACK To: Catalin Marinas Cc: Dmitry Vyukov , Alexander Potapenko , Marco Elver , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 12, 2020 at 10:51 AM Catalin Marinas wrote: > > On Tue, Nov 10, 2020 at 11:20:08PM +0100, Andrey Konovalov wrote: > > There's a config option CONFIG_KASAN_STACK that has to be enabled for > > KASAN to use stack instrumentation and perform validity checks for > > stack variables. > > > > There's no need to unpoison stack when CONFIG_KASAN_STACK is not enabled. > > Only call kasan_unpoison_task_stack[_below]() when CONFIG_KASAN_STACK is > > enabled. > > > > Note, that CONFIG_KASAN_STACK is an option that is currently always > > defined when CONFIG_KASAN is enabled, and therefore has to be tested > > with #if instead of #ifdef. > > > > Signed-off-by: Andrey Konovalov > > Link: https://linux-review.googlesource.com/id/If8a891e9fe01ea543e00b576852685afec0887e3 > > --- > > arch/arm64/kernel/sleep.S | 2 +- > > arch/x86/kernel/acpi/wakeup_64.S | 2 +- > > include/linux/kasan.h | 10 ++++++---- > > mm/kasan/common.c | 2 ++ > > 4 files changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/kernel/sleep.S b/arch/arm64/kernel/sleep.S > > index ba40d57757d6..bdadfa56b40e 100644 > > --- a/arch/arm64/kernel/sleep.S > > +++ b/arch/arm64/kernel/sleep.S > > @@ -133,7 +133,7 @@ SYM_FUNC_START(_cpu_resume) > > */ > > bl cpu_do_resume > > > > -#ifdef CONFIG_KASAN > > +#if defined(CONFIG_KASAN) && CONFIG_KASAN_STACK > > mov x0, sp > > bl kasan_unpoison_task_stack_below > > #endif > > I don't understand why CONFIG_KASAN_STACK is not a bool (do you plan to > add more values to it?) but for arm64: I don't remember if there's an actual reason. Perhaps this is something that can be reworked later, but I don't want to get into this in this series. > Acked-by: Catalin Marinas Thanks!