From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BECB4C2D0A3 for ; Wed, 4 Nov 2020 19:32:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A80E2065D for ; Wed, 4 Nov 2020 19:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="N5iD+1F5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A80E2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7058B6B0083; Wed, 4 Nov 2020 14:32:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B4366B0088; Wed, 4 Nov 2020 14:32:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A3E96B0089; Wed, 4 Nov 2020 14:32:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 1F30F6B0083 for ; Wed, 4 Nov 2020 14:32:58 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9F75D1EE6 for ; Wed, 4 Nov 2020 19:32:57 +0000 (UTC) X-FDA: 77447733594.21.wood20_3218247272c3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 86E05180442C4 for ; Wed, 4 Nov 2020 19:32:57 +0000 (UTC) X-HE-Tag: wood20_3218247272c3 X-Filterd-Recvd-Size: 5941 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Nov 2020 19:32:56 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id b12so10774930plr.4 for ; Wed, 04 Nov 2020 11:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gp5b6Mr5Qne4OLUNKLGgmsC9HZETysD3ixRMlsHSDMc=; b=N5iD+1F5uK/kOBzhFYBZ0IzKOpjBGNCgKj8530rROc8SKWuoKXrZ8aU5u/UtoSG0v0 I0Z0XWi4q4u2a1TlsnMy+FTFoqDv/Qn735BY6cMeepjbea79QsEFfDhzMV5PGaWNUmXH Uct41CfIYwD89j7Rg6tjcyQbRDYRz6nVcmhwwtKsWgVROXy8wg/LaI8Q7Bm9HPngYdy0 RIiczr/wo/E6Ber+by1Zrc9Pi4MrKiT55D8VHKRy1uBTFnu4gHWxAXVkmNZIgYCLYf1c pFQ7R9TOuotRJMZpsh3XmmiR5NrW4ryDKmBWYhukFQfk7t+vZogJPkIxC6ziTJbgFp9v yfFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gp5b6Mr5Qne4OLUNKLGgmsC9HZETysD3ixRMlsHSDMc=; b=H2guKbL2RX7hELUGqJhrd3mIHCZ5vJrSnhjBWSWDaOPmblHSvNU/pA7caH/JwVegq+ Ndj8F+rWo1Z41qGQ86RG+6j2Ga+L9Iffo7b4rbDAgdAPyzH2AhOMT9YRNX35R2vkY54A hWURqRxhgEyp/DSfLxufC9p3lza5GigiTHJHKbBLzpPcu/Qqu2FPDA1AkswoZsinjVft xFv23E2KPIZkU6Cq+ftwULkJo4rvacQHacMNjUKDoUdp1scw3RvGT6sCy1ASVdU5FkH8 xvSL/iDMKhPY37D3s4lJLhOyRdcsTOqYn4VlqTduh3JywJKtoOjCQ+am85gChRdZgHVX NpaQ== X-Gm-Message-State: AOAM533/nxa84yff18p5kQCAz9Fj/XE8LgKBWZ013eGbgJyG0anUo5j2 GhewDrHVRV8xD96aLi2XPiEqYDHmJ8JPiIsb7yLPiw== X-Google-Smtp-Source: ABdhPJyAnyC37voV+ffqeE/IhReZhVQ3JFVD+XLQetQ/ANZXU3wdL6dME3kIHqAQgZFoNFrpYn4D6tvjyWbLAd1IbKA= X-Received: by 2002:a17:902:e993:b029:d6:41d8:9ca3 with SMTP id f19-20020a170902e993b02900d641d89ca3mr32168650plb.57.1604518375779; Wed, 04 Nov 2020 11:32:55 -0800 (PST) MIME-Version: 1.0 References: <4dee872cf377e011290bbe2e90c7e7fd24e789dd.1604333009.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 4 Nov 2020 20:32:44 +0100 Message-ID: Subject: Re: [PATCH v7 16/41] kasan: rename KASAN_SHADOW_* to KASAN_GRANULE_* To: Vasily Gorbik Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , kasan-dev , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 4, 2020 at 8:30 PM Vasily Gorbik wrote: > > On Wed, Nov 04, 2020 at 08:22:07PM +0100, Andrey Konovalov wrote: > > On Wed, Nov 4, 2020 at 8:11 PM Vasily Gorbik wrote: > > > > > > On Mon, Nov 02, 2020 at 05:03:56PM +0100, Andrey Konovalov wrote: > > > > This is a preparatory commit for the upcoming addition of a new hardware > > > > tag-based (MTE-based) KASAN mode. > > > > > > > > The new mode won't be using shadow memory, but will still use the concept > > > > of memory granules. Each memory granule maps to a single metadata entry: > > > > 8 bytes per one shadow byte for generic mode, 16 bytes per one shadow byte > > > > for software tag-based mode, and 16 bytes per one allocation tag for > > > > hardware tag-based mode. > > > > > > > > Rename KASAN_SHADOW_SCALE_SIZE to KASAN_GRANULE_SIZE, and KASAN_SHADOW_MASK > > > > to KASAN_GRANULE_MASK. > > > > > > > > Also use MASK when used as a mask, otherwise use SIZE. > > > > > > > > No functional changes. > > > > > > > > Signed-off-by: Andrey Konovalov > > > > Signed-off-by: Vincenzo Frascino > > > > Reviewed-by: Marco Elver > > > > --- > > > > Change-Id: Iac733e2248aa9d29f6fc425d8946ba07cca73ecf > > > > --- > > > > Documentation/dev-tools/kasan.rst | 2 +- > > > > lib/test_kasan.c | 2 +- > > > > mm/kasan/common.c | 39 ++++++++++++++++--------------- > > > > mm/kasan/generic.c | 14 +++++------ > > > > mm/kasan/generic_report.c | 8 +++---- > > > > mm/kasan/init.c | 8 +++---- > > > > mm/kasan/kasan.h | 4 ++-- > > > > mm/kasan/report.c | 10 ++++---- > > > > mm/kasan/tags_report.c | 2 +- > > > > 9 files changed, 45 insertions(+), 44 deletions(-) > > > > > > hm, this one got escaped somehow > > > > > > lib/test_kasan_module.c: > > > 18 #define OOB_TAG_OFF (IS_ENABLED(CONFIG_KASAN_GENERIC) ? 0 : KASAN_SHADOW_SCALE_SIZE) > > > > You mean it's not on the patch? It is, almost at the very top. > > lib/test_kasan_module.c != lib/test_kasan.c > > I fetched your branch. And I had to fix it up to build old good kasan > test module CONFIG_TEST_KASAN_MODULE=m Ah, right, it was just recently merged into mainline, that's why it's missing. Thanks for noticing!