From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E77C433DF for ; Tue, 4 Aug 2020 13:24:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E2DF2067D for ; Tue, 4 Aug 2020 13:24:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HNLlroBU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E2DF2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BFC28D0160; Tue, 4 Aug 2020 09:24:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E408D0081; Tue, 4 Aug 2020 09:24:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 061F88D0160; Tue, 4 Aug 2020 09:24:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id E06E48D0081 for ; Tue, 4 Aug 2020 09:24:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 821EE1EF2 for ; Tue, 4 Aug 2020 13:24:46 +0000 (UTC) X-FDA: 77112956172.15.knot15_5a02ae126fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 29F471814B0C7 for ; Tue, 4 Aug 2020 13:24:46 +0000 (UTC) X-HE-Tag: knot15_5a02ae126fa6 X-Filterd-Recvd-Size: 4326 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 13:24:45 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id j19so22100941pgm.11 for ; Tue, 04 Aug 2020 06:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LL7CVx3M+GnKSSe8eUQMx8d9kBXew/bFtxjaZTrFB4I=; b=HNLlroBUqWnzQ0xGT6GTr/Id4TzheIch2ECQb//1Mh+eL1JbUWj7mgeq13LfdccS98 IS3DGtZa2HgV/RhIJuVePSKzqD3uwjzCS1qPt4Fito6mIqPvXraCYBmdo3L34332gOIm WmfyL0evZGWgvDbKbmphDaCTUSc2DQbsN3FZIG1S/LRGxUsEGkoRmRKe10PFG0piz92M AhSuxdBD/UQqupXICBkPfCSJFZTywgv3NvO04VK0i+G1rFdbd3XmQteUx1vj4/C5GbfW pWOV7qnFTZRWi05TIryxjWTQNA2vc3vyZdMkk8iDFMuFXYFCkua4Y53lmW6gg4sBAf/7 0SyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LL7CVx3M+GnKSSe8eUQMx8d9kBXew/bFtxjaZTrFB4I=; b=oNfiirXJT6WcCESKvFXBUp5uYxQMDIWcB04WuG2nRu5bxYtXZm3uF4nbNeTVuEPUou fnbQPbtBqNdnZtdm7OLP24dsBWNRChKAA9GYlpKRdG4nyqf4Bb2SRIyuP2yi7YQmmioT xSOeh3ds0ZfghokZnlTbwN0RCZCpHJ1VkZPjAR4dEXda5j1qq8X87fc62JOhxwK0HG8g K3+IHP2MRy6AXZopfrHxiTD0Fy172K7YzI8taRK4JNhqIbB0CV9eE5/A0nFbqEu3WeSE XjjwtFXMlICatUoLH/j5iKSfMwotP4YYJMF4xa+ZIhhdsr7Bk3pcz72hcaD4H2cVMJ7J WBqQ== X-Gm-Message-State: AOAM531FXq11UE1fX5jXaYfU9fosidwmzfhSuDJ1kE2OFyK22WT2OIUX jNu9AdyGaNXyL3OaPpsSxwOJQjfKbb1rJ1cvcx7nDw== X-Google-Smtp-Source: ABdhPJx3jQKW6ryn3Y7C/EY3oYgP1FKFpU1S+iDkIFMexVg3zCcBg4JLu/mb7S7DJX/i24rr6RUB20iZPZdJ3KDAP60= X-Received: by 2002:a65:4bc7:: with SMTP id p7mr3313300pgr.440.1596547484618; Tue, 04 Aug 2020 06:24:44 -0700 (PDT) MIME-Version: 1.0 References: <26fb6165a17abcf61222eda5184c030fb6b133d1.1596544734.git.andreyknvl@google.com> <20200804131939.GC31076@gaia> In-Reply-To: <20200804131939.GC31076@gaia> From: Andrey Konovalov Date: Tue, 4 Aug 2020 15:24:33 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] kasan, arm64: don't instrument functions that enable kasan To: Catalin Marinas Cc: Andrew Morton , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Ard Biesheuvel , Arvind Sankar , kasan-dev , Linux Memory Management List , linux-efi , LKML , Walter Wu , Elena Petrova , Vincenzo Frascino Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 29F471814B0C7 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 4, 2020 at 3:19 PM Catalin Marinas wrote: > > On Tue, Aug 04, 2020 at 02:41:26PM +0200, Andrey Konovalov wrote: > > This patch prepares Software Tag-Based KASAN for stack tagging support. > > > > With stack tagging enabled, KASAN tags stack variable in each function > > in its prologue. In start_kernel() stack variables get tagged before KASAN > > is enabled via setup_arch()->kasan_init(). As the result the tags for > > start_kernel()'s stack variables end up in the temporary shadow memory. > > Later when KASAN gets enabled, switched to normal shadow, and starts > > checking tags, this leads to false-positive reports, as proper tags are > > missing in normal shadow. > > > > Disable KASAN instrumentation for start_kernel(). Also disable it for > > arm64's setup_arch() as a precaution (it doesn't have any stack variables > > right now). > > > > Signed-off-by: Andrey Konovalov > > I thought I acked this already. Either way: > > Acked-by: Catalin Marinas Sorry, I forgot to include that into v2. Thanks!