From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C725C433E3 for ; Thu, 27 Aug 2020 12:06:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B4DD1207F7 for ; Thu, 27 Aug 2020 12:06:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BWaKBXCN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4DD1207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5330D8E0017; Thu, 27 Aug 2020 08:06:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E2268E0006; Thu, 27 Aug 2020 08:06:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F7CF8E0017; Thu, 27 Aug 2020 08:06:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 292528E0006 for ; Thu, 27 Aug 2020 08:06:04 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CB89B181AEF1D for ; Thu, 27 Aug 2020 12:06:03 +0000 (UTC) X-FDA: 77196220206.20.sky37_0a0b03e2706c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 12C26180C07AB for ; Thu, 27 Aug 2020 12:05:42 +0000 (UTC) X-HE-Tag: sky37_0a0b03e2706c X-Filterd-Recvd-Size: 4811 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 12:05:41 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id t185so3311712pfd.13 for ; Thu, 27 Aug 2020 05:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rQWdT8WbkjggL+VwPZ1ejJL4JOhIunI/RdMzpXfnZIU=; b=BWaKBXCNmEVXA2JWbxY9DmiZBysI37rmIsvDDCfuwrfdPQHvFGNEvbK9FuNxLP5aJ6 hfKiqRqly/VGxw3TZPGRRv2dA7r8TAnrjSjQaXsjJbL5CzdVQ+D7f17CjTSfiVE59+YE ESTuI0sOn8bYUUjps3RHi13LgWRRQOvplLxYZAmfK1Klh3eFUUnRZkgzEogRtFoOIMoa 5HxY+z4IDMpvteZDqYYSzAk5ZHvkNHWTypJyxye5yEC+/zZqR/DW4ZT0LduguVg0JeRV WD89MaNyvouyNjVN+AF7hnm+K4MVleSuRe9uAkebAYtpIGreRpPYr6oSuSwJPsNU1HL3 ESBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rQWdT8WbkjggL+VwPZ1ejJL4JOhIunI/RdMzpXfnZIU=; b=s4MUrHJqi4Vj2T+EUMB1/5fKyv9o3H8rZe0qZ6gfgTOh4Qt8UCR1EFligpGsTCRTQj 3ptrK+tEv1vTWXKiZWEV7zfUd6ynC3ex73BrB3+HUqj8rTJ4cIVw+L3zpHan9vp5q7Zo 2yxH3e3U66XLEn8MJYvkfiy9EB1K1Wl1ZZ1Qk3Jt9rvCv9ZAFen7knfSHfFPoej52MTs xiM2WJcUGfWT2dNxc26PXcg8mG0syehoKW5H8A0pbjuYIxI0TrG1v1zPrUHh9XnDvZiF IxMzV3kfHk/yIzZrX1FkCn90qlDhcbopA7b8EEpnQkXNqQ7p2ZIysJOwSFXkLo6xTmil 7JGA== X-Gm-Message-State: AOAM531VfQxAwH9Ud2Si+dMP444DOYL17WB2ew6OSRuN6hjRJP9kQOCo qzyAWJtLsfqRtixck0lPReLIzDiCLh0V/WzTG+zX8w== X-Google-Smtp-Source: ABdhPJxBixhsyk7YFbVXwQoa9Dy/RTNiXLkApjohxbkjb0jNodf4ci0xjdKa/q7Wu2qZq4T77yF1RITctr4g9vGoC54= X-Received: by 2002:aa7:8c0f:: with SMTP id c15mr4462254pfd.135.1598529940106; Thu, 27 Aug 2020 05:05:40 -0700 (PDT) MIME-Version: 1.0 References: <07455abaab13824579c1b8e50cc038cf8a0f3369.1597425745.git.andreyknvl@google.com> <20200827104147.GG29264@gaia> In-Reply-To: From: Andrey Konovalov Date: Thu, 27 Aug 2020 14:05:29 +0200 Message-ID: Subject: Re: [PATCH 28/35] kasan: define KASAN_GRANULE_SIZE for HW_TAGS To: Vincenzo Frascino , Catalin Marinas Cc: Dmitry Vyukov , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 12C26180C07AB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 1:05 PM Vincenzo Frascino wrote: > > > > On 8/27/20 11:41 AM, Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:10PM +0200, Andrey Konovalov wrote: > >> Hardware tag-based KASAN has granules of MTE_GRANULE_SIZE. Define > >> KASAN_GRANULE_SIZE to MTE_GRANULE_SIZE for CONFIG_KASAN_HW_TAGS. > >> > >> Signed-off-by: Andrey Konovalov > >> --- > >> mm/kasan/kasan.h | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > >> index 1d3c7c6ce771..4d8e229f8e01 100644 > >> --- a/mm/kasan/kasan.h > >> +++ b/mm/kasan/kasan.h > >> @@ -5,7 +5,13 @@ > >> #include > >> #include > >> > >> +#if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) > >> #define KASAN_GRANULE_SIZE (1UL << KASAN_SHADOW_SCALE_SHIFT) > >> +#else > >> +#include > > > > You could only include the new asm/mte-def.h file (currently mte_asm.h). > > > > Agreed, we should only include asm/mte-def.h here since after the suggested > modification will be sufficient for the purpose. Will do in v2. > > >> +#define KASAN_GRANULE_SIZE (MTE_GRANULE_SIZE) > >> +#endif > >> + > >> #define KASAN_GRANULE_MASK (KASAN_GRANULE_SIZE - 1) > >> > >> #define KASAN_TAG_KERNEL 0xFF /* native kernel pointers tag */ > >> -- > >> 2.28.0.220.ged08abb693-goog > >> > > > > -- > Regards, > Vincenzo