From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E38C433E0 for ; Tue, 19 May 2020 14:52:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 74FF02081A for ; Tue, 19 May 2020 14:52:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jR44H/Yv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74FF02081A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA75C80005; Tue, 19 May 2020 10:52:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E57B0900002; Tue, 19 May 2020 10:52:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D207780005; Tue, 19 May 2020 10:52:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id B6DAA900002 for ; Tue, 19 May 2020 10:52:42 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4CB0A8248068 for ; Tue, 19 May 2020 14:52:42 +0000 (UTC) X-FDA: 76833760164.07.road90_8bf2fc1b5794f X-HE-Tag: road90_8bf2fc1b5794f X-Filterd-Recvd-Size: 11799 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 14:52:41 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id u22so5717700plq.12 for ; Tue, 19 May 2020 07:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XFAQ0HvjxKI2zefHuxO3sefeYajZXVKpLYZBInzWIBk=; b=jR44H/YvQoHsmwONQKuFJhX1yDppYbB1st+qrk4vxX8zeoHzl2z/oqbbQ29KsQqVmv 4vzbovqxEf7lqLb/elMyjKzRfejPK6BUDKiqu7oGAG2QLoqFyR9sOj/yS/1+Vdkn/MPT pLGMcCO0YI6n4G7xTjz5yXhH82JUKph0Vem/rVOgzcLwAGsndiH7NgeXCO9FjRvHpHYp kA1nTtxpGjaQ6L7wshaONkjOMZVPtLPf3MDxghorRt9h3vJ4FlPrsG9k6p07zMm5OiQW QW35eSdiMqPnfZS/ic8hA0+XNfxNqHwsBcIbVPVYKOBOO4DcpTYXEFPHIXPGGsTo3bci J79g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XFAQ0HvjxKI2zefHuxO3sefeYajZXVKpLYZBInzWIBk=; b=LnknE6JPKLXFVuIteA06hH0nXGzlOETzHxuqub30up2aFkBkwjqK6g7NyDX0USqSyM xHBf/l71a5ctqniDYk1DR/tJaxFRas7Vk4X06Wfd+MbX47qcw8Iz7kKHiubnZfeptHua 4PLcM50t2h5ww2FdqAPvK/Qu0xk6qChgAV19vdhbfXOWR9deVxk+NEvGLK7DVbGFSKB4 W0BtMvPrgAPLkOj5xpxeiBfe+Azrs/rVRxnqj4f7K1bcHdeVa0k5g92mOsERZa0iJEEd lZ1ys/zfq3gk6iS4M9A50AjWVmASFUlkH15U3t1cgUUQqaHtyubR5FyX6O06UIf3saHj 4rSg== X-Gm-Message-State: AOAM530j7Iz2hiKLfN/nw83lCkOQLCXpQx57ov2sNnvMJAHjn62fq0uN C6S8/YrWtWjOgJl3I3JB60y9SYBe/vFd8/d/RZj9yg== X-Google-Smtp-Source: ABdhPJxXTQWObd+ZQA8yOUaKd5tIvupweLK6ZyEU2xBuajCQBqs3myx4Z+v+tJJLCmKpYtWib5CtHAfY8do0TzBNrsU= X-Received: by 2002:a17:902:7b89:: with SMTP id w9mr19799522pll.252.1589899960335; Tue, 19 May 2020 07:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20200519022359.24115-1-walter-zh.wu@mediatek.com> In-Reply-To: <20200519022359.24115-1-walter-zh.wu@mediatek.com> From: Andrey Konovalov Date: Tue, 19 May 2020 16:52:28 +0200 Message-ID: Subject: Re: [PATCH v4 1/4] rcu/kasan: record and print call_rcu() call stack To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Matthias Brugger , "Paul E . McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 19, 2020 at 4:24 AM Walter Wu wrote: > > This feature will record the last two call_rcu() call stacks and > prints up to 2 call_rcu() call stacks in KASAN report. > > When call_rcu() is called, we store the call_rcu() call stack into > slub alloc meta-data, so that the KASAN report can print rcu stack. > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > [2]https://groups.google.com/forum/#!searchin/kasan-dev/better$20stack$20traces$20for$20rcu%7Csort:date/kasan-dev/KQsjT_88hDE/7rNUZprRBgAJ > > Signed-off-by: Walter Wu > Suggested-by: Dmitry Vyukov > Cc: Andrey Ryabinin > Cc: Dmitry Vyukov > Cc: Alexander Potapenko > Cc: Andrew Morton > Cc: Paul E. McKenney > Cc: Josh Triplett > Cc: Mathieu Desnoyers > Cc: Lai Jiangshan > Cc: Joel Fernandes > --- > include/linux/kasan.h | 2 ++ > kernel/rcu/tree.c | 2 ++ > lib/Kconfig.kasan | 2 ++ > mm/kasan/common.c | 4 ++-- > mm/kasan/generic.c | 19 +++++++++++++++++++ > mm/kasan/kasan.h | 10 ++++++++++ > mm/kasan/report.c | 24 ++++++++++++++++++++++++ > 7 files changed, 61 insertions(+), 2 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 31314ca7c635..23b7ee00572d 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -174,11 +174,13 @@ static inline size_t kasan_metadata_size(struct kmem_cache *cache) { return 0; } > > void kasan_cache_shrink(struct kmem_cache *cache); > void kasan_cache_shutdown(struct kmem_cache *cache); > +void kasan_record_aux_stack(void *ptr); > > #else /* CONFIG_KASAN_GENERIC */ > > static inline void kasan_cache_shrink(struct kmem_cache *cache) {} > static inline void kasan_cache_shutdown(struct kmem_cache *cache) {} > +static inline void kasan_record_aux_stack(void *ptr) {} > > #endif /* CONFIG_KASAN_GENERIC */ > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 06548e2ebb72..36a4ff7f320b 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -57,6 +57,7 @@ > #include > #include > #include > +#include > #include "../time/tick-internal.h" > > #include "tree.h" > @@ -2668,6 +2669,7 @@ __call_rcu(struct rcu_head *head, rcu_callback_t func) > head->func = func; > head->next = NULL; > local_irq_save(flags); > + kasan_record_aux_stack(head); > rdp = this_cpu_ptr(&rcu_data); > > /* Add the callback to our list. */ > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index 81f5464ea9e1..4e83cf6e3caa 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -58,6 +58,8 @@ config KASAN_GENERIC > For better error detection enable CONFIG_STACKTRACE. > Currently CONFIG_KASAN_GENERIC doesn't work with CONFIG_DEBUG_SLAB > (the resulting kernel does not boot). > + In generic mode KASAN prints the last two call_rcu() call stacks in > + reports. I don't think we need this here, mentioning this in the documentation is fine. > > config KASAN_SW_TAGS > bool "Software tag-based mode" > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 2906358e42f0..8bc618289bb1 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -41,7 +41,7 @@ > #include "kasan.h" > #include "../slab.h" > > -static inline depot_stack_handle_t save_stack(gfp_t flags) > +depot_stack_handle_t kasan_save_stack(gfp_t flags) > { > unsigned long entries[KASAN_STACK_DEPTH]; > unsigned int nr_entries; > @@ -54,7 +54,7 @@ static inline depot_stack_handle_t save_stack(gfp_t flags) > static inline void set_track(struct kasan_track *track, gfp_t flags) > { > track->pid = current->pid; > - track->stack = save_stack(flags); > + track->stack = kasan_save_stack(flags); > } > > void kasan_enable_current(void) > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > index 56ff8885fe2e..3372bdcaf92a 100644 > --- a/mm/kasan/generic.c > +++ b/mm/kasan/generic.c > @@ -325,3 +325,22 @@ DEFINE_ASAN_SET_SHADOW(f2); > DEFINE_ASAN_SET_SHADOW(f3); > DEFINE_ASAN_SET_SHADOW(f5); > DEFINE_ASAN_SET_SHADOW(f8); > + > +void kasan_record_aux_stack(void *addr) > +{ > + struct page *page = kasan_addr_to_page(addr); > + struct kmem_cache *cache; > + struct kasan_alloc_meta *alloc_info; > + void *object; > + > + if (!(page && PageSlab(page))) > + return; > + > + cache = page->slab_cache; > + object = nearest_obj(cache, page, addr); > + alloc_info = get_alloc_info(cache, object); > + > + /* record the last two call_rcu() call stacks */ > + alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; > + alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); > +} > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index e8f37199d885..a7391bc83070 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -104,7 +104,15 @@ struct kasan_track { > > struct kasan_alloc_meta { > struct kasan_track alloc_track; > +#ifdef CONFIG_KASAN_GENERIC > + /* > + * call_rcu() call stack is stored into struct kasan_alloc_meta. > + * The free stack is stored into struct kasan_free_meta. > + */ > + depot_stack_handle_t aux_stack[2]; > +#else > struct kasan_track free_track[KASAN_NR_FREE_STACKS]; > +#endif > #ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > u8 free_pointer_tag[KASAN_NR_FREE_STACKS]; > u8 free_track_idx; > @@ -159,6 +167,8 @@ void kasan_report_invalid_free(void *object, unsigned long ip); > > struct page *kasan_addr_to_page(const void *addr); > > +depot_stack_handle_t kasan_save_stack(gfp_t flags); > + > #if defined(CONFIG_KASAN_GENERIC) && \ > (defined(CONFIG_SLAB) || defined(CONFIG_SLUB)) > void quarantine_put(struct kasan_free_meta *info, struct kmem_cache *cache); > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 80f23c9da6b0..6f8f2bf8f53b 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -179,6 +179,17 @@ static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > return &alloc_meta->free_track[i]; > } > > +#ifdef CONFIG_KASAN_GENERIC > +static void print_stack(depot_stack_handle_t stack) Let's put this function just before print_track() and reuse there. > +{ > + unsigned long *entries; > + unsigned int nr_entries; > + > + nr_entries = stack_depot_fetch(stack, &entries); > + stack_trace_print(entries, nr_entries, 0); > +} > +#endif > + > static void describe_object(struct kmem_cache *cache, void *object, > const void *addr, u8 tag) > { > @@ -192,6 +203,19 @@ static void describe_object(struct kmem_cache *cache, void *object, > free_track = kasan_get_free_track(cache, object, tag); > print_track(free_track, "Freed"); > pr_err("\n"); > + > +#ifdef CONFIG_KASAN_GENERIC > + if (alloc_info->aux_stack[0]) { > + pr_err("Last one call_rcu() call stack:\n"); Could you change this to "Last call_rcu():\n", > + print_stack(alloc_info->aux_stack[0]); > + pr_err("\n"); > + } > + if (alloc_info->aux_stack[1]) { > + pr_err("Second to last call_rcu() call stack:\n"); and this to "Second to last call_rcu():\n"? It's shorter, but provides the same info. > + print_stack(alloc_info->aux_stack[1]); > + pr_err("\n"); > + } > +#endif > } > > describe_object_addr(cache, object, addr); > -- > 2.18.0 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20200519022359.24115-1-walter-zh.wu%40mediatek.com.