From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5395C00A89 for ; Fri, 30 Oct 2020 19:30:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D853206E3 for ; Fri, 30 Oct 2020 19:30:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kbvQq2bu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D853206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B70FC6B005D; Fri, 30 Oct 2020 15:30:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF9406B0062; Fri, 30 Oct 2020 15:30:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99B0F6B006C; Fri, 30 Oct 2020 15:30:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 629616B005D for ; Fri, 30 Oct 2020 15:30:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0675D181AEF15 for ; Fri, 30 Oct 2020 19:30:47 +0000 (UTC) X-FDA: 77429584134.18.turn18_0f13c4f27298 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id E593B100EC664 for ; Fri, 30 Oct 2020 19:30:46 +0000 (UTC) X-HE-Tag: turn18_0f13c4f27298 X-Filterd-Recvd-Size: 5847 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 30 Oct 2020 19:30:46 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id j5so3445566plk.7 for ; Fri, 30 Oct 2020 12:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Ew5qTvePmElYR26zs05QLzhONyFgn22aBK2jtdC+Ac=; b=kbvQq2bu4lw8s6ZlFZdrp42b5iCLDnYqyjw8qJA/JQyJJ521njP+/8Ls8NTNsroKjQ PMqbL/6EhyzxsIpMlm9DJmY27VxQ52ZsWNzkWfyCGbfetLkX8RsA6E7nk6IBEiN5gVkY 6fqcTzlieo0MeLs1XsFSYzJIse4kCCkfItMBiEyT+KPXl+ZrtuSS3S9FbrJv6wrOM+pL L5aqICtTTWjrDc/gCkcnfGGqNAV7IynuGOE1EFpc2Mxn91OPc+KwDN9WuiHKnm8rgnF/ NUWExEa5sFsa8CxN/nddSCRVjXXzbnN8LCVBjqknbWNRTxLLronXVDJ/xOfkOYXEMmbS tlDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Ew5qTvePmElYR26zs05QLzhONyFgn22aBK2jtdC+Ac=; b=tdPh9OSsvdxJY61QY5Pl91IdRS64VZLkWzlK669vxeFRySiEV0EPqYA6smn2rGs9P9 9y6Xmq1njqE/tLRm+zKpSdVSUGV7ZVIdZTIhs3pMUWAB8OxxaZr3LdTOqede/hDu6g2D Ugkp+I+kU39vtUn3O12B40F/FoeOlb6WD6yGH/W0IP0d9gAxqfBr+qP6y3lknj8ViXUi XR1tDaSafwmdnW6rbgwjgGzlsjxtghQ8khN83ZJhZ8WnQ+H+iKh7FQK7Tls39JmvxIHm /WN1A4xdFGhAbssExulC4+QH4sEErdVn6IqpPP6rp+HBX5g/pgkDAnqzbDbq4K1j2wZ9 1+Iw== X-Gm-Message-State: AOAM533vPo155iz10wTXQu3pkd6htBBLJUnq6taY5foZyjcHlnfU6xmI YiVvsiKFuawUwpehfsWB7NvdH70MKNxIjou+vXYHIQ== X-Google-Smtp-Source: ABdhPJw+AJ9vY9gCO1eZzAXCPNNcS/g4EjgQgOXwojCYqyfhGmkG0nG75HKuZqLSl01Dywu1dkdnz3mEThwKk/no5Jg= X-Received: by 2002:a17:902:9681:b029:d5:cdbd:c38c with SMTP id n1-20020a1709029681b02900d5cdbdc38cmr9755114plp.85.1604086245375; Fri, 30 Oct 2020 12:30:45 -0700 (PDT) MIME-Version: 1.0 References: <6a4a7626bf280871518656f4fa89cb064740baf7.1603372719.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 30 Oct 2020 20:30:34 +0100 Message-ID: Subject: Re: [PATCH RFC v2 14/21] kasan: add and integrate kasan boot parameters To: Marco Elver Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 30, 2020 at 3:45 PM Marco Elver wrote: > > On Thu, 22 Oct 2020 at 15:19, Andrey Konovalov wrote: > > > > TODO: no meaningful description here yet, please see the cover letter > > for this RFC series. > > > > Signed-off-by: Andrey Konovalov > > Link: https://linux-review.googlesource.com/id/If7d37003875b2ed3e0935702c8015c223d6416a4 > > --- > > mm/kasan/common.c | 92 +++++++++++++----------- > > mm/kasan/generic.c | 5 ++ > > mm/kasan/hw_tags.c | 169 ++++++++++++++++++++++++++++++++++++++++++++- > > mm/kasan/kasan.h | 9 +++ > > mm/kasan/report.c | 14 +++- > > mm/kasan/sw_tags.c | 5 ++ > > 6 files changed, 250 insertions(+), 44 deletions(-) > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > index 1a5e6c279a72..cc129ef62ab1 100644 > > --- a/mm/kasan/common.c > > +++ b/mm/kasan/common.c > > @@ -129,35 +129,37 @@ void kasan_cache_create(struct kmem_cache *cache, unsigned int *size, > > unsigned int redzone_size; > > int redzone_adjust; > > > > - /* Add alloc meta. */ > > - cache->kasan_info.alloc_meta_offset = *size; > > - *size += sizeof(struct kasan_alloc_meta); > > - > > - /* Add free meta. */ > > - if (IS_ENABLED(CONFIG_KASAN_GENERIC) && > > - (cache->flags & SLAB_TYPESAFE_BY_RCU || cache->ctor || > > - cache->object_size < sizeof(struct kasan_free_meta))) { > > - cache->kasan_info.free_meta_offset = *size; > > - *size += sizeof(struct kasan_free_meta); > > - } > > - > > - redzone_size = optimal_redzone(cache->object_size); > > - redzone_adjust = redzone_size - (*size - cache->object_size); > > - if (redzone_adjust > 0) > > - *size += redzone_adjust; > > - > > - *size = min_t(unsigned int, KMALLOC_MAX_SIZE, > > - max(*size, cache->object_size + redzone_size)); > > + if (static_branch_unlikely(&kasan_stack)) { > > I just looked at this file in your Github repo, and noticed that this > could just be > > if (!static_branch_unlikely(&kasan_stack)) > return; > > since the if-block ends at the function. That might hopefully make the > diff a bit smaller. Will do, thanks!