From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03563C4742C for ; Wed, 4 Nov 2020 19:26:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75A48221E2 for ; Wed, 4 Nov 2020 19:26:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QaU/Brb9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75A48221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E1AE26B0085; Wed, 4 Nov 2020 14:26:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA2896B0087; Wed, 4 Nov 2020 14:26:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA7156B0088; Wed, 4 Nov 2020 14:26:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 7CC336B0085 for ; Wed, 4 Nov 2020 14:26:33 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 299093623 for ; Wed, 4 Nov 2020 19:26:33 +0000 (UTC) X-FDA: 77447717466.09.beds11_3c12126272c3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 0FA23180AD804 for ; Wed, 4 Nov 2020 19:26:33 +0000 (UTC) X-HE-Tag: beds11_3c12126272c3 X-Filterd-Recvd-Size: 4551 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Nov 2020 19:26:32 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id 1so10769738ple.2 for ; Wed, 04 Nov 2020 11:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FEU9I/sSHhuQeVi3XIRAFCC61r4m2vgIPksqGF6T7cY=; b=QaU/Brb9ubKtJ+UmXAU+wMvbSYfqqAwfeWlEQpFpEGxDAi3owrUgZX2ocw3QDH9kH2 jDolQ4IYya9FfscNGC0/4+k96h96nMLHyORIqhIrioyvbfSYsdxRHaS0Dnw/kLm8yXrD GJRFi34wPeF+0LZLh1tecoO+K5twq4ckJR2RzYcjcpQy+kmXeoB7c96JH1WUo5L3IZ3Q KZdQzHhJua+9q9Dil5XGqsIsPS04hgWhvsS2dKINrRF9VUPal8OZWIZe+y43jBQPYVO/ /0dG4KW+S+a6zzw+iqgXqX6LOCFnI8vybqW0JmPi0lfNNbr4ovfcnc3AQo5z77s6Td5v F62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FEU9I/sSHhuQeVi3XIRAFCC61r4m2vgIPksqGF6T7cY=; b=STwA0CjkyoBd12Be/Y1KTwrNeOn9gO3+QpLRmctS31zP51vR32dhhbcQcRs7mJaI2l y1y7BCum/o53lrmeWzmoVTLQE+T5UMM2rXVVZihKkJN4QRx8ah57iCc08rTY5FFINBk4 SHIx1CMjfwr38fnEj/q26l38qqF2NQuJxGVA61j6Y/w03BjCbliZFQC9bC3C9RMZXguM v3vxot98Oh0rqKHqxzL3HmIPjGDfEU3jpzoHtcmBIMsfpLsYA5g1/Fh8pd8xQ4LTqDAh +MrYsONFS3z79sm66lcDnRNNraPy+pWM10gLxm8O7CByYNRdPMBXdu4IL6Z2Evg/waE+ sWXQ== X-Gm-Message-State: AOAM533bG1yet06e9sBCj71qPigobgrTPz1Mq56Fa7qVY9c0g1jvJNEV ATlZ5cpH5R8Sqxnx95s2LfHLbXKsy4Ioqzi0PzNXcQ== X-Google-Smtp-Source: ABdhPJzkwewt6K1zE1uoNPrHkLphDrGmDjvihFe/mxpdVUR6Hgh3MwMetX3VEeZNuz7nDWoUs2X0nyJvEZA/xLRZEDQ= X-Received: by 2002:a17:902:d90d:b029:d6:ecf9:c1dd with SMTP id c13-20020a170902d90db02900d6ecf9c1ddmr3858971plz.13.1604517991448; Wed, 04 Nov 2020 11:26:31 -0800 (PST) MIME-Version: 1.0 References: <5e7c366e68844a0fe8e18371c5a76aef53905fae.1604333009.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 4 Nov 2020 20:26:20 +0100 Message-ID: Subject: Re: [PATCH v7 13/41] s390/kasan: include asm/page.h from asm/kasan.h To: Vasily Gorbik Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , kasan-dev , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 4, 2020 at 8:25 PM Vasily Gorbik wrote: > > On Mon, Nov 02, 2020 at 05:03:53PM +0100, Andrey Konovalov wrote: > > asm/kasan.h relies on pgd_t type that is defined in asm/page.h. Include > > asm/page.h from asm/kasan.h. > > > > Signed-off-by: Andrey Konovalov > > --- > > Change-Id: I369a8f9beb442b9d05733892232345c3f4120e0a > > --- > > arch/s390/include/asm/kasan.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/s390/include/asm/kasan.h b/arch/s390/include/asm/kasan.h > > index e9bf486de136..a0ea4158858b 100644 > > --- a/arch/s390/include/asm/kasan.h > > +++ b/arch/s390/include/asm/kasan.h > > @@ -2,6 +2,8 @@ > > #ifndef __ASM_KASAN_H > > #define __ASM_KASAN_H > > > > +#include > > Could you please include > #include > > instead? This file is also using _REGION1_SHIFT which is defined there. > And I have some s390 kasan changes pending, which include > asm/pgtable.h as well, so this would make merging simpler. Thank you. > > With that changed > Acked-by: Vasily Gorbik No problem, thank you!