From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C5CC433DB for ; Fri, 15 Jan 2021 12:48:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2997B208BA for ; Fri, 15 Jan 2021 12:48:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2997B208BA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB3AC8D0160; Fri, 15 Jan 2021 07:48:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A93B78D015B; Fri, 15 Jan 2021 07:48:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6EA8D0160; Fri, 15 Jan 2021 07:48:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 86A3B8D015B for ; Fri, 15 Jan 2021 07:48:54 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 57295181AC9BF for ; Fri, 15 Jan 2021 12:48:54 +0000 (UTC) X-FDA: 77707988988.01.pan20_200037e2752f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 6BBA41004D455 for ; Fri, 15 Jan 2021 12:48:51 +0000 (UTC) X-HE-Tag: pan20_200037e2752f X-Filterd-Recvd-Size: 5026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 12:48:50 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id e9so489730plh.3 for ; Fri, 15 Jan 2021 04:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IwEZ0vJjMhibVYpx1I3U5rxwVwXQCQH8qptIRt+vn6E=; b=Nf+g+CufTKuWQeJMV9uHdSlZksBUQk17DZIgfQCyiWAqye1BgqcFBpCzSjIXheeO0h cSp343LeRF+qD7fG5DZ6x4DOUcSJ8p/QXc9yl16Qy26PXHZa+Dd3UJHqIkXXJeutXsdP 50g7slIbR+WAKAPoyAHAYZkNEHB42kapJINggrprDYbe1f/dnNPXsV1IYoOSbopM4N9m mjaRSuiawq0qxVFMPn4KYG/LAEtOwXIh1b9uBLPJ4zujCvyDvnFNF5ltQFGusVXO5FIb oUpR6ggYs7WWdp978cZgRrK5Hw/W/iAUxp7QfmtlHCdeDKDo47nQVYgr2EaM4Zz+LS2M lsUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IwEZ0vJjMhibVYpx1I3U5rxwVwXQCQH8qptIRt+vn6E=; b=iJKg+43NPk9KaM54HpE7QPys0NJzxlf8itGRM4lpZEu9c5AwWv4N1mfhX9aa0UfOcV AAmj0g4GX/fMvkW5FN74z98Bk4BxYapLRyl9aRq0yI+5NBX8r66m7YM2MJOSwVvDmCtM GhtJHKhtTv3+X00ZH8SyCg3jHxuv3pZO3lj1N8+gyPCG5TlraxdcdmoJk+s9+Sn+WbFJ nXZy+c9wOY5tMM51CzmMsMiTnEiXdyDOxv9jXzowvbrAAmbvYYxHbNvPa7srJBGzhJeu T0uHHBgCmdJiFTCcmx6iNH3iZmCjWWgqPTaUVVIJXmAwuKVzqNHWdo1X7Ptt2XkBoBIY bfpg== X-Gm-Message-State: AOAM531fG7nFgrfYgotTfnM2xukWilxgvQ6KBuETVIdzfy+8GLuu7BSl WP6J9yOgg/ojTtS8OLSdw5uRqSmOOoWl+njJcIzNOg== X-Google-Smtp-Source: ABdhPJxHhwtCYNkaIcLQzrs1mT8U40yWsSHAGn1Ly0f4oZqippoLTkuqzC11rJfiFXZYQ9/Ni2wegco99FQ/U0bJ4Ew= X-Received: by 2002:a17:902:ff06:b029:de:362c:bd0b with SMTP id f6-20020a170902ff06b02900de362cbd0bmr11764451plj.13.1610714929783; Fri, 15 Jan 2021 04:48:49 -0800 (PST) MIME-Version: 1.0 References: <3d9e6dece676e9da49d9913c78fd647db7dad552.1610652791.git.andreyknvl@google.com> <20210115104945.GB16707@gaia> In-Reply-To: <20210115104945.GB16707@gaia> From: Andrey Konovalov Date: Fri, 15 Jan 2021 13:48:38 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] kasan, arm64: fix pointer tags in KASAN reports To: Catalin Marinas Cc: Andrew Morton , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 15, 2021 at 11:49 AM Catalin Marinas wrote: > > On Thu, Jan 14, 2021 at 08:33:57PM +0100, Andrey Konovalov wrote: > > As of the "arm64: expose FAR_EL1 tag bits in siginfo" patch, the address > > that is passed to report_tag_fault has pointer tags in the format of 0x0X, > > while KASAN uses 0xFX format (note the difference in the top 4 bits). > > > > Fix up the pointer tag before calling kasan_report. > > > > Link: https://linux-review.googlesource.com/id/I9ced973866036d8679e8f4ae325de547eb969649 > > Fixes: dceec3ff7807 ("arm64: expose FAR_EL1 tag bits in siginfo") > > Fixes: 4291e9ee6189 ("kasan, arm64: print report from tag fault handler") > > Signed-off-by: Andrey Konovalov > > --- > > arch/arm64/mm/fault.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > > index 3c40da479899..a218f6f2fdc8 100644 > > --- a/arch/arm64/mm/fault.c > > +++ b/arch/arm64/mm/fault.c > > @@ -304,6 +304,8 @@ static void report_tag_fault(unsigned long addr, unsigned int esr, > > { > > bool is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; > > > > + /* The format of KASAN tags is 0xF. */ > > + addr |= (0xF0UL << MTE_TAG_SHIFT); > > /* > > * SAS bits aren't set for all faults reported in EL1, so we can't > > * find out access size. > > I already replied here but I don't see any change in v2: > > https://lore.kernel.org/linux-arm-kernel/20210113165441.GC27045@gaia/ Hi Catalin, Sorry, Gmail decided to mark all your emails as spam for some reason, so I didn't see any of them :( I'll fix this in v3. Thanks!