From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E13C43464 for ; Fri, 18 Sep 2020 14:56:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FB1221973 for ; Fri, 18 Sep 2020 14:56:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="W3Tpv9wP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FB1221973 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2908A6B005C; Fri, 18 Sep 2020 10:56:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 267738E0001; Fri, 18 Sep 2020 10:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 156B36B0062; Fri, 18 Sep 2020 10:56:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id F38386B005C for ; Fri, 18 Sep 2020 10:56:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A54B03621 for ; Fri, 18 Sep 2020 14:56:40 +0000 (UTC) X-FDA: 77276483760.17.tooth98_600b9b42712c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id B7FDC180D0198 for ; Fri, 18 Sep 2020 14:56:37 +0000 (UTC) X-HE-Tag: tooth98_600b9b42712c X-Filterd-Recvd-Size: 4672 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 14:56:37 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id fa1so3314017pjb.0 for ; Fri, 18 Sep 2020 07:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=84mJPr8Gpr4/Tq1Lxh29BXusyQ2UCdZanSBlBtKi1cQ=; b=W3Tpv9wPrKPr2FuI5kSboSbfFrAviXfAq10rKNlEr5QMi7YEK6zpgtYA0SDH6noIVk 1TimskWwsw43RSLr7GlMZ7jsyWqLvpBx/5PekZYCvG5GQbvR2tjeek0TRTvBgVxFg6TI dvPUB5zrCNI0QS81Swllg3ZPa8mF+ztZx+G5Yykp8s18Ce0b+A4OsBbia67sPM6JvugV aPX+MldJLA2uOSBmYHFS2JhEiOQDTT0o8SEknH2I48gQUAdoJIrPraArbNFwKwmASD8J ugL70jCKfOqX8Dm4Cj2mp8h9sWTUV0s9TTQSVImQ0uqYgCnZlzO5kbyhZRtNIV3kPjrp O/vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=84mJPr8Gpr4/Tq1Lxh29BXusyQ2UCdZanSBlBtKi1cQ=; b=aeMzdglUTN/nDXOfi+6FJSpIbgZLbwRYonZel65g3Eh1TTJqn7TC64QbbH8Nc2R5x5 R4GctxV0iYrZMUrv7U3WE4okUdfvPNzdQzPxgUUzLCSeGTqUwZSmPXh1SgDjtKbTI/G9 rQmHDtde6ttda8Wt+qYzgaUaPJ7j/jS+FGXdM5odplnnTdsog6qVEhRaF0BADm5iwDVY A2m4QhDWLWyFLs6tb/6n1yurF3GiYV/0vd6uaVR4BaEWH1BEGdVYwyAjOO+wiJoHHRq6 c/UYS0Zsy0uY5Ks4SypB9h2QxKZouzV9eEfsoL7jCWXAQHvYcA2bTADYUXzTTkCN2nEa Q2DQ== X-Gm-Message-State: AOAM5333MAhCIvXgbp5yTwLwwLuftyWb1MmHYib/O6Dm/UsQqvNdHx6G PWeGdkok7AbaOM3qnvhJIGZ42NsLCqtuC/oIGbtkFg== X-Google-Smtp-Source: ABdhPJy4gRGHqzM1DVK6jgclHTM6k7zcc+JlhOQZI8hqLajfveJ0hHLmlzeGrvovDPdwwOPiC8qlJIeDpJffpp94I+g= X-Received: by 2002:a17:90a:81:: with SMTP id a1mr13066299pja.136.1600440996199; Fri, 18 Sep 2020 07:56:36 -0700 (PDT) MIME-Version: 1.0 References: <272b331db9919432cd6467a0bd5ce73ffc46fc97.1597425745.git.andreyknvl@google.com> <20200918145541.GA2458536@elver.google.com> In-Reply-To: <20200918145541.GA2458536@elver.google.com> From: Andrey Konovalov Date: Fri, 18 Sep 2020 16:56:25 +0200 Message-ID: Subject: Re: [PATCH 03/35] kasan: shadow declarations only for software modes To: Marco Elver Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 4:55 PM Marco Elver wrote: > > On Fri, Aug 14, 2020 at 07:26PM +0200, Andrey Konovalov wrote: > > This is a preparatory commit for the upcoming addition of a new hardware > > tag-based (MTE-based) KASAN mode. > > > > Group shadow-related KASAN function declarations and only define them > > for the two existing software modes. > > > > No functional changes for software modes. > > > > Signed-off-by: Andrey Konovalov > > --- > > include/linux/kasan.h | 44 ++++++++++++++++++++++++++----------------- > > 1 file changed, 27 insertions(+), 17 deletions(-) > > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > index bd5b4965a269..44a9aae44138 100644 > > --- a/include/linux/kasan.h > > +++ b/include/linux/kasan.h > [...] > > +static inline int kasan_add_zero_shadow(void *start, unsigned long size) > > +{ > > + return 0; > > +} > > +static inline void kasan_remove_zero_shadow(void *start, > > + unsigned long size) > > +{} > > Readability suggestion (latest checkpatch.pl allows up to 100 cols): > > -static inline void kasan_remove_zero_shadow(void *start, > - unsigned long size) > -{} > +static inline void kasan_remove_zero_shadow(void *start, unsigned long size) {} Will do in v3, thanks!