From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBC7ECAAA1 for ; Mon, 31 Oct 2022 16:34:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE1D26B007E; Mon, 31 Oct 2022 12:34:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6A7C6B0080; Mon, 31 Oct 2022 12:34:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E43A6B0081; Mon, 31 Oct 2022 12:34:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 801E46B007E for ; Mon, 31 Oct 2022 12:34:15 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5A2D2405B8 for ; Mon, 31 Oct 2022 16:34:15 +0000 (UTC) X-FDA: 80081792070.05.1296106 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf27.hostedemail.com (Postfix) with ESMTP id CFF5A40028 for ; Mon, 31 Oct 2022 16:34:14 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id o12so20066017lfq.9 for ; Mon, 31 Oct 2022 09:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WuUkP45RzlUJMMDmT0axeeuMqG2jWs1gF2XKSWMSsoc=; b=SAMTViSV7EiGrPMEdUePOO7yk3by937/qt76oi0BU1uXz5fBWs8yxw/1HEavwbpqlW cSBNZwLWG76VRiruSLQgD181ABYCh0/VDVJ2IJ1JIa+y2tWYd4+9HvVadhMSkx8OZ/Qy OvKh63BnhHwCkSseiHc/KK4McNjWM0Y2S68wsJnuTlCQUxPyYf3SbkUWjGqMSKBM0X7M mDbfEH+xSw3GaR16PQhW9NbusAN/179Zdwqp+NyA10Ibrko9gfTIHVdRaJd4Wz9npaa4 qbxAnYFusQqYYFBKy/1bH1J0KiJ/78qPV3YogY/CWNmfGt3ZYOgmhSK1wQcXNtZqlbjA I+CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WuUkP45RzlUJMMDmT0axeeuMqG2jWs1gF2XKSWMSsoc=; b=GSv/VUMr1r1pJmEI1bCpbIcczk6vNbh3r16blt6Sww67K9BqeJbirrOKasDF53NjQT qPc+YCSgWTo74cDA60Hp4W+mbaB7JEc8it5Z8nfsXlwVYwZCuZe/jOwSi3Kzuo9Btn0K 8KUeBY+GhAwbJtZDweleEhrDwUzqEHw8jKLCEn9l6jwQuy2MPukEnYYTzs/j0Cpbxx9Y YNbyvHkyd06jvXXpFaH/084DOoX8I91Z4gkHET/iE3J2jJR9XTsWTFL3CGfWd5KhrCpT Bp/CeMpyDq97mgBtOcf5ytCfqsItfPtzBVppOEjxYSj0qvL8N+pe/qiVGSPt3K6K6EU3 gQOw== X-Gm-Message-State: ACrzQf1wzTlbcZrdSHu+jVp1pXdLhkfay7hPrjqqg1F7/iMdGNNg/rAq khYnVDRadh+DFjiq9GzaSc+TAyyt5/T36/zy+L4c2A== X-Google-Smtp-Source: AMsMyM6IbEpj4S7zheWIkOiAI7Z3aMzs2dfYqSF45HWOtEdjt8FMu87rX/oW7AqlJSS6rfgw8Pyi+AP1cef+Q0VAy5I= X-Received: by 2002:a05:6512:ac7:b0:4a2:6b9b:3254 with SMTP id n7-20020a0565120ac700b004a26b9b3254mr5921719lfu.234.1667234053303; Mon, 31 Oct 2022 09:34:13 -0700 (PDT) MIME-Version: 1.0 References: <20221021223300.3675201-1-zokeefe@google.com> <20221021223300.3675201-3-zokeefe@google.com> <2f67d133-8996-ef10-4a36-42537906ebba@gmail.com> In-Reply-To: <2f67d133-8996-ef10-4a36-42537906ebba@gmail.com> From: "Zach O'Keefe" Date: Mon, 31 Oct 2022 09:33:37 -0700 Message-ID: Subject: Re: [PATCH man-pages v3 2/4] madvise.2: document reliable probe for advice support To: Alejandro Colomar Cc: Yang Shi , linux-mm@kvack.org, linux-man@vger.kernel.org, Michael Kerrisk Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667234054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WuUkP45RzlUJMMDmT0axeeuMqG2jWs1gF2XKSWMSsoc=; b=pWLzpsGtojqnRVVxrXLd255XzX4wbL/+WBsoS6V51nLJmr9ZwX78v3v/A6tcbHZrbX958h f9pAPFYI4FAtjn9zuonlbyCL5CL69b5UuLimVj3g6ph7Wf7Ywubiwk2ki88ZW9ntEtofuo s8QZS+4yBFV1sZb3P1fwKnIvqaTJ/Kk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SAMTViSV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667234055; a=rsa-sha256; cv=none; b=ztSc/v9NqdSTBJQoHwKWKays9yT3Ya+HYfLm1IN4L26OqYb9eqBab7dbGy3eMMsnviMJXK mS4Qh8uWZ6QXvk050So1lFOas71MUy4HcDW4xLSL7aYQ+UzeQaLxGlDPA1C48zbc9+Fq23 jn26GmzvKTh+k9qCA/OG/nY9alY0ATE= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CFF5A40028 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SAMTViSV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Stat-Signature: bi5pstdti6pg7n56d13bq1osz4w5ri97 X-Rspam-User: X-HE-Tag: 1667234054-739077 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 30, 2022 at 4:44 AM Alejandro Colomar wrote: > > Hi Zach, > > On 10/22/22 00:32, Zach OKeefe wrote: > > From: Zach O'Keefe > > > > EINVAL is an overloaded error code for madvise(2) and it's not clear > > under what context it means "advice is not valid" vs another error. > > > > Explicitly document that madvise(0, 0, advice) can reliably be used to > > probe for kernel support for "advice", returning zero iff "advice" is > > supported by the kernel. > > > > Signed-off-by: Zach O'Keefe > > Patch applied. Thank you! Best, Zach > Thanks, > > Alex > > > --- > > man2/madvise.2 | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/man2/madvise.2 b/man2/madvise.2 > > index 64f788ace..df3413cc8 100644 > > --- a/man2/madvise.2 > > +++ b/man2/madvise.2 > > @@ -790,6 +790,11 @@ that are not mapped, the Linux version of > > ignores them and applies the call to the rest (but returns > > .B ENOMEM > > from the system call, as it should). > > +.PP > > +.IR madvise(0,\ 0,\ advice) > > +will return zero iff > > +.I advice > > +is supported by the kernel and can be relied on to probe for support. > > .\" .SH HISTORY > > .\" The > > .\" .BR madvise () > > -- >