From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C640C433EF for ; Wed, 18 May 2022 20:12:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85DED6B0072; Wed, 18 May 2022 16:12:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E5A26B0073; Wed, 18 May 2022 16:12:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65F7F6B0074; Wed, 18 May 2022 16:12:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 51AFA6B0072 for ; Wed, 18 May 2022 16:12:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2B06F20798 for ; Wed, 18 May 2022 20:12:23 +0000 (UTC) X-FDA: 79479960966.28.D2B5F61 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf10.hostedemail.com (Postfix) with ESMTP id 70C6DC00AC for ; Wed, 18 May 2022 20:11:52 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id u30so5519825lfm.9 for ; Wed, 18 May 2022 13:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3fOJykfm+YO8YS5eDz0OAgdLWxIC62MtruDo7GDonyk=; b=R3Q7M3w9u67rpWyGFEK+NQCExCGz/Heili45REOEiupIK9yfDNnBS4NKKREWx/eHMV y6sq+N/QcEsx1x7ynTZQlUsW9OyVfnxjXkiKH3Oa61/3ICRzVKY7EsP9YD/+lvWbAZhv yh5pX0RzcBu6CuLpdVGCJk+oUiB6nwhIiR1TRInYUG0iMU/lPEZnrmpAgrrQL1Wpwobm EYSkDa0JuLG4JnTdA2jBUQi5qfg0zMqv52GQ+oFXeqJKnQuRg8G9/plOBXaK6rMvyL1n 2xx/pZzwGHTUB5Tb8kPIgeDzWGViUGfa4xQwTZxaVU0TovqnWY5VOi39zmwIgag/YXN/ Fz3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3fOJykfm+YO8YS5eDz0OAgdLWxIC62MtruDo7GDonyk=; b=7rH/Mr89VFIIelDROdC/UunpNzCV4WhK0T3X8sTYqGxaTC2L0BqU9qwWQ/4x1eWqv1 0ZD7YUlOWjemqsjPeUS+d4+vLHD0WBTpuimMPJ226RO29KNCs74+lCBFJ/IySdhrrj87 XB6cDUkVX0F3COaoRpPCNgm5d0SFJH4XUxSWi3tqA3OAadC9GXBco7zH3+BmejOpaDeG XraQ01XsgtS3f8qfScNh3Hf2HUo0GF6uhrstQsFjtA7FNJM4Cf8MO7LQ+Fd2CayQGjhG 3IJK2QHpXu75brxnCTnLGr4LzS63VNTJ+gKOrc595EwUYDrNBHmDY9VLQB4XkIPrnz5o ElqQ== X-Gm-Message-State: AOAM530uVmf369Hpk8JqBFEK9WX8iTdIKwIg7srS48VPzgNsuN4GQ4L+ E2AtQ85iD/fd/1MdpF92Mv/TU4aev9qHm2AzOmTsNw== X-Google-Smtp-Source: ABdhPJyfnD1Ps8CNyp/GbdAETh3ewioOC2EcX5a+Ycgcw9r060JTMXw6+qla/WPAZjILeu0tRcQmJyG1NOvFvtuYF5M= X-Received: by 2002:a05:6512:2813:b0:473:a51f:4c48 with SMTP id cf19-20020a056512281300b00473a51f4c48mr814240lfb.198.1652904740730; Wed, 18 May 2022 13:12:20 -0700 (PDT) MIME-Version: 1.0 References: <20220504214437.2850685-1-zokeefe@google.com> <20220504214437.2850685-3-zokeefe@google.com> In-Reply-To: From: "Zach O'Keefe" Date: Wed, 18 May 2022 13:11:44 -0700 Message-ID: Subject: Re: [PATCH v5 02/13] mm/khugepaged: add struct collapse_control To: Peter Xu Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=R3Q7M3w9; spf=pass (imf10.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 70C6DC00AC X-Stat-Signature: x55ntbfgupeof75dq5wnkq4hqp4noj6p X-HE-Tag: 1652904712-90310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 18, 2022 at 1:03 PM Peter Xu wrote: > > On Wed, May 04, 2022 at 02:44:26PM -0700, Zach O'Keefe wrote: > > Modularize hugepage collapse by introducing struct collapse_control. > > This structure serves to describe the properties of the requested > > collapse, as well as serve as a local scratch pad to use during the > > collapse itself. > > > > Start by moving global per-node khugepaged statistics into this > > new structure, and stack allocate one for khugepaged collapse > > context. > > > > Signed-off-by: Zach O'Keefe > > Reviewed-by: Peter Xu > > There's already some UMA changes that seems to be not needed if you're > going with Yang's UMA patch as pre-requisite. And I also see that there's > some other changes to settle and rebase (e.g. -mm temporarily removed the > khugepaged patch to move the thread around in next patch), so I figured > maybe I'll just stop here and read you next version. > Yep that makes sense to me - I should be getting v6 out today/tomorrow. Thanks for taking the time! Best, Zach > Thanks, > > -- > Peter Xu >