From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13CFC00140 for ; Mon, 15 Aug 2022 17:09:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10C306B0073; Mon, 15 Aug 2022 13:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BC3A8D0001; Mon, 15 Aug 2022 13:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC60A6B0078; Mon, 15 Aug 2022 13:09:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DFA006B0073 for ; Mon, 15 Aug 2022 13:09:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B2ED81A0616 for ; Mon, 15 Aug 2022 17:09:53 +0000 (UTC) X-FDA: 79802464266.30.C1B2E07 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by imf21.hostedemail.com (Postfix) with ESMTP id 4DD8B1C00A6 for ; Mon, 15 Aug 2022 17:09:53 +0000 (UTC) Received: by mail-oi1-f177.google.com with SMTP id w196so9179981oiw.10 for ; Mon, 15 Aug 2022 10:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=iBe+k353gk5LIG8240LyHPzNr+hWnG7V+MJ23eeCXtY=; b=NWeuUYPyxQFIllRC0bXgPmr7BxnpD6MObo6CFYYjuJ6GPdHL3cDsz7Jt858NUV0ITT +cTSHc4ZjZz4Jc1xhkWcaA/ea1YSC2SA2a7/ULwK6YxHChx2SD7DMEn4FN/HzGCZP8Kd xPiowIKYBDOXd+jSIFou6wk91B1u7fYSFpgKOouAib50cXmMPf2thIKuJa4yiiJmdK/Z X/dCHH1BZpd4eNH87n0LI+bZSZU5duasu3tU6ZgcTA+oeoo5lJC/8Cgf3sEmXAq4iiVd fQQIZMYgmyuHsAu3izhUGBFLeSdElkYTPyLKJY9EPt4/nCAvcLBUfnlYAd3oJauu+D4M Y3PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=iBe+k353gk5LIG8240LyHPzNr+hWnG7V+MJ23eeCXtY=; b=lpTqgnVdV0OH3kDG27HsAiAlTC2QTA05PR0UnPcsypCO33mcquDKS8+StB9+BKsBSs ILEHp+BV0KetfEYfDeBAvfs9kC+Y3b+um8+OwBKPkg8K1ZY0B2DE84Y9IZviccjInf5L oHs/yCj2582jL8FMzVh+ds6/gBM15ajCo0oeLNeRld/CgVPoXQblplqJQC3IWHs4h+n+ H4tzDUnxyz1x3DGfiNgcxbpO2uj8CXDrzFxx9Y9gRs0VDTYNNwtQu3pgbwl3JgN4SGGe s8hjBPYT1uYlkVLBaj6fJZdonANv2prDAWDnM1U/LZEpu1snjaD/OdiLNV/l3690u6yk uu2Q== X-Gm-Message-State: ACgBeo3RY9G+M34tUHbmXWVOz1ncoxIqgD2XXUmjybE902K7CxWymzz8 0usM95+2/a96sb1mcWdaf9o6hnF9EAL8JSGT7juvrQ== X-Google-Smtp-Source: AA6agR4tpOKT59ihpMDuUVgMNiVWeU/KCGuwR+MMAA5eF9vug2/0rtEQ2B8Uz0zWeu6E0XYYu7mDmxNhNX4JygTVYas= X-Received: by 2002:a05:6808:10ca:b0:343:2fbe:8fa2 with SMTP id s10-20020a05680810ca00b003432fbe8fa2mr10465862ois.220.1660583392124; Mon, 15 Aug 2022 10:09:52 -0700 (PDT) MIME-Version: 1.0 References: <20220812012843.3948330-4-zokeefe@google.com> <202208151331.uxreCJWj-lkp@intel.com> In-Reply-To: <202208151331.uxreCJWj-lkp@intel.com> From: "Zach O'Keefe" Date: Mon, 15 Aug 2022 10:09:16 -0700 Message-ID: Subject: Re: [PATCH mm-unstable 3/9] mm/madvise: add file and shmem support to MADV_COLLAPSE To: kernel test robot Cc: linux-mm@kvack.org, kbuild-all@lists.01.org, Andrew Morton , linux-api@vger.kernel.org, Axel Rasmussen , James Houghton , Hugh Dickins , Yang Shi , Miaohe Lin , David Hildenbrand , David Rientjes , Matthew Wilcox , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Chris Kennelly , "Kirill A. Shutemov" , Minchan Kim , Patrick Xia Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660583393; a=rsa-sha256; cv=none; b=PXHn3E6USuoeaiMdmRxzfTzivKn88NBPWZ1UmKnIU3qtl2ynejlbdUzjLJfrh31teRbvPB ZuYD40sJlPT/aAGm9P/Q4pQ9Y12Fr4183nui5do6FtnfSRVn/HaoUiQs1nbS6mxk2U3yv4 TX8qgd5I1JLhHS4LJ+GWfi7L2LZ18jA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NWeuUYPy; spf=pass (imf21.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.177 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660583393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iBe+k353gk5LIG8240LyHPzNr+hWnG7V+MJ23eeCXtY=; b=E3lo4zYNiWCGlw4FZ26/S5g9ETxa3Y60MQqI873UzHHossAmNGf7I7cGwqKEQBCFWBv+sw poyVP6FDDpgh8xpKjwuboBJGfI1oPujE8+Okg/qu/R1YyqoI4GvP/SjVwcyx5EqxqWEqa4 9joIoyxFRkOUyu8Kfml5EgXy9wsGh08= X-Stat-Signature: ihxbnp11zydt43wdmzix888a5xy9ppqy X-Rspamd-Queue-Id: 4DD8B1C00A6 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NWeuUYPy; spf=pass (imf21.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.177 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1660583393-170714 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 14, 2022 at 10:41 PM kernel test robot wrote: > > Hi Zach, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220815/202208151331.uxreCJWj-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/dff08746d6f7b9387b94360b66bd9db644542991 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122 > git checkout dff08746d6f7b9387b94360b66bd9db644542991 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > mm/khugepaged.c: In function 'set_huge_pmd': > >> mm/khugepaged.c:1403:13: error: assignment of read-only variable 'vmf' > 1403 | vmf = (struct vm_fault) { > | ^ > > > vim +/vmf +1403 mm/khugepaged.c > > 1393 > 1394 /* hpage must be locked, and mmap_lock must be held in write */ > 1395 static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, > 1396 pmd_t *pmdp, struct page *hpage) > 1397 { > 1398 struct vm_fault vmf; > 1399 > 1400 VM_BUG_ON(!PageTransHuge(hpage)); > 1401 mmap_assert_write_locked(vma->vm_mm); > 1402 > > 1403 vmf = (struct vm_fault) { > 1404 .vma = vma, > 1405 .address = addr, > 1406 .flags = 0, > 1407 .pmd = pmdp, > 1408 }; > 1409 > 1410 if (do_set_pmd(&vmf, hpage)) > 1411 return SCAN_FAIL; > 1412 > 1413 get_page(hpage); > 1414 return SCAN_SUCCEED; > 1415 } > 1416 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp > Thanks lkp & apologies here. Anticipating at least one successive version and will include the fixes there.