From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDE0ECAAA1 for ; Mon, 31 Oct 2022 21:25:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 350AF6B0072; Mon, 31 Oct 2022 17:25:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 300D280008; Mon, 31 Oct 2022 17:25:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C94280007; Mon, 31 Oct 2022 17:25:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F9D86B0072 for ; Mon, 31 Oct 2022 17:25:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B04D140EB2 for ; Mon, 31 Oct 2022 21:25:05 +0000 (UTC) X-FDA: 80082524970.18.B9EBB8F Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf20.hostedemail.com (Postfix) with ESMTP id 19EEC1C000D for ; Mon, 31 Oct 2022 21:25:04 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id h12so11577138ljg.9 for ; Mon, 31 Oct 2022 14:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Poqi0S+lTNDgTpQgWXB2RyJ19j0tnps12E7PSd99EJk=; b=N37URAjA4MHlcjGjmHWdd0BxLWm0Fcmh8Q7WDXFV130wCPTuT125RJWDSQJxx8LC99 e3uBmJr2JJNpAzVvJqxS2lbiBZkpY1Vp0xNQiJRHsk+zNt7DE7JjB7G4DrpoNVyBEBii ZQFILxr/TGwV04m++waf0LYkSLcVVc60hKnZ4Zc2lfx5DFQZIttiJShJV6FNZkI1UE18 iq3J8TXfNSkDfk2vgfww8X7iAoSIz13Pf4R5Vtgi5WyU+uBId3rho3Hhwl+4xTDG+mBC T4aRg9c0aILvCmOHddz6ztgkUdsZDCBxEhosd1RAnR5E73Uz1YupqFvmYqub4AYiQyNQ spJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Poqi0S+lTNDgTpQgWXB2RyJ19j0tnps12E7PSd99EJk=; b=qhPhC8LyWtNe33fketDk2cgViVBErjgKuhrLO1nHNgz8bfNhXFaRhufMA2OfCbrvEC 0YKshM/xemEN47MUFjE0zOvtB+/g2dpPVkrz4GAud2TAVMNKyb/NtNbLmATGTyOYOF4u 4M3NAWnRq9xDT4HaxcPdlXoSP8DDh2KaVAXonAxnepaAr8Mopw2To5KMLgdJFHetxO+P ruhpwMjyfsslFwl8s/hJ/I0915RXAnCLx5M9qkLxS4nIHRV5Yf2DEKXRItoVvNcwbXM8 JuXRxqeha+k7UdWwv7gYlJZojA7dSNxLoIsAiQTKkapVTyrkrRvaEod/PJdIN5cIUVFd Nijw== X-Gm-Message-State: ACrzQf2MrxtALu1pOUkNsISQWB2ysj/pxWr8p5nRIqVhPajmnrN/zAg+ uI5Tnl2GwCcWWKJIZitSQzidLi2POkqv34XCZoXPrL9/DARSNA== X-Google-Smtp-Source: AMsMyM5f6qPqj+5tjnoJo98Prg2EVhn1Jojb/DG382S1GV278k5Ptwdej9mOY/nVkhGaTWfPsifncYAjHRwsXWeTp1g= X-Received: by 2002:a2e:aa9b:0:b0:277:d86:a36d with SMTP id bj27-20020a2eaa9b000000b002770d86a36dmr29497ljb.288.1667251503322; Mon, 31 Oct 2022 14:25:03 -0700 (PDT) MIME-Version: 1.0 References: <20221021223300.3675201-1-zokeefe@google.com> <20221021223300.3675201-3-zokeefe@google.com> <2f67d133-8996-ef10-4a36-42537906ebba@gmail.com> <090c2221-63b3-6f1f-d0dd-334b3e64abd8@gmail.com> In-Reply-To: <090c2221-63b3-6f1f-d0dd-334b3e64abd8@gmail.com> From: "Zach O'Keefe" Date: Mon, 31 Oct 2022 14:24:27 -0700 Message-ID: Subject: Re: [PATCH man-pages v3 2/4] madvise.2: document reliable probe for advice support To: Alejandro Colomar Cc: Yang Shi , linux-mm@kvack.org, linux-man@vger.kernel.org, Michael Kerrisk Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667251505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Poqi0S+lTNDgTpQgWXB2RyJ19j0tnps12E7PSd99EJk=; b=IXLNMLqXprwOzDaS46LdzkIBSHzqzdmeeWrXc0bcqA/b3Lt1N5mnl8lHOT++H7DFG4aAwu eI8RF/DIy3dtxTmKJwE5P3KKe9BZPmkWGOvYJK/HGQHbn0HN03hr1kzfiLufSmeoU7arJF KjLFgxPfI7UZoPsrg6iiX/9/7Wpzx8Q= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=N37URAjA; spf=pass (imf20.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667251505; a=rsa-sha256; cv=none; b=qHejobqlE/Mw77g+t7xc95gaHUa7T6xZjF1olvpdfZnzIgqaUrE6HyLdPkS6J6TuqSc7fO LIe64JXU6GwEZAeB0zKsaVxLC9Si6dGwBdl/YjP14qv1fuVoXRqRaRPAw9V96e/Bp14+db N25OM5UjEOpau26j8M0Zul8he5CFJcQ= X-Stat-Signature: zgkc91t1sf4mcstp8xdukhwhjrdhqiba X-Rspamd-Queue-Id: 19EEC1C000D Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=N37URAjA; spf=pass (imf20.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1667251504-287420 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hey Alex, On Mon, Oct 31, 2022 at 1:21 PM Alejandro Colomar wrote: > > Hi Zach, > > On 10/31/22 17:33, Zach O'Keefe wrote: > >> Patch applied. > > > > Thank you! > > > > Best, > > Zach > > > >> Thanks, > >> > >> Alex > >> > > I just caught a small formatting issue by running some linters through that file: > > $ make -ij lint >/dev/null 2>&1 > $ touch man2/madvise.2 > $ make -k lint-man > LINT (groff) tmp/lint/man2/madvise.2.lint-man.groff.touch > an.tmac:man2/madvise.2:795: style: .IR expects at least 2 arguments, got 1 > found style problems; aborting > make: *** [lib/lint-man.mk:77: tmp/lint/man2/madvise.2.lint-man.groff.touch] Error 1 > LINT (mandoc) tmp/lint/man2/madvise.2.lint-man.mandoc.touch > mandoc: man2/madvise.2:15:5: STYLE: lower case character in document title: TH > madvise > mandoc: man2/madvise.2:15:15: WARNING: cannot parse date, using it verbatim: TH > (date) > make: *** [lib/lint-man.mk:87: tmp/lint/man2/madvise.2.lint-man.mandoc.touch] > Error 2 > make: Target 'lint-man' not remade because of errors. > > > The issues reported by mandoc(1) are expected; but the issue reported by > groff(1) is legit. The offending line is: > > $ sed -n 795p man2/madvise.2 > .IR madvise(0,\ 0,\ advice) > > Since all of the line is formatted in italics (no roman part), it should be .I > and not .IR. > After fixing that line, the linter now says: > > $ make lint-man -k > LINT (groff) tmp/lint/man2/madvise.2.lint-man.groff.touch > LINT (mandoc) tmp/lint/man2/madvise.2.lint-man.mandoc.touch > mandoc: man2/madvise.2:15:5: STYLE: lower case character in document title: TH > madvise > mandoc: man2/madvise.2:15:15: WARNING: cannot parse date, using it verbatim: TH > (date) > make: *** [lib/lint-man.mk:87: tmp/lint/man2/madvise.2.lint-man.mandoc.touch] > Error 2 > make: Target 'lint-man' not remade because of errors. > > > Ignoring the spurious mandoc(1) warnings, it's all good. > > Documentation about how to use this feature is here (written today, so no way > you could have run it; I should have, though :D): > > Thanks for taking a look here and thanks for adding the documentation to CONTRIBUTING -- was easy to follow. As you mentioned in 1/4, I don't have the groff(1) version (GNU groff version 1.22.4) to see the error, but it seems like a real fix (& I've taken a look at your fix patch - thank you :) ) Thanks again, Best, Zach