From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67143C4332F for ; Tue, 1 Nov 2022 15:04:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C90F56B0072; Tue, 1 Nov 2022 11:04:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C41836B0073; Tue, 1 Nov 2022 11:04:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2FFC6B0074; Tue, 1 Nov 2022 11:04:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A5A246B0072 for ; Tue, 1 Nov 2022 11:04:56 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 75ECE1A0A9B for ; Tue, 1 Nov 2022 15:04:56 +0000 (UTC) X-FDA: 80085195792.13.6E53434 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf11.hostedemail.com (Postfix) with ESMTP id F2CD540054 for ; Tue, 1 Nov 2022 15:04:54 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id h12so14556876ljg.9 for ; Tue, 01 Nov 2022 08:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=57MFR50EAZAkGqWq9GcwxYtqkFmZdIuzNs9CdVFzmMY=; b=hzhyIEgI+HyUqCzTN/j/4NS1gus7+wOq3eDdfpJgtCbD7uTYYuqxPCbNjt+TqVfm1T qN+FZrVyl0BKIVwrTRNaxoHG8GIdoIzk+nc4e8IEBBPsMN1YZwyIzaxbAa25FWtgixvs VaaBPFdy2YWCgf58yV6HjbhofoZm+lfgcsOEgtx5TvyTsUxsIC0DyPy+rq3CvgH9Xoc9 AIHNyUFUyNv2t3CG7K4Uoo2rh6k11tmjDh0iK8za9cHDf+T68prjSP3SF8gg1WQN7Zaf QtPuXukJPLJR2srE7BuSa2LsykLht9dkACaoSpENrkskn7aVes7KOyqndWktbSMO1lwj /PNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=57MFR50EAZAkGqWq9GcwxYtqkFmZdIuzNs9CdVFzmMY=; b=XJbEjh0ijfHg6XlGJiu/Ffkwc3m3WT250iSbauaeQ1dIXJvxj0rwDkG+41WXjduEDO Ivv8QMGnhmpF3dMlHP8xMIBKGy9NwsAw6FDI15rpsXMRRsy+zZNuBaS/WfvoF21Wfb57 TBYvDZaM642BSZ//fOwlqL+U1dBCgCvzsfDuq/8HTXDp5ExkMVR8Y1FYCcov46nuHIh/ nVLyfXFsIZa9wE8wn3CrK7CjNBWXXj75DXDLPz2PbbV9H70pu+cFa638uudLjywnT0m0 MUuPvdG18z7BSLeMRFCiN9SXUcc7a7XGF8lh5SyP+/ER6ecnsRnSZlsRa6BWB2BY2tll ihSw== X-Gm-Message-State: ACrzQf0VTAhXqkhTu+97oB4E0U0ZveT0eSAS4ZBkzabGInXx2HMDw2yw FPsIfhyrTJsNWhSeQewK27bpYcurySJYIIp3V0ND1g== X-Google-Smtp-Source: AMsMyM525yEatGK7hudXU69ZCfB2vezhYUbCQsh4gtwoRG//x9u/roSWkdigy71DwHI5XacAOSjISxupdsxqElDwq7k= X-Received: by 2002:a05:651c:1070:b0:26d:e6c4:1df7 with SMTP id y16-20020a05651c107000b0026de6c41df7mr1005745ljm.89.1667315092580; Tue, 01 Nov 2022 08:04:52 -0700 (PDT) MIME-Version: 1.0 References: <20221031225500.3994542-1-zokeefe@google.com> <4b4a42ee-9243-96aa-b581-d56ae420f84a@gmail.com> <78113c25-a635-8d35-a5db-9657f8adf4a6@gmail.com> In-Reply-To: <78113c25-a635-8d35-a5db-9657f8adf4a6@gmail.com> From: "Zach O'Keefe" Date: Tue, 1 Nov 2022 08:04:16 -0700 Message-ID: Subject: Re: [PATCH man-pages v4] madvise.2: add documentation for MADV_COLLAPSE To: Alejandro Colomar Cc: Yang Shi , linux-mm@kvack.org, linux-man@vger.kernel.org, Michael Kerrisk Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667315095; a=rsa-sha256; cv=none; b=h1jVhWEDYyPmUwKA1Rif9/qJeU7hWvVxb14mfeqxvLMJRPo9AasrpuMg7+iw4TME//1nnP yCFzTSrp9S9Vo5F1+et0ODC0kee4yE6+C6dLnM6R6MPZV8uKqptAETApcN9MG6msB8vLyS bkVImClhJr8McLA5PVf7DgesbaFu3mE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hzhyIEgI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667315095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=57MFR50EAZAkGqWq9GcwxYtqkFmZdIuzNs9CdVFzmMY=; b=tFZHPoragP52LihJXCRvOXZOIOrOPHDKWtjkn0q3xVAf6Jv5SS82CZLz50jl+OzMrGaEUZ HGUckk24bgmOwIBa0x0v7PJymYijz78lDSfp74Of8BPqxYLWVZboH7LpnGxmx1F5IyxZHq EP7RsfGhstjasrAm5Ytl4DSKS8kQ9To= X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hzhyIEgI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Stat-Signature: pehfhs6bp1npmxnif34ehx7ii5nitok6 X-Rspamd-Queue-Id: F2CD540054 X-HE-Tag: 1667315094-185229 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hey Alex, On Tue, Nov 1, 2022 at 4:38 AM Alejandro Colomar wrote: > > Hey Zach, > > On 11/1/22 01:38, Zach O'Keefe wrote: > > >> > >> I don't understand this last paragraph (since "Also note ..."). Could you > >> please reword it a little bit? > >> > > > > Sure - I can see that it's hard to parse. > > > > Further up I note that, "If collapse of a given huge > > page-aligned/sized region fails, the operation may continue to attempt > > collapsing the remainder of the specified memory." > > > > Then perhaps it's enough to just state, "In the event multiple > > hugepage-aligned/sized areas fail to collapse, only the most > > recently-failed code will be set in errno" > > I like this. > > > > > The idea here being: errno only communicates the reason for 1/N > > failures that might have occured. > > > > However -- on second thought -- perhaps this isn't particularly > > useful, as it's already implied. So, my new suggestion would be that > > we should drop it. What do you think? > > errno usually behaves like that if you call consecutive calls, but it's not so > obvious how a single call will behave: it could report the last one as in this > case, or the first one since it's the one that made it break. I'd keep it. > Roger that - done && have sent out v5. Thank you so much again! Best, Zach > [...] > > >> Diff for changing a few line breaks (and removing the spurious file): > >> > > > > Thank you so much for this! :) > > :) > > Cheers, > Alex > > -- >