From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E74C43334 for ; Wed, 13 Jul 2022 18:40:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 777D294015A; Wed, 13 Jul 2022 14:40:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7003D940134; Wed, 13 Jul 2022 14:40:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A0EF94015A; Wed, 13 Jul 2022 14:40:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4482B940134 for ; Wed, 13 Jul 2022 14:40:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 0CC8360C11 for ; Wed, 13 Jul 2022 18:40:48 +0000 (UTC) X-FDA: 79682942976.26.52C65FE Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by imf05.hostedemail.com (Postfix) with ESMTP id 8CAC210004E for ; Wed, 13 Jul 2022 18:40:47 +0000 (UTC) Received: by mail-oi1-f176.google.com with SMTP id x185so5869943oig.1 for ; Wed, 13 Jul 2022 11:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ubruxYqX8Ofw8BFj5ZITCkdkqDEEAjtGWNHyqjB5GYg=; b=ETLrN1HRcdBtmkKjZC5xZHgnd1vhCMXgOIoegWL4pHbDkckw3hD6FFgf6pP3oLRJzF npZMTAyp/05+Jf7ikTs2k+DtFqeAeA054bHoYYaP2T+o+6R1vHB6PUBjeus7dihfvI+9 jA9V1qvxS+vFag4UO5ir4JsTJTJPqK8/RNO7BcBpEqGaYNIF4zD+1ameiuj+01+3seAI Cyf3e7kNngRsa+Im1aSV4P8VK7+608yINAF5os8SvTSSROan3R+dXGGlvLstA8ezhUoQ UyrpkHqTK4hqyJfrvgVM/NuLHDYXXFL5JUvk4ctoEqGWKVSwk0rZjNJlQtC/e592jAbT baKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ubruxYqX8Ofw8BFj5ZITCkdkqDEEAjtGWNHyqjB5GYg=; b=Ee0pn4lDdC6E9BhJj0DfCKRoW2+OhrmXXvSqudmYyzVS+Uz1MOPH+tc6PtsITgnZp5 +IWFB8SD+pin0rt2ldXA8EOPVMEGrCJkXJV1hFm6IbDqnmCL5BcThVCOrnOLda47NWh4 Z7QW5Ql0tWiLrYjpGez4/iMkyaM4Xm0aZdh7tFMIk397NqHMeC5X+7PmEvM+1D0C8fkD hQo4YZ4Dsjtn7k37dKFypoWKg4ckbCzxH4OZLBHhB9GkMB7mE/wUcOmlAT+lA1jfeGPD flVgmbqfJgWmRe+qstFwDHHQ+QsS/8ir4Wc4KdeC83x3ooFyj7PLatr6CztcL5mnFOT9 Ej0w== X-Gm-Message-State: AJIora8lof3y5G4/PgaPpRKFBjTHm4lqPnOlS4o3CVOQi+MfAvXDx+pq Heq8n3umxmGyy0OM77gMqnoo69qTQXooPIioNEaxUA== X-Google-Smtp-Source: AGRyM1sa0K7ikjil6eHdIqe+NaGffaU+oxZXC1KB9dEdBw6c27KH8fvRMhv+X2qSMNgc7bsh49CvLOvY4ljqMSs5I54= X-Received: by 2002:a05:6808:19a0:b0:33a:2a60:c151 with SMTP id bj32-20020a05680819a000b0033a2a60c151mr2249065oib.220.1657737646512; Wed, 13 Jul 2022 11:40:46 -0700 (PDT) MIME-Version: 1.0 References: <20220706235936.2197195-1-zokeefe@google.com> <20220706235936.2197195-14-zokeefe@google.com> <20220713110223.ead770e321900fbc4877d309@linux-foundation.org> In-Reply-To: <20220713110223.ead770e321900fbc4877d309@linux-foundation.org> From: "Zach O'Keefe" Date: Wed, 13 Jul 2022 11:40:10 -0700 Message-ID: Subject: Re: [mm-unstable v7 13/18] proc/smaps: add PMDMappable field to smaps To: Andrew Morton Cc: Yang Shi , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Zi Yan , Linux MM , Andrea Arcangeli , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer , James Houghton Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657737647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ubruxYqX8Ofw8BFj5ZITCkdkqDEEAjtGWNHyqjB5GYg=; b=rJtOnram7mMUmj4NrJTxx0iJ8F7+2F0MSPLhBfugWLmDBZwgCp36202pP5KscFB6Yxsm0H 1YosBD93M1CA1fB9btAViEKdmCe3sp8qMrIZeGzWL0wIybzwfrlvGsA8++RXizjVAULvQv cFGYo32Y94sQUTEe2j6ZIpdJneEECMY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657737647; a=rsa-sha256; cv=none; b=oD/r30s5Pfw6XxKzHk9fx5MchtLXPrFmTNlzlDEF1lFQyRxrn6aIMxZzfH8czThbKt7PNh eesb5nqXvz1uGGRYuO9h6lJgwmll2TIi2VDTclAjjHN/HyDshP8z538X6BJfk7OOlW0Q1A UU7QD183XUw+T2GXcOVn2aSm6Xz3bFw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ETLrN1HR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Stat-Signature: maypqmywb7znbu9k66qqr1nd1iuoo55s X-Rspamd-Queue-Id: 8CAC210004E X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ETLrN1HR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspamd-Server: rspam05 X-HE-Tag: 1657737647-107839 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 13, 2022 at 11:02 AM Andrew Morton wrote: > > On Tue, 12 Jul 2022 10:57:07 -0700 "Zach O'Keefe" wrote: > > > > I'm not sure what applications rely on this hint, but if they are just > > > some test scripts, I think it should be fine. I don't think we > > > guarantee the test scripts won't get broken. AFAIK some test scripts > > > rely on the kernel dmesg text, for example, OOMs. And the meaning of > > > the fields do change, for example, inactive anon of /proc/meminfo, > > > which was changed by the patchset which put anon pages on inactive > > > list first instead of active list. We already noticed the abnormal > > > value from our monitoring tool when we adopted 5.10+ kernel. And > > > /proc/vmstat also had some fields renamed, for example, > > > workingset_refault of /proc/vmstat, it was split to > > > workseting_refault_anon and workingset_refault_file, so we had to > > > update our monitoring scripts accordingly. I think /proc/meminfo and > > > /proc/vmstat are more heavily used than smaps. > > > > > > > Thanks for the great context. My guess is, right now, THPelligible is more > > useful as-is than if we were to relax it to MADV_COLLAPSE eligibility. As such, > > I'm fine dropping this until a stronger and more immediate usecase presents > > itself. Thanks for checking my rationale here. > > So... should I drop this patch? Ya, I don't think I have a solid argument for inclusion right now. Thanks Andrew, Zach