From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA7CECAAD1 for ; Wed, 31 Aug 2022 21:25:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98BAF6B0072; Wed, 31 Aug 2022 17:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 913E88D0001; Wed, 31 Aug 2022 17:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B49F6B0074; Wed, 31 Aug 2022 17:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 695726B0072 for ; Wed, 31 Aug 2022 17:25:12 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3A85180E23 for ; Wed, 31 Aug 2022 21:25:12 +0000 (UTC) X-FDA: 79861168464.22.2CC75A1 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by imf26.hostedemail.com (Postfix) with ESMTP id DB354140057 for ; Wed, 31 Aug 2022 21:25:11 +0000 (UTC) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-11eab59db71so23333281fac.11 for ; Wed, 31 Aug 2022 14:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=g+LFT64nKjvFQ9xBs3ga17iSDMJNzcQHBlCbx79FOAA=; b=Z4r+al+4Pp7+eTwrj0gkK1wBO8Z0CpU7HFRAFrfv4p86LXjVXcvfALv60ZlKgJxda2 buOcRK5++YP6s/L3n6ZjEeHdba/BWIXiWTp14xU9HOBtdXk9gdNeo41fD9jm9u8oeOTS b3odhDl+/3OiWnz7H6fJQC/oFftOplAIsblpfHfw7/WhNrze0wGyl0bKOBU0PaM3u0mC v2snYeD51HdMQUR0pqB99AA++xapBHElVIVCuQeBwR0/Gzc5Ag66WSfDLcshMKsLntyq 5SDsbDX2/7vIlG6ILnLQtms7Fy8OlV8fh9x6Th6J9i95F76zXuGnq8FlvbFEYFxjx+Sc CB0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=g+LFT64nKjvFQ9xBs3ga17iSDMJNzcQHBlCbx79FOAA=; b=EgO1mJCAn2tDkSFDfbFxJ+ArKcU4mnUCSNuAN2ytMd7xcT0jpDxpBKxFFFFmYEONY8 ESYKlDXjMuUly7DSlRAnoUe7WN4wE1UwDk0LrChQ7wgPihfSWQ2JYepfAz3hn3S79z7k sjbD8DiNZU8VkYDpNPE6ANf/fqzhhMIbAeE7C1RShyTszSLgbZ5DAVivZ4AeWFs6+mt+ ylUqneH8qyQdyJPNWFi+qParCr4g8CAL0uGGjVokYXOtzjBXDscOpwkKiM8yJfDeZaYN SI+/gzRWwciJUgQdwL2xmMb3ANJxmoYqXn128sMlp3+c7mS1gFgyB0oVw8f+JwkoaJ+D UYiA== X-Gm-Message-State: ACgBeo24RImoiRMuytdWo2MxsqJzHqvl3DJSnauXed1+Tr9+VX56bueA CVfVw2O11oqTNVUA3OwpIs3jZPirp+DeFp5tG/o0Fg== X-Google-Smtp-Source: AA6agR4N+yQXPnOGxaJMFenO1Wz9ePQE4H8Up8oiR4Fnc6irTFXk/fUy8f1Iwrt05kWPuLi9Qce/XHeXKrUoHCdbHkg= X-Received: by 2002:a05:6870:4308:b0:10b:8cbe:c945 with SMTP id w8-20020a056870430800b0010b8cbec945mr2401759oah.220.1661981110841; Wed, 31 Aug 2022 14:25:10 -0700 (PDT) MIME-Version: 1.0 References: <20220831211526.2743216-1-axelrasmussen@google.com> In-Reply-To: <20220831211526.2743216-1-axelrasmussen@google.com> From: "Zach O'Keefe" Date: Wed, 31 Aug 2022 14:24:34 -0700 Message-ID: Subject: Re: [PATCH] selftest: vm: remove orphaned references to local_config.{h,mk} To: Axel Rasmussen Cc: Andrew Morton , Shuah Khan , Tarun Sahu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Z4r+al+4; spf=pass (imf26.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661981111; a=rsa-sha256; cv=none; b=kjnfF3+YXlnqf8MbmDdhvkanZiAK0Su++WbJdUTM8itawv+6mO3MAWD4s9F1DEeMiNSGFL j/hWLcMzS6NSvjwoVan+QwQ0XZvE1WeND7StsLmGifC5Mr74znBL6rILln1fmcHzUU1W9O PHUhKBPy16jRV/btY81QMKAm/G1kTS8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661981111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g+LFT64nKjvFQ9xBs3ga17iSDMJNzcQHBlCbx79FOAA=; b=ViIbzzehpW1MNTC276COHrR+WvpRcvAecArQw8KYtGVHDM1QAfsh0H734aInHNfXf6AFL2 zS5SwCGUBctCak+vlMbRYy7/SEVsjTwANnIWZy/NzfldZORhOaz1CZqWl6t+sDwhvD6gUd xcz3Uee7eDV6FvjfaxYrRLr/4OpDkFY= X-Rspam-User: X-Rspamd-Queue-Id: DB354140057 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Z4r+al+4; spf=pass (imf26.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 8ke9u6sg6fsrh4bho6j3d84jb6g8urxx X-Rspamd-Server: rspam11 X-HE-Tag: 1661981111-602583 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 31, 2022 at 2:16 PM Axel Rasmussen wrote: > > Note: this commit is intended to apply to mm-unstable, the commit being > fixed only exists in that branch for now. > > Commit b4efb234e53cc60ccdc855190be9f35918687412 ("Kselftests: remove > support of libhugetlbfs from kselftests") removed the rule describing > how to build local_config.{h,mk}, but it left two references to these > files lingering around. The result is, none of the selftests could be > built due to dependencies with no rule for how to build them. > > Signed-off-by: Axel Rasmussen > --- > tools/testing/selftests/vm/Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile > index b52f2cc51482..4ae879f70f4c 100644 > --- a/tools/testing/selftests/vm/Makefile > +++ b/tools/testing/selftests/vm/Makefile > @@ -1,9 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > # Makefile for vm selftests > > -LOCAL_HDRS += $(selfdir)/vm/local_config.h $(top_srcdir)/mm/gup_test.h > - > -include local_config.mk > +LOCAL_HDRS += $(top_srcdir)/mm/gup_test.h > > uname_M := $(shell uname -m 2>/dev/null || echo not) > MACHINE ?= $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e 's/ppc64.*/ppc64/') > -- > 2.37.2.789.g6183377224-goog > Thanks Axel! Works here on latest mm-unstable Tested-by: Zach O'Keefe