From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAADC433FE for ; Tue, 18 Oct 2022 21:23:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C63EB8E0003; Tue, 18 Oct 2022 17:23:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C142C8E0001; Tue, 18 Oct 2022 17:23:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADB8E8E0003; Tue, 18 Oct 2022 17:23:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A17438E0001 for ; Tue, 18 Oct 2022 17:23:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 76EE2120315 for ; Tue, 18 Oct 2022 21:23:25 +0000 (UTC) X-FDA: 80035346370.07.5B57959 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 21176180034 for ; Tue, 18 Oct 2022 21:23:24 +0000 (UTC) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-134072c15c1so18420893fac.2 for ; Tue, 18 Oct 2022 14:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HKNro2Dl2lLl1vH96Fa6tylrRWVVjIEfAK2Tj8kMrac=; b=mQZqbeuZgFxPySK+/ATK+Ynm8gV5RriBOamrhsmxgpg+1qx2/sq2k6HkhFAQAhpLkA jZYNPN2SB4+/ERAHiNlofKC5YvbVH1vUspptyioL5QHumpha/s+GiNg1mpAPQOKGWiSw kCBKZsUYts6F5XFTlRZtO+QZw+x4cPFG6JSsCyVfakMK9jgMhzO+cTbjAUhTFmiDxHOj ITnRol1I8MzlUVBb9y7gaJj6ldCzYf8UJmJXiN8XDx5UnJ12yOA9PDbt0rrWePSV7Bh9 McgEPagKwYlbt77JIYXbD4xUOP6CpCiIn/EbIHIsukyNbpc6d51vS03JQ8svzAY36jlj 0mcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HKNro2Dl2lLl1vH96Fa6tylrRWVVjIEfAK2Tj8kMrac=; b=YtaqGLSxv4bWZGE99NKKswkTBVXfhCaQRHPWGnTy3ZINSzX0iWGLigFKyLmOEbL8sp iDB61Y2wxKi04tTJWM9+qR2FiDS6z/xJp0DiV4nP8B6FtCElPIGNjRnQVj66hKV69RGE tAXsYne9093ON73bvEkn+jV05uZ+JPQ0w1NPJOOxkeCwRnOSDbS+HUGvEZMFWfEGzUdj RdwUrEo6ZqFydAh+CqUBxisf2NwZxiX4iid9gIco+ekOcO+/NGnxsKNFXkLcEtjINMy8 dzOctw8Djl4uaAw7ZnKxWwTeDjaetGCsUI6RnLXqkO6uO0coEU3pQNGU21MFbzbiuPR4 tspg== X-Gm-Message-State: ACrzQf0Lrr0Kv/iy6S/JEZmQZ1gEPPHwG12vuFdr4fYTM2qB/aqKCB1x e5qIgzBQBrn/3RKf7yeTJ4Q57s41RS1ZGwqcJP351g== X-Google-Smtp-Source: AMsMyM7JsKutNnrrYEHZPS1NHrhsFk9OhYRU++CvDtuKH2c/lSnYp62n6rXadzxeR4sfoZAHXx4Z6+dRuEC3Gwb9LxA= X-Received: by 2002:a05:6870:7023:b0:132:538:43e7 with SMTP id u35-20020a056870702300b00132053843e7mr2792828oae.123.1666128204029; Tue, 18 Oct 2022 14:23:24 -0700 (PDT) MIME-Version: 1.0 References: <20221017175523.2048887-1-zokeefe@google.com> <20221017175523.2048887-4-zokeefe@google.com> <95dd505c-40cd-b4f3-c510-1f21dcb77f1d@gmail.com> In-Reply-To: <95dd505c-40cd-b4f3-c510-1f21dcb77f1d@gmail.com> From: "Zach O'Keefe" Date: Tue, 18 Oct 2022 14:22:48 -0700 Message-ID: Subject: Re: [PATCH man-pages 3/4] process_madvise.2: CAP_SYS_ADMIN cleanup To: Alex Colomar Cc: Michael Kerrisk , Yang Shi , linux-mm@kvack.org, linux-man@vger.kernel.org, Suren Baghdasaryan Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666128205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HKNro2Dl2lLl1vH96Fa6tylrRWVVjIEfAK2Tj8kMrac=; b=8oPCcm8Jl20/qtwqnpsU8TBwJ+t7TVipYgM0vaEiKaGDFRqj1NOpWQgptTIbXYEawYiCk1 gG0wGpljiapwEC2zMOFmz0o7C3fdtcux+FsrIXlW6vK4KeM3FR4juu0TEFQ2MRX2KW4Fkv WqoyhIKxTkOiTAP71e2RilWSOjN84Z0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mQZqbeuZ; spf=pass (imf24.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.53 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666128205; a=rsa-sha256; cv=none; b=tVgvkTg/bsNci/RuST/iA5/Sumxbkb9aQ4EfInwMejp1ozo8LgTNWNDqbl3tFp4j7bs6LP Dhhq92mQ6TQSGLoTilt9VP9sn2jXrr6kJD6SobTDYU2ef6gGMXEnU1Vo83a5YfzVHQyvwR LVFtSXQkZSBXZ1IknC3Omsh8jYwUIMU= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mQZqbeuZ; spf=pass (imf24.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.53 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 21176180034 X-Stat-Signature: 31qacejouy1nppabfxuyk58hg9yd3j64 X-Rspam-User: X-HE-Tag: 1666128204-492719 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hey Alex, On Tue, Oct 18, 2022 at 3:38 AM Alex Colomar wrote: > > Hi Zach, > > On 10/17/22 19:55, Zach OKeefe wrote: > > From: Zach O'Keefe > > > > Since commit 96cfe2c0fd23 ("mm/madvise: replace ptrace attach > > requirement for process_madvise"), process_madvise(2) has only > > required CAP_SYS_NICE capability. Update the man page to reflect this. > > > > Signed-off-by: Zach O'Keefe > > --- > > man2/process_madvise.2 | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/man2/process_madvise.2 b/man2/process_madvise.2 > > index 6208206e4..7bee1a098 100644 > > --- a/man2/process_madvise.2 > > +++ b/man2/process_madvise.2 > > @@ -113,7 +113,8 @@ check (see > > in addition, > > because of the performance implications of applying the advice, > > the caller must have the > > -.B CAP_SYS_ADMIN > > +.\" commit 96cfe2c0fd23ea7c2368d14f769d287e7ae1082e > > +.B CAP_SYS_NICE > > Would it make sense to keep some parentheses specifying that in old > kernels CAP_SYS_ADMIN was requiring instead? Thanks for the suggestion. I've chatted with Suren on this (process_madvise(2) author and contributor of initial process_madvise(2) man-page) and the initial CAP_SYS_ADMIN appears to have been a mistake; it was CAP_SYS_NICE from the beginning. I'll reword the commit description and resend it as part of v2. Thanks, Zach > Cheers, > Alex > > > capability. > > .SH RETURN VALUE > > On success, > > -- > >