From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7682C4332F for ; Tue, 18 Oct 2022 21:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03F826B0072; Tue, 18 Oct 2022 17:54:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F32296B0074; Tue, 18 Oct 2022 17:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8BD6B0075; Tue, 18 Oct 2022 17:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CF41A6B0072 for ; Tue, 18 Oct 2022 17:54:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9B5D5160C98 for ; Tue, 18 Oct 2022 21:54:55 +0000 (UTC) X-FDA: 80035425750.27.DAC1382 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by imf25.hostedemail.com (Postfix) with ESMTP id 497A5A002F for ; Tue, 18 Oct 2022 21:54:54 +0000 (UTC) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-136b5dd6655so18498022fac.3 for ; Tue, 18 Oct 2022 14:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vg0Pcs10Y92MsNWsNPF7sv/sR53jtyZyeD2Za0Kgcdw=; b=N4HpQK/GZ7fxikFLN08ygHMbQJ0CNQnd6j6xW4f4tUOgjLxGJ1QtijxStMRMu4coEW +H1382tHH0EzW22OPoEwiRb7pqB7fiv5LAvys2V3MnBUyTelJvfFFUjHEJDL1HuYDXTt XQSTXgrgqHcyZPkHYkQsrqH+QaOHBZcMdn55mUBDLN5VGqzNPqzazlzpqJjImG6X/8VA 0EyWdl6XmprwvsPgS3t/Xm2I+cLcmyT9+5vfc13rEC95Kjqo78jvK3H3sLagrbqZHLZC s8qxC7ETrRsOLq27Qem5DG6ePFU53V/I21zBiTUWwccIlxseRlmT3jnADQaxskQXTdW8 jttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vg0Pcs10Y92MsNWsNPF7sv/sR53jtyZyeD2Za0Kgcdw=; b=LtUGHHzNRN50SliVUJXumOA/GcR7yH5Gf+2IAsh9kP9Bgj7Fe5/jFAyLgNX2wmlJcH KfHe+GQtgv7Xid5QMsFB3M+Vq0H4HtJTvGuon/Fb1yRBzTOZ0dZiE0tJuCgfKBEANAJV IdTF2pL1JYp/R5fFuS7+Qv3+d8KD88ETPRGkyT27bTCt+P5Flks9E8Bu1mwpShi/AC69 ryPOTS0WvcmHe1kIhVFkbNU72nL24A9QhsecXA158bVCb8hHwseIIuiFqFVFooqdGx/6 8u5sDTXQ6TTWij0UZtjFElDd9l9fMwsxwGyDygb7FQgU20a01unRJfhgaSRx1EzB8XAf WHgw== X-Gm-Message-State: ACrzQf3K1uYiNlQAixWNw9eFC1xWctepPAm0jep0MsOaQlPzCpneAMvZ AF1sqszgkaz2qm2ITJWrUqWVdjKQA/zrjObUY4oZ92XCNCU= X-Google-Smtp-Source: AMsMyM7XrQbi06W+gjRcTz+WgL5SSxyvGih+iSbwSDcckk/j7tSXbhbXjZ7M9kVfJKHI/MqHEp3GVEtc8Wrxi+0fkU8= X-Received: by 2002:a05:6870:7023:b0:132:538:43e7 with SMTP id u35-20020a056870702300b00132053843e7mr2852494oae.123.1666130093426; Tue, 18 Oct 2022 14:54:53 -0700 (PDT) MIME-Version: 1.0 References: <20221017175523.2048887-1-zokeefe@google.com> <20221017175523.2048887-5-zokeefe@google.com> <0e980bc2-d8a8-1ad0-2660-cc9f7f8568a3@gmail.com> In-Reply-To: <0e980bc2-d8a8-1ad0-2660-cc9f7f8568a3@gmail.com> From: "Zach O'Keefe" Date: Tue, 18 Oct 2022 14:54:17 -0700 Message-ID: Subject: Re: [PATCH man-pages 4/4] madvise.2: add documentation for MADV_COLLAPSE To: Alex Colomar Cc: Yang Shi , linux-mm@kvack.org, linux-man@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666130094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vg0Pcs10Y92MsNWsNPF7sv/sR53jtyZyeD2Za0Kgcdw=; b=hMkZTrZtK5xlm2AJxLnaDE6esnx0sOPVZ1oSXEGeFTYd3exIoDUVqjlLeEmt0/5v4OkO+A p5C/6bcqrl2KzoKnCXl9utrCXfCO7FAjEcHvmJ2gmqH/vr3xtZ/Um78F6LpXr8BiZwVWEr LJomEwAPirJb7WKzyeqDAyS23rpLPo8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="N4HpQK/G"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.51 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666130094; a=rsa-sha256; cv=none; b=6ZRRYSfbBcRItSe0kbLi2xbTKZoNaRORGYG4HWd4tahkGsy6FQZbfOoh7tvqKgObz13GPx b9beurwks6OvWMrjfEOnEhfHAis0jYLCjsZlfvp4ynk1N1vQGQxGGObgU3LkKBIwNu9Xh7 EnrpXNk5snyRhA5EMFppnqCT9Nh6KA4= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="N4HpQK/G"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.51 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 497A5A002F X-Rspam-User: X-Stat-Signature: wbmakqpnkswnisnjukp8r17sst77prd5 X-HE-Tag: 1666130094-846554 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hey Alex, On Tue, Oct 18, 2022 at 3:47 AM Alex Colomar wrote: > > Hi Zach, > > On 10/17/22 19:55, Zach OKeefe wrote: > > From: Zach O'Keefe > > > > Linux 6.1 introduced MADV_COLLAPSE in upstream commit 7d8faaf15545 > > ("mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse") and > > upstream commit 34488399fa08 ("mm/madvise: add file and shmem support to > > MADV_COLLAPSE"). Update the man-pages for madvise(2) and > > process_madvise(2). > > > > Link: https://lore.kernel.org/linux-mm/20220922224046.1143204-1-zokeefe@google.com/ > > Link: https://lore.kernel.org/linux-mm/20220706235936.2197195-1-zokeefe@google.com/ > > Signed-off-by: Zach O'Keefe > > Please see some comments below. > There are a few more cases were I'd break the lines at different points, > but there are few, so I'll apply them with an amend. > > Thanks! > > Alex Thank you :) Greatly appreciated. I'll take a look at the patch post-amend to see what I could have done. All the mentioned fixes (thanks for pointing them out) will be included in v2. Best, Zach