From: "Zach O'Keefe" <zokeefe@google.com>
To: Alex Colomar <alx.manpages@gmail.com>
Cc: Yang Shi <shy828301@gmail.com>,
linux-mm@kvack.org, linux-man@vger.kernel.org
Subject: Re: [PATCH man-pages 4/4] madvise.2: add documentation for MADV_COLLAPSE
Date: Tue, 18 Oct 2022 14:54:17 -0700 [thread overview]
Message-ID: <CAAa6QmRu6CkLi9N0BxXmuj0kcwaG386iBqu6MesT-=Kt_HmkhA@mail.gmail.com> (raw)
In-Reply-To: <0e980bc2-d8a8-1ad0-2660-cc9f7f8568a3@gmail.com>
Hey Alex,
On Tue, Oct 18, 2022 at 3:47 AM Alex Colomar <alx.manpages@gmail.com> wrote:
>
> Hi Zach,
>
> On 10/17/22 19:55, Zach OKeefe wrote:
> > From: Zach O'Keefe <zokeefe@google.com>
> >
> > Linux 6.1 introduced MADV_COLLAPSE in upstream commit 7d8faaf15545
> > ("mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse") and
> > upstream commit 34488399fa08 ("mm/madvise: add file and shmem support to
> > MADV_COLLAPSE"). Update the man-pages for madvise(2) and
> > process_madvise(2).
> >
> > Link: https://lore.kernel.org/linux-mm/20220922224046.1143204-1-zokeefe@google.com/
> > Link: https://lore.kernel.org/linux-mm/20220706235936.2197195-1-zokeefe@google.com/
> > Signed-off-by: Zach O'Keefe <zokeefe@google.com>
>
> Please see some comments below.
> There are a few more cases were I'd break the lines at different points,
> but there are few, so I'll apply them with an amend.
>
> Thanks!
>
> Alex
Thank you :) Greatly appreciated. I'll take a look at the patch
post-amend to see what I could have done. All the mentioned fixes
(thanks for pointing them out) will be included in v2.
Best,
Zach
prev parent reply other threads:[~2022-10-18 21:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 17:55 [PATCH 0/4] Add MADV_COLLAPSE documentation Zach OKeefe
2022-10-17 17:55 ` [PATCH man-pages 1/4] madvise.2: update THP file/shmem documentation for +5.4 Zach OKeefe
2022-10-18 10:32 ` Alex Colomar
2022-10-18 16:52 ` Zach O'Keefe
2022-10-17 17:55 ` [PATCH man-pages 2/4] madvise.2: document reliable probe for advice support Zach OKeefe
2022-10-18 10:36 ` Alex Colomar
2022-10-18 17:53 ` Zach O'Keefe
2022-10-18 18:04 ` Alejandro Colomar
2022-10-18 18:30 ` Zach O'Keefe
2022-10-17 17:55 ` [PATCH man-pages 3/4] process_madvise.2: CAP_SYS_ADMIN cleanup Zach OKeefe
2022-10-18 10:38 ` Alex Colomar
2022-10-18 21:22 ` Zach O'Keefe
2022-10-17 17:55 ` [PATCH man-pages 4/4] madvise.2: add documentation for MADV_COLLAPSE Zach OKeefe
2022-10-18 10:47 ` Alex Colomar
2022-10-18 21:54 ` Zach O'Keefe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAa6QmRu6CkLi9N0BxXmuj0kcwaG386iBqu6MesT-=Kt_HmkhA@mail.gmail.com' \
--to=zokeefe@google.com \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox