From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3581BC433F5 for ; Wed, 4 May 2022 21:46:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDEC06B0071; Wed, 4 May 2022 17:46:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8D436B0073; Wed, 4 May 2022 17:46:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2FD46B0074; Wed, 4 May 2022 17:46:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 947B16B0071 for ; Wed, 4 May 2022 17:46:26 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 714881206F2 for ; Wed, 4 May 2022 21:46:26 +0000 (UTC) X-FDA: 79429394772.17.62B025B Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 1FB65180097 for ; Wed, 4 May 2022 21:46:23 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id q14so3331065ljc.12 for ; Wed, 04 May 2022 14:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AvrE81KFONxsiN8ym0o03/ttyb7WgMfRVIVfSTrg7/8=; b=nBA/aJfvLGR0/3vVkTFdHYDYR7Ad9Zv8DFzZ9iV1alzJc0K4o9ehvbCzj9wbQNbuxg xlpu/1bQRPr34nnejoEG4MlXY3I4ZxQa0VDrPlJ/7+vhEsOFeaO6VspJdh0OYKnQSiEs c1UbGV0Kfl8JZOmdWQn8Ru4r2/OUv8PugmUVDEHV5FL9Z79b9rw4J940roBjblDDEm53 PPG48pjvDit4zuIyWgfns58ASDh+aq0ewJjNJbbM4fcRR/PquK8CFcTQOP/1ll8f+Ot5 VIIIFcUCZf6l7T4X2TrAJ0gg5AR3AJfcNY7NvHyQIUVO6fk9ejam5br8HimTeLOGoW6f sjGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AvrE81KFONxsiN8ym0o03/ttyb7WgMfRVIVfSTrg7/8=; b=22ks56/BAvH0myE50ojYdFFCCC4G0spYQM+bV68ygij9eej0OE1zTmtazmDzy1oi6M xZ09sV5hgJoE96tFV7F/Ahj3aaU3NKSywxwrUwlSHYJIE7iSChQ8gXPLeb8WCMIre2xU gzhxa+IlBnrvtEYJFZ6LD+vUBfH6MSUXVf9LE/5aqZ0/iMSfHdWtkLm7dUY/Jhn0aBFJ 3xCW4lCqDlbulolN9WP0JaCcApFQ03agqQhUPCp+jL7aXf438UL+HBm2vNuZOh3MYl71 c8zrt+1fK2gSER0sJBxjQ6v2N80tk6AnDKJGX1QIaRkg6SI+czv3FIlVVLOxobsHSI56 xVmw== X-Gm-Message-State: AOAM532wlqfvn6qcnXgT/6BkUj9umn+6WN4J2HoKEiReRGzH6JNQ63Ze hC/dH0jxWq0lL9GPYTrGt5VaPclQlKLzUwv6G8KgQg== X-Google-Smtp-Source: ABdhPJzNpzvs1zQ4vGJ0Crgx41TtXGFBulNx9786yGuXc7DkRHEuyGbBhbhQOMiFL1WgUB6x1DIJUKjnZxaCDEWyeJY= X-Received: by 2002:a05:651c:1502:b0:250:2328:d127 with SMTP id e2-20020a05651c150200b002502328d127mr9740644ljf.183.1651700784011; Wed, 04 May 2022 14:46:24 -0700 (PDT) MIME-Version: 1.0 References: <20220502181714.3483177-5-zokeefe@google.com> <202205031435.JEToTgim-lkp@intel.com> In-Reply-To: <202205031435.JEToTgim-lkp@intel.com> From: "Zach O'Keefe" Date: Wed, 4 May 2022 14:45:46 -0700 Message-ID: Subject: Re: [PATCH v4 04/13] mm/khugepaged: make hugepage allocation context-specific To: kernel test robot Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1FB65180097 X-Stat-Signature: zk4joyk8f6qp798qk3bqoxqaatbw8aaz Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="nBA/aJfv"; spf=pass (imf06.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1651700783-461092 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry all about this - I fixed this up in v5 On Mon, May 2, 2022 at 11:31 PM kernel test robot wrote: > > Hi Zach, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on next-20220502] > [cannot apply to hnaz-mm/master rostedt-trace/for-next deller-parisc/for-next arnd-asm-generic/master linus/master v5.18-rc5 v5.18-rc4 v5.18-rc3 v5.18-rc5] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-khugepaged-record-SCAN_PMD_MAPPED-when-scan_pmd-finds-THP/20220503-031727 > base: 9f9b9a2972eb8dcaad09d826c5c6d7488eaca3e6 > config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220503/202205031435.JEToTgim-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/0d006aeaf99be94a0dcb727cb6540195f13fd9c3 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Zach-O-Keefe/mm-khugepaged-record-SCAN_PMD_MAPPED-when-scan_pmd-finds-THP/20220503-031727 > git checkout 0d006aeaf99be94a0dcb727cb6540195f13fd9c3 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > mm/khugepaged.c: In function 'alloc_charge_hpage': > >> mm/khugepaged.c:1091:36: warning: passing argument 1 of 'khugepaged_alloc_page' makes pointer from integer without a cast [-Wint-conversion] > 1091 | if (!khugepaged_alloc_page(gfp, node, cc)) > | ^~~ > | | > | gfp_t {aka unsigned int} > mm/khugepaged.c:949:49: note: expected 'struct page **' but argument is of type 'gfp_t' {aka 'unsigned int'} > 949 | static bool khugepaged_alloc_page(struct page **hpage, gfp_t gfp, int node) > | ~~~~~~~~~~~~~~^~~~~ > >> mm/khugepaged.c:1091:47: warning: passing argument 3 of 'khugepaged_alloc_page' makes integer from pointer without a cast [-Wint-conversion] > 1091 | if (!khugepaged_alloc_page(gfp, node, cc)) > | ^~ > | | > | struct collapse_control * > mm/khugepaged.c:949:71: note: expected 'int' but argument is of type 'struct collapse_control *' > 949 | static bool khugepaged_alloc_page(struct page **hpage, gfp_t gfp, int node) > | ~~~~^~~~ > > > vim +/khugepaged_alloc_page +1091 mm/khugepaged.c > > 1074 > 1075 static int alloc_charge_hpage(struct mm_struct *mm, struct collapse_control *cc) > 1076 { > 1077 #ifdef CONFIG_NUMA > 1078 const struct cpumask *cpumask; > 1079 #endif > 1080 gfp_t gfp = alloc_hugepage_khugepaged_gfpmask() | __GFP_THISNODE; > 1081 int node = khugepaged_find_target_node(cc); > 1082 > 1083 #ifdef CONFIG_NUMA > 1084 /* sched to specified node before huge page memory copy */ > 1085 if (task_node(current) != node) { > 1086 cpumask = cpumask_of_node(node); > 1087 if (!cpumask_empty(cpumask)) > 1088 set_cpus_allowed_ptr(current, cpumask); > 1089 } > 1090 #endif > > 1091 if (!khugepaged_alloc_page(gfp, node, cc)) > 1092 return SCAN_ALLOC_HUGE_PAGE_FAIL; > 1093 if (unlikely(mem_cgroup_charge(page_folio(cc->hpage), mm, gfp))) > 1094 return SCAN_CGROUP_CHARGE_FAIL; > 1095 count_memcg_page_event(cc->hpage, THP_COLLAPSE_ALLOC); > 1096 return SCAN_SUCCEED; > 1097 } > 1098 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp >