From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E56C433EF for ; Thu, 9 Jun 2022 23:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20CA06B00BC; Thu, 9 Jun 2022 19:24:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BB646B00BE; Thu, 9 Jun 2022 19:24:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05BE08D0064; Thu, 9 Jun 2022 19:24:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E9EBB6B00BC for ; Thu, 9 Jun 2022 19:24:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id C4F3C8113C for ; Thu, 9 Jun 2022 23:24:10 +0000 (UTC) X-FDA: 79560277860.17.5A409E7 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf18.hostedemail.com (Postfix) with ESMTP id 6FAFA1C005D for ; Thu, 9 Jun 2022 23:24:10 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id y32so40271397lfa.6 for ; Thu, 09 Jun 2022 16:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GEFimUlvbzlYBEwgNMXz/kgCUClpMd8S7embt+3S67k=; b=OXo8cl/f5RR2QG82SuqbtuvrAT3zgfLUCgtl6dE3mbH5MD0MYpSDUra4e0rn6NKAMu XAcXYw8PgvmGYveRHfdiFPFI8TnC5Kbe3d0uC7sgnAPqJNDyb5hGp0bdSh3ubx8IAf8b qffpe6N4DPwkspWnanK4W7sCgyXS5FT3CDa8xK69m7Mk6fQPwX9MaX3G1wDh3txM+fwz UqE5ye3GIN77G9BQoPhHJh02INEKpJdAmvtIfFaoNoNgikAm6LhpCkpq6stYv/qXrkOw b9JwnzB2kpTT3TZ4Uhyd0BPJO7aERXwH1OPNSl+M8NMoaFKcegqOA1aKhEGHuczVLxqz pcmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GEFimUlvbzlYBEwgNMXz/kgCUClpMd8S7embt+3S67k=; b=7/8/oDrPRIlazrPx2qBySA5WdppZkWNTohvmPLE407EPUuGQmEzRbtuZQs1wTreLoC FiG8Eli8Eme7pL6TZlGUfs2/RgeI/b8ZZzZIh8Hwf7GTaZDRQT1p7Sv3RJEAfcSfTcrl KPOXNzLE5azNLSCZy2RPOLkLeQhwIq8NTOuk8tUsb1xIZkWr0Phsa5Oq7OaflNy+2Ipc kTxK9m36b5Nec+9bnQs5G0kuqFlLba7U4cvFFzudiVOShA7B8lnZ0t7y7SoHvfJRvXcb x1lKEVVJeuQVCw1iSWe3pC0j63YdX0S4HKnwZy86a8JLugzRWegDVrJRkAMqzHnbxUeP e7Tg== X-Gm-Message-State: AOAM533DKFw45qg9+AjeVZUcjI60zR+dh7voBu8pT60Pqg2rPM0OnYlx ZLtAz7/V5NhlgYERDoXvFTkqXMqPckaaD8BT9FP6Jg== X-Google-Smtp-Source: ABdhPJxZ9D6scmVmMCKxMCHwRwJCz+W1zYnSffVkRb2dVLKyqKiee8qpE89ys12AioU4EoXa8RrnAqi7/S0lQE/iEP8= X-Received: by 2002:a05:6512:68e:b0:47d:ae64:fcf4 with SMTP id t14-20020a056512068e00b0047dae64fcf4mr730984lfe.685.1654817048572; Thu, 09 Jun 2022 16:24:08 -0700 (PDT) MIME-Version: 1.0 References: <20220606214414.736109-1-shy828301@gmail.com> <20220606214414.736109-4-shy828301@gmail.com> In-Reply-To: <20220606214414.736109-4-shy828301@gmail.com> From: "Zach O'Keefe" Date: Thu, 9 Jun 2022 16:23:31 -0700 Message-ID: Subject: Re: [v3 PATCH 3/7] mm: khugepaged: remove the redundant anon vma check To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, willy@infradead.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654817050; a=rsa-sha256; cv=none; b=L93f5E3tbDRFCIshV25EBa3i5mbCZwGaWvlPtIDQAFOGvJ8NOlElgVc6RTvM2eC5gV3WJM ygndoeJ20fq7DBW4Ho48VRd0y0ZXLObfS/1ZhUFQV3mu8ptuoF9IOBDbBcXlQvX4El1hFk gXNJOvbUpbvKVhww3WulKuE3pEwJeKw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654817050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GEFimUlvbzlYBEwgNMXz/kgCUClpMd8S7embt+3S67k=; b=lPAI9U/mqQT5gZZAX4mYbZHItpD1Htpd50NerntTLmtBUWFXZ95R3QenkrSDJTTNYDE18p y69s1JGUTNut+/EUq8iNIk0lTt+BeTmhfo+xFVn93UHlnubNdeWJiAH9QPtiVmjWabMAvY QOcjwJekp9Dx6yNC9Gzmnt2hSJRTbcA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="OXo8cl/f"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=zokeefe@google.com Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="OXo8cl/f"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Stat-Signature: 3rjbkzs3sdqwtfyiz6xy56c67ufux71n X-Rspamd-Queue-Id: 6FAFA1C005D X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1654817050-508790 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 6, 2022 at 2:44 PM Yang Shi wrote: > > The hugepage_vma_check() already checked it, so remove the redundant > check. > > Signed-off-by: Yang Shi > --- > mm/khugepaged.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index d0f8020164fc..7a5d1c1a1833 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -966,9 +966,6 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > return SCAN_ADDRESS_RANGE; > if (!hugepage_vma_check(vma, vma->vm_flags)) > return SCAN_VMA_CHECK; > - /* Anon VMA expected */ > - if (!vma->anon_vma || !vma_is_anonymous(vma)) > - return SCAN_VMA_CHECK; > return 0; > } > > -- > 2.26.3 > > So, I don't know if this is possible, but I wonder if there is a race here: hugepage_vma_revalidate() is called in the anon path when mmap_lock after dropped + reacquired, and we want to refind / revalidate the vma, since it might have changed. There is the possibility that the memory was unmapped, then remapped as file or shmem. If so, hugepage_vma_check() could return true without actually checking vma->anon_vma || !vma_is_anonymous(vma) - and we probably do want to (re)validate that this is indeed still an anon vma.