From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC405C4332F for ; Tue, 18 Oct 2022 16:52:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B8C56B0072; Tue, 18 Oct 2022 12:52:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3694D6B0075; Tue, 18 Oct 2022 12:52:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27F996B0078; Tue, 18 Oct 2022 12:52:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1CDF26B0072 for ; Tue, 18 Oct 2022 12:52:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EF19AA0423 for ; Tue, 18 Oct 2022 16:52:41 +0000 (UTC) X-FDA: 80034664122.25.42E16B1 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf22.hostedemail.com (Postfix) with ESMTP id A3F9EC0028 for ; Tue, 18 Oct 2022 16:52:41 +0000 (UTC) Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-1322fa1cf6fso17506999fac.6 for ; Tue, 18 Oct 2022 09:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rwBdPI5r3kzHizArL/FPP5doSZttYR9Bkn0L4xCBrSM=; b=iys/K6uKvOxDeCbuYO5eVmUIuITEYSPa7/IWB/WsblniNtnLxNJLB+Ce+Urii47yXt lKPCh6UL8F7xyfF2up0dpqbZTrKA+ZfELVG9y5D+87jsMVAOElH43cLsBIpEjEQ02BDR EKmCBZb0QH1N6cnMJUbI53Q5U/hURWGABoBt+PBXWpZR9GoPuAF1N6tHZFEJO5YWPhuA vvYLIUQKuK8dKPK0ISBdw6BZywOhHBhkFKuOOkzC9kG0ymGntr9CK6Lfa6PgnHq1L4MC CtDo/jwx1VNEimkJU9RgCigrfKVi1UWGj+6ax2YZwa0yYiVMoXdlmG/daCE2iRt+6KdX v3fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rwBdPI5r3kzHizArL/FPP5doSZttYR9Bkn0L4xCBrSM=; b=SDZDU1X+T0BtRR4aZJ+VyABen38jLe4ub2RVt9Foej5v+Ihpuhbc8oogXjDaahFG2m cM09d+G1wjpXYU0sPyu7y9MDLyZLGGY1o3g0rig0+XWogLr1PMWXExIdNgpqmhr22WXD x/vajtSNO0HEUmqHlfKWchD1vz53fTelNmW6VxhFADN6b7HRhWBK82139yV8dolAi3un VeSNxBjc+wqLkCK7hFcunQ8Lh3z0xIBBtvxp5dqMJlYculR1l2WafIdBQTvV7e8T2HaW e4yvJhyT8adHT7UzN49xriXDof3Ghdu/Ni8KS4pJQg5DQL/vRCeB5qZGO4CBobAvFoxa 1E9Q== X-Gm-Message-State: ACrzQf3DWDt0/WukeWUSZkmaFSruZsMbPhRA/NSBngpgs+Puuu010Zeu Rki+uxBUJdrvlExPCb156GSAdZNdvwyv9fP5xvJoBw== X-Google-Smtp-Source: AMsMyM5NmP4DT1WMHDXTf0FNmODlnkEfXlczNoBhfIRE98gxfbbP2/tGujvqfGGHiFRr4rNMSh2UCJ0WBDEdKuuUzuo= X-Received: by 2002:a05:6870:7023:b0:132:538:43e7 with SMTP id u35-20020a056870702300b00132053843e7mr2110178oae.123.1666111960691; Tue, 18 Oct 2022 09:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20221017175523.2048887-1-zokeefe@google.com> <20221017175523.2048887-2-zokeefe@google.com> In-Reply-To: From: "Zach O'Keefe" Date: Tue, 18 Oct 2022 09:52:05 -0700 Message-ID: Subject: Re: [PATCH man-pages 1/4] madvise.2: update THP file/shmem documentation for +5.4 To: Alex Colomar Cc: Yang Shi , linux-mm@kvack.org, linux-man@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666111961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rwBdPI5r3kzHizArL/FPP5doSZttYR9Bkn0L4xCBrSM=; b=ObLAbfk99tUUIhr6hUbRh7zFjphdytohYNWyOUTE1qilVKxq9r/EobXZIHjBgKAOvDFnM/ 1sjBJkrq8cqQMD24/1uCDbcvIaLE8d8bCFhg09J5aewQAEhe2aZCFoltz5J1tJTzOHEbY/ pud+xvEGm3O3D2JqN3C3/c/Hdk18o6Y= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="iys/K6uK"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666111961; a=rsa-sha256; cv=none; b=5H1JLK13T+NOWBiphsdkXCVPPRqrpPCJOz09/LZQWAUq99BHfV1BB9eNKT90DjxCqLmpSg fVNW1BKBLXD8H5/FWzGfsetngDcFb3Tt2JBdrq1/ZHU+Y3ZuL9qP5H54EnrmQJAmFKzeWA o4K1J9TRSVcIgz3F/eYZuNL62F4t6oE= Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="iys/K6uK"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of zokeefe@google.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A3F9EC0028 X-Rspam-User: X-Stat-Signature: 3cjpq6x7fr9znqaj8n4jnkughzo5hpey X-HE-Tag: 1666111961-228695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hey Alex, thanks for taking a look! > > diff --git a/man2/madvise.2 b/man2/madvise.2 > > index 81cce56af..e14e0f7fb 100644 > > --- a/man2/madvise.2 > > +++ b/man2/madvise.2 > > @@ -320,8 +320,6 @@ Enable Transparent Huge Pages (THP) for pages in the range specified by > > .I addr > > and > > .IR length . > > -Currently, Transparent Huge Pages work only with private anonymous pages (see > > -.BR mmap (2)). > > The kernel will regularly scan the areas marked as huge page candidates > > to replace them with huge pages. > > The kernel will also allocate huge pages directly when the region is > > @@ -354,12 +352,45 @@ an access pattern that the developer knows in advance won't risk > > to increase the memory footprint of the application when transparent > > hugepages are enabled. > > .IP > > +.\" commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 > > +Since Linux 5.4, > > +automatic scan of eligible areas and replacement by huge pages works with > > +private anonymous pages (see > > +.BR mmap (2)), > > +shmem-backed pages (including tmpfs (see > > +.BR tmpfs (5)), > > I think here's missing a closing parenthesis. Please check. Maybe you > prefer combining em dashes or commas with parentheses to improve > visually discerning subclauses. Not only a good catch on the parenthesis, but I didn't actually know about the "em dash" previously (though I'm a frequent user of it in spirit). Thank you! With that in-hand, there are few places that could be cleaned up to avoid nested paracentesis. Best, Zach