From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268DCC433EF for ; Tue, 7 Jun 2022 00:25:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EE4D6B0072; Mon, 6 Jun 2022 20:25:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99E866B0073; Mon, 6 Jun 2022 20:25:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83ED76B0074; Mon, 6 Jun 2022 20:25:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6FF3A6B0072 for ; Mon, 6 Jun 2022 20:25:15 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id EC8F0120D7F for ; Tue, 7 Jun 2022 00:25:13 +0000 (UTC) X-FDA: 79549545306.24.829B9C5 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf21.hostedemail.com (Postfix) with ESMTP id 6B11F1C0021 for ; Tue, 7 Jun 2022 00:24:57 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id a2so25843193lfc.2 for ; Mon, 06 Jun 2022 17:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oOMFp3Mwnq8xO2qWnFfF375hpg+Yas781cajmg3zEdA=; b=NsRVLIOU+ARJBIE5B3Afl5h6MPE0qgoKUaCvi9vwe67mXugLXlkJnMZPZ8OnWhGZi3 vIUxghQr7M5cyu6M5QO2RSWuGdJonikq1Cs/5rWJF5CmebopVcFHAe2Fz39S4fBKhDFT 4O8aiBUlWXox4Oov4z+k+MJwFIKELL6MEiGFmhm95yNHm7pCLdwtZ7Wteo4/8ck7tVNj m9K7VycYdGB8i99AB1axdQHOHU5ptclITaixh/j+vJPp4ENpJfTgHmEy4P7u1Ff4/v22 l1ua5To+gTzUUV9+qhns0R8qSglTPe6RtdpmKC96Mjake2xnQwYs+SL/Zx1FoAjySc+I Khbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oOMFp3Mwnq8xO2qWnFfF375hpg+Yas781cajmg3zEdA=; b=Nx5ILmWmIXS8L5RTbUQfviEgCvZdI2o9v4jau1Xrevm7GyJhnZCP2vBOWA+uMmFMDL wf0b4OJi3vmXSQE6JBCobzT2/xItjZBKkUaMVufOsanNhSkoydUrJZmWx8JoKHE6cBuU psXs1HpZtecVwOO1g6H4+fK4U7erwXNPL45MOXmJyV9kVuvveb199bn+liVwjpMQlWKR bGt//VTAMMDogC28e5rV6+5b4mg412YmZPm3tDdLV6bmPOuUslQmXk57WAVOPRWX53P/ F+vEG0LBhFEyOs0e55Us1XsRi1SDa44B9uBn1Z4jEgzAdvUNxl9SbEJQKWFi3735H0lQ Q0xQ== X-Gm-Message-State: AOAM532pQaycVnt5Anhf94x+Yxhp03vsPwqAbXtM9MfA9no8sRPeglV5 nstfDtir9aFJu83w242+I5hoIsbWLio/FqUadeJJDQ== X-Google-Smtp-Source: ABdhPJyNnfmu8Iztb9ciadDYoDKXKD31va4GZ3Z8OISL2ddpUSNg+zAGGmtQoo4hsYaSNgXM7PRdRYgN0sKJTo2nhOQ= X-Received: by 2002:a05:6512:249:b0:479:a3c:de with SMTP id b9-20020a056512024900b004790a3c00demr17378329lfo.128.1654561511763; Mon, 06 Jun 2022 17:25:11 -0700 (PDT) MIME-Version: 1.0 References: <20220604004004.954674-1-zokeefe@google.com> <20220604004004.954674-16-zokeefe@google.com> In-Reply-To: From: "Zach O'Keefe" Date: Mon, 6 Jun 2022 17:24:35 -0700 Message-ID: Subject: Re: [PATCH v6 15/15] tools headers uapi: add MADV_COLLAPSE madvise mode to tools To: Yang Shi Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Zi Yan , Linux MM , Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: orbo3ydxbi3qebtfp7u8iubuxo7ojccb X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NsRVLIOU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6B11F1C0021 X-HE-Tag: 1654561497-530790 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 6, 2022 at 4:58 PM Yang Shi wrote: > > On Fri, Jun 3, 2022 at 5:40 PM Zach O'Keefe wrote: > > > > Tools able to translate MADV_COLLAPSE advice to human readable string: > > > > $ tools/perf/trace/beauty/madvise_behavior.sh > > static const char *madvise_advices[] = { > > [0] = "NORMAL", > > [1] = "RANDOM", > > [2] = "SEQUENTIAL", > > [3] = "WILLNEED", > > [4] = "DONTNEED", > > [8] = "FREE", > > [9] = "REMOVE", > > [10] = "DONTFORK", > > [11] = "DOFORK", > > [12] = "MERGEABLE", > > [13] = "UNMERGEABLE", > > [14] = "HUGEPAGE", > > [15] = "NOHUGEPAGE", > > [16] = "DONTDUMP", > > [17] = "DODUMP", > > [18] = "WIPEONFORK", > > [19] = "KEEPONFORK", > > [20] = "COLD", > > [21] = "PAGEOUT", > > [22] = "POPULATE_READ", > > [23] = "POPULATE_WRITE", > > [24] = "DONTNEED_LOCKED", > > [25] = "COLLAPSE", > > [100] = "HWPOISON", > > [101] = "SOFT_OFFLINE", > > }; > > > > Signed-off-by: Zach O'Keefe > > --- > > tools/include/uapi/asm-generic/mman-common.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/include/uapi/asm-generic/mman-common.h b/tools/include/uapi/asm-generic/mman-common.h > > index 6c1aa92a92e4..6ce1f1ceb432 100644 > > --- a/tools/include/uapi/asm-generic/mman-common.h > > +++ b/tools/include/uapi/asm-generic/mman-common.h > > @@ -77,6 +77,8 @@ > > > > #define MADV_DONTNEED_LOCKED 24 /* like DONTNEED, but drop locked pages too */ > > > > +#define MADV_COLLAPSE 25 /* Synchronous hugepage collapse */ > > I think this patch could be squashed into patch #9? Sure, SGTM. Was just trying to follow what has been done with e.g. MADV_DONTNEED_LOCKED ; but I see no reason to not squash. Done. > > + > > /* compatibility flags */ > > #define MAP_FILE 0 > > > > -- > > 2.36.1.255.ge46751e96f-goog > >