From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56628C47077 for ; Tue, 16 Jan 2024 19:25:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDFE56B0078; Tue, 16 Jan 2024 14:25:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8CAA6B007B; Tue, 16 Jan 2024 14:25:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7B4A6B007D; Tue, 16 Jan 2024 14:25:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9791C6B0078 for ; Tue, 16 Jan 2024 14:25:10 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 617BFC09F2 for ; Tue, 16 Jan 2024 19:25:10 +0000 (UTC) X-FDA: 81686152380.01.F807524 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf04.hostedemail.com (Postfix) with ESMTP id C523F4014A for ; Tue, 16 Jan 2024 19:22:53 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zCXOXIky; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705432973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NBoJHADn5yia5WgZYpyN6Z8v9Xu4OCPM9aFDyk79ezc=; b=Z1k20/EUxHTZuSm8LHe/uPQQJBWefrGKnL7cJvKEaQHh7e7zHjOXupJo1ECdXBq7nwH94f 5jKqL/vjeuDS8MS8E3cE/U0m5197C+SxVcxDdVwdMI2+PfT+ZRLbYVge5uPWebIIE6vHHR JMofThMyrz6jubIbKw6Bt1HSEvrKjho= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zCXOXIky; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705432973; a=rsa-sha256; cv=none; b=NYRrK5yvH+AFH/k9Xe/6RZhX/CJVOT5AohYYYgKWpEkLIBass0jU4Al8RxV6+wNZGIJeNa vK76/z7ZNwfZzqkJkbQXMsgpYHe+ppviP8SGbJFzvqI9l2oToMkVSHT0lkvmGdMjzrTMkH /rbnjCw6kPKCrhEl/CcngPlG2CCKJd0= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5534180f0e9so1879a12.1 for ; Tue, 16 Jan 2024 11:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705432972; x=1706037772; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NBoJHADn5yia5WgZYpyN6Z8v9Xu4OCPM9aFDyk79ezc=; b=zCXOXIkyGeT1gQGg80aK7zwJ51/Jrs1bENrnzdWRC4JG35VkRD1sOEkBtIf3gHnDfo WkfFYd6TIXj1uY8qzNbssxZO5XHzd1y0TbyGCZkUVdLGyyUt0z4tg5C4WsQae1hXCAeM xqMXBtpaLHoIctMwh0FPjdm40b1MyuqGjfiwclNjPsLuq7OzscogEWwdQvrTitx2tGV3 vgVKsBOJtXQYqtX2jA7voAEg4qFAAKyAd9iiwlemcOmELuG5BZFrqYFtRko/AyMtrYjZ 0vSdDfsKqaVV4suxpOH7w9gMD83XSdqOfMoSoWO4uF66CsTZYTb6nw8PSvWGFNuzn76Y YTng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705432972; x=1706037772; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NBoJHADn5yia5WgZYpyN6Z8v9Xu4OCPM9aFDyk79ezc=; b=JkQKEb3bqejX/pMRxHRVjgFy5d8FDeq5Y5WPVjHt6vT5OY1B9lhTAAIBUa75qpcYa7 91my/1bPvvAqKKCmTDqVUUApTZ2NY4d2RdiXTb7KQOoIUHtLx6KBKlSy66LYB9LwJr63 bQxb43pVJFPhN3pufx62h9fFY1n8sxRg4FHmH6HgY1IsybBJbqWuafDoBvU46/0H1H+M N/co+fYu6M96L5SL8Ga/K/tKRKjKgfgpKwFNctR4Vsw065TyGkDUoY9gRekpluOJZ/19 S6saQMnBfUEixKUwv7J6k++wKTIfng0KL2uxdYGQBcwQLvMgti9SQS3U4PZc4kAQmUW9 h7SQ== X-Gm-Message-State: AOJu0YywxSeDf18+j5sB87NlLWRGVnpQa3f9JPlRXjfj5t+MPko+L6DN JM05K8vqNMbTwSkVS5EGtK0953kTalzavktin74kjL4UAfF2 X-Google-Smtp-Source: AGHT+IHjxPzR+jyYslzWJdRx0ShHrQ+cELtQ2GVWJL4y2I1GjvncbTVaousm9xpzKDlssVPkT68QRXbUu7JlrMymDqw= X-Received: by 2002:a05:6402:2287:b0:558:8096:5c2f with SMTP id cw7-20020a056402228700b0055880965c2fmr14455edb.1.1705432971859; Tue, 16 Jan 2024 11:22:51 -0800 (PST) MIME-Version: 1.0 References: <20231221065943.2803551-1-shy828301@gmail.com> <20231221065943.2803551-2-shy828301@gmail.com> <7433e325-9af7-4b8c-888e-07a0debf8e46@intel.com> In-Reply-To: <7433e325-9af7-4b8c-888e-07a0debf8e46@intel.com> From: "Zach O'Keefe" Date: Tue, 16 Jan 2024 11:22:14 -0800 Message-ID: Subject: Re: [PATCH 2/2] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE To: Yin Fengwei Cc: Yang Shi , oliver.sang@intel.com, riel@surriel.com, willy@infradead.org, cl@linux.com, ying.huang@intel.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C523F4014A X-Stat-Signature: a6gri17p11bpj1s5gr6w3cxdtdt7ept8 X-Rspam-User: X-HE-Tag: 1705432973-501839 X-HE-Meta: U2FsdGVkX1+zW93l8Pw5k8aLIOXa1GYvL9i/qm2EwYlNK2jZXAV5BLYpaITOnI9ddQN8QAd3aEweYrWH/wmT8LDx7ahrBn9S/aT9nrnDrmZrFnYh2J36dPSSQZTUoLnsiSNilG5jSRjYlpIU+uOxJpz3nkqB1s4VuM+F3QLp1WBooRcrUmKEU4EcXRLEduHcJfittUsA1yPWlE/hoBeRnBiyGE4sxAbJjDDQm/CfI8r1ULncGZuCPp3LkrQxTGv7ICu7MsgPn53sRwTkP5Tjdh4dwNnnies60T4d66LSk7oXOBETZDPkGpT4+U3bQU9EdY+KL2cXIsS+F4eshdTcgKqlFWF87BrhkdyFgiERIBJZCRK+bXIQNkrBWS900Ofr4jY+BiAQSmeNcQoJQags7vkE0tsJWbzTTqThDxT5450CyrwxSQh4SGTNvAvSr2vUetpzqMo/ZE9UmynLvAjv1o9x+pDeX4AafKxLE6efe7vAUSb4Su6AwgTpdQIX33LklWZPoWVW32dB1to+IV5saucPefeAANByu+Ua88EEU0QaOs/Ak0PT1FH7r27vVxAdTZy8Bdld6/pi6wcuoKm3qIBpl1zrwHo8TNUGudC9oCKTm0OoXPIxcD5BkFJOe8J1raw8EQzLigzYfObevm+DkXh7/H7JKh7oajm6lQHP0bqMXx9UKy8BupVf5FycagWtGk/Nlfv7vU96p4YId34PPixVuzzCtajc5W8si5UNkEOh7XDoICn6B8qpxGUnOkL+PAfG7BZ6/gzvk4vLiwtsYEJiiZM4FBzXF+SABNLjCTvEbcLZpTC0n25TbiLeavx1WOIGawV4g+6KgM+hYwQdOXb1aYgpTDSnz+grdP05aNTykjyMVNWsk7xojslP7bWnYqrP9WeL+D4SzKbQYRFG2VD8C+QrUTeYLU80IY7ryTZYzS5Sl8tevhIlz46Ut1jgSDro7Gz1WvIXY7q07om gE5BPs02 KHqA3bPE8jd8SsJfg3aaQzwGi785gIwOejgQFD8x+ghfgG26JWBVovtgXmWIlZmpMKNpq3KKfar0eJyb2o4a0vaCFoEVuoi5wHJOv9/HHwHb0BQ9M2sKkAnC107fRe/t+8s7LbC651XkuGpOI4L9kb6zqFDQlKvObYKuNIZACCGhj3qrJRgRySD9gtMrNOObZRaKnmFkXD0MrVlAg5QmcJ0TmtUUEbCho0HIINrBLGaWTclZHO7Q+C3HYL5BODWyDxSoop7SXxJ3XjFkZAFcRqabkZarU9V5t/t6IvC/klXXThgrAXbg+H9DObVF2ATBXkjgBJXQyYTUQ9GTma36G/Ic6q93mMl5VcVutvJD69GMAliAzaKMtOzK9fHWBzNGnUqh4dUpq429aYt8YqKUw4ww2Gibl12tT52pIXQaDsWgG0ym/EYtLq96VlABF/z5wu49Eo60LxWpW2GGsbPQ9avQ//Laj4nWiYZfhDAVL4bYO/tEWDxQzJyEQ58FC7sFqItb+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks Yang, Should this be marked for stable? Given how easily it is for pthreads to allocate hugepages w/o this change, it can easily cause memory bloat on larger systems and/or users with high thread counts. I don't think that will be welcomed, and seems odd that just 6.7 should suffer this. Thanks, Zach On Tue, Jan 9, 2024 at 5:36=E2=80=AFPM Yin Fengwei = wrote: > > > > On 2023/12/21 14:59, Yang Shi wrote: > > From: Yang Shi > > > > The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP > > boundaries") incured regression for stress-ng pthread benchmark [1]. > > It is because THP get allocated to pthread's stack area much more possi= ble > > than before. Pthread's stack area is allocated by mmap without VM_GROW= SDOWN > > or VM_GROWSUP flag, so kernel can't tell whether it is a stack area or = not. > > > > The MAP_STACK flag is used to mark the stack area, but it is a no-op on > > Linux. Mapping MAP_STACK to VM_NOHUGEPAGE to prevent from allocating > > THP for such stack area. > > > > With this change the stack area looks like: > > > > fffd18e10000-fffd19610000 rw-p 00000000 00:00 0 > > Size: 8192 kB > > KernelPageSize: 4 kB > > MMUPageSize: 4 kB > > Rss: 12 kB > > Pss: 12 kB > > Pss_Dirty: 12 kB > > Shared_Clean: 0 kB > > Shared_Dirty: 0 kB > > Private_Clean: 0 kB > > Private_Dirty: 12 kB > > Referenced: 12 kB > > Anonymous: 12 kB > > KSM: 0 kB > > LazyFree: 0 kB > > AnonHugePages: 0 kB > > ShmemPmdMapped: 0 kB > > FilePmdMapped: 0 kB > > Shared_Hugetlb: 0 kB > > Private_Hugetlb: 0 kB > > Swap: 0 kB > > SwapPss: 0 kB > > Locked: 0 kB > > THPeligible: 0 > > VmFlags: rd wr mr mw me ac nh > > > > The "nh" flag is set. > > > > [1] https://lore.kernel.org/linux-mm/202312192310.56367035-oliver.sang@= intel.com/ > > > > Reported-by: kernel test robot > > Tested-by: Oliver Sang > > Cc: Yin Fengwei > > Cc: Rik van Riel > > Cc: Matthew Wilcox > > Cc: Christopher Lameter > > Cc: Huang, Ying > > Signed-off-by: Yang Shi > > Reviewed-by: Yin Fengwei > > > --- > > include/linux/mman.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/mman.h b/include/linux/mman.h > > index 40d94411d492..dc7048824be8 100644 > > --- a/include/linux/mman.h > > +++ b/include/linux/mman.h > > @@ -156,6 +156,7 @@ calc_vm_flag_bits(unsigned long flags) > > return _calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) | > > _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | > > _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | > > + _calc_vm_trans(flags, MAP_STACK, VM_NOHUGEPAGE) | > > arch_calc_vm_flag_bits(flags); > > } > > >