From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A18ECC433EF for ; Thu, 9 Jun 2022 17:49:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02BCB8D0030; Thu, 9 Jun 2022 13:49:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECFED8D0033; Thu, 9 Jun 2022 13:49:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7CC78D0030; Thu, 9 Jun 2022 13:49:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C420F8D0030 for ; Thu, 9 Jun 2022 13:49:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 9468C808A5 for ; Thu, 9 Jun 2022 17:49:58 +0000 (UTC) X-FDA: 79559435676.04.FF7706E Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf29.hostedemail.com (Postfix) with ESMTP id 32016120074 for ; Thu, 9 Jun 2022 17:49:57 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id a2so33022586lfg.5 for ; Thu, 09 Jun 2022 10:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m0Vji0EjnoY15nq95wdEHkqVUnYc8nZBcuXoE9qlWJw=; b=iVzTNtmsg/ZMgOKayzXHbuj5O3maSElPPq3+9aHx1Gs5efAUuC3W6u23v37NhjYv+E bMI+HkLmvAoiwBwlj1bTH2GH3JpYiNao3p7O8VC2/B+ApsbZmS39D+w77U5HEbaM6ghk aSQXNQODhEZH2cEz/DfWhLz2LueoiAyFgY7dSYi9vmw2Hw1O4rYUp6L3lUc1otb5Z7GL dPLC8QsP6l5rfWPhDw5N4PN8CR+4M0yzdYBU8RxrpPTN0wnYyrrdWxkASUqCkiBYMKjP VAHPyHqwBAwj1XyqG0MBNFf1fdquqxeZLCgc26bR5rmub8YYP7gFQtAPcb7UDLPwCtJe y/Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m0Vji0EjnoY15nq95wdEHkqVUnYc8nZBcuXoE9qlWJw=; b=3nWxVgro6hRg6mDRS9Qn/DTz101kwd9k/mX3Bab1iBGD5YWY5s2A2yBVwcAR3jy40m UuMKCptgG9fo98nXhNODMchYcQ+PFzf3M5yPom2ZSOUI0ZcrJCJ46+ZM8awBHGvCVLbI ZcTDL1GmNpkp0h+ZjtaByKe992D90g1orCtM8FAs4U+eVnaM6KJ2hXq6EYTI8ujzrJzW XADVvMmSd4Zf3OTOb+bi2vhd3j1rqO5x6r+lq6PBbZedMU/FO1V+G3t8OwTESaztOhae J1qo0PyBHprGnBw4WqUIueMZb575ktbpx9qFG7RlscArJetJI6rF9bnj0Dv2h1NAL6/y eYrQ== X-Gm-Message-State: AOAM533WgHizI0U64QPJqhTqt68zGdoHNgTTgmSU1O2GYpb7fyPZBDy1 YvdvwScpUGRNR690LALbtobXInwWfBPmtDRRE/UJ6A== X-Google-Smtp-Source: ABdhPJz0AJQ7nUsBXpgyPLtEn6TRkv3ozMeeXS6kJlPpnt9pJAzGs+9Ye5AEKMkwVa93Djdixbfko6i9P6ZIMVIGlzs= X-Received: by 2002:a19:6742:0:b0:479:17b7:afa6 with SMTP id e2-20020a196742000000b0047917b7afa6mr21400796lfj.159.1654796996153; Thu, 09 Jun 2022 10:49:56 -0700 (PDT) MIME-Version: 1.0 References: <20220606214414.736109-1-shy828301@gmail.com> <20220606214414.736109-2-shy828301@gmail.com> In-Reply-To: <20220606214414.736109-2-shy828301@gmail.com> From: "Zach O'Keefe" Date: Thu, 9 Jun 2022 10:49:19 -0700 Message-ID: Subject: Re: [v3 PATCH 1/7] mm: khugepaged: check THP flag in hugepage_vma_check() To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, willy@infradead.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654796998; a=rsa-sha256; cv=none; b=iORTr4rGkUDBOzyqhB/0B3YfBvzTV/x6yIsL2zz/6d7hOqQHO8bnUj+85Q6soGT+kEV2wr qUEkd5PsVXRRUJNLyUrSFhDLyDmUWXyvue9ZoWhm1CvocHbAhqFA+scQv+w1WknwB/Bww1 BYlDSYTjiRMr1SPPx285fpRV/bKYloo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654796998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m0Vji0EjnoY15nq95wdEHkqVUnYc8nZBcuXoE9qlWJw=; b=BpqAByG7FvziYcm/FsMMPNVIyA5SYcUf6MXMeoxb8ihMkxulTuHMwUQWicPfr7KCzKmepX B78RKPKr4AZPnDv7dxrXUTWuAR8ci+npLnY80U9blzwRAhthxUmQbSVK1nT75nHDQGSSZq VyB/OZpGUqirECLvwamvVFdMM6xGbgw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iVzTNtms; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=zokeefe@google.com Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iVzTNtms; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Stat-Signature: ntt9krrsom9phonffjjgngmr73ae4453 X-Rspamd-Queue-Id: 32016120074 X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1654796997-225834 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Reviewed-by: Zach O'Keefe On Mon, Jun 6, 2022 at 2:44 PM Yang Shi wrote: > > Currently the THP flag check in hugepage_vma_check() will fallthrough if > the flag is NEVER and VM_HUGEPAGE is set. This is not a problem for now > since all the callers have the flag checked before or can't be invoked if > the flag is NEVER. > > However, the following patch will call hugepage_vma_check() in more > places, for example, page fault, so this flag must be checked in > hugepge_vma_check(). > > Signed-off-by: Yang Shi > --- > mm/khugepaged.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 671ac7800e53..84b9cf4b9be9 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -458,6 +458,9 @@ bool hugepage_vma_check(struct vm_area_struct *vma, > if (shmem_file(vma->vm_file)) > return shmem_huge_enabled(vma); > > + if (!khugepaged_enabled()) > + return false; > + > /* THP settings require madvise. */ > if (!(vm_flags & VM_HUGEPAGE) && !khugepaged_always()) > return false; > -- > 2.26.3 > >