From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14ED2C433EF for ; Mon, 11 Apr 2022 17:42:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2806B0072; Mon, 11 Apr 2022 13:42:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76A676B0073; Mon, 11 Apr 2022 13:42:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BCB06B0074; Mon, 11 Apr 2022 13:42:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 470276B0072 for ; Mon, 11 Apr 2022 13:42:39 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 19D7D81C94 for ; Mon, 11 Apr 2022 17:42:39 +0000 (UTC) X-FDA: 79345318038.13.331B0CC Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf08.hostedemail.com (Postfix) with ESMTP id A3ADD160003 for ; Mon, 11 Apr 2022 17:42:38 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id u19so7867381lff.4 for ; Mon, 11 Apr 2022 10:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=m9ITZUSvYsSeXgKkXbVrkWGHh2zUOrZUnTnFd3Ryw6k=; b=I8VFIhp00kB+ggWvSZC+Zigtn8vz4u+VUGowuP5T2gDnmnVdTv3jlcdiGEGJpT4YG5 AZqaSsW0XFIiBpPeCQ4i6AV30FuBIlbhzEH85k/HMLWvNx3NAa9pR+/KhZoPFfaOstxj 8AXhMjHmKg0W39QQOBXszs5vFmOrjT393atteUvDlv/vUVrcLbUWlIlhrs/FG/iCHAQQ 5RljGO1l5BIGOYDzruI6TRJ5tBK7ylcSsg8XJECv4s4NvPct377gk0d1txs+KRxX8mPY CWaAC/DDYVoPDf7t7rkwcCU1YKvzeO2sb+rIdkyFhlD7tYeH3r7Tv8Zd1Nr2FW7e9nIY mJjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=m9ITZUSvYsSeXgKkXbVrkWGHh2zUOrZUnTnFd3Ryw6k=; b=1ry9Tbt8a3ZCnjE2ybm67whZs8S9Dc0LiIXx9VozUR9S9+kZNh1PxPi3QOzgXOGEAO P6SulPnzeRZuPbWfEopLhvV8zVD2i89P/690Id+Bnct4xuPjhCFo01kQyGyo4CguUBMp zoFQM4Lv+euSpXfZlJhChNQ1p+lgI5pscjIvjn6TKys8fUEJbVyNIIpwH+eyMtNirBYo nv06AulTzrMGBpZx0yBHNaGMErb8yG/FK7ST/GjusVWh2aG80ETkSA3Ak8kYe1vkdPnf NdSBYmEMEJNIkyqdJcPctMgs6ukvM6/mSFPHfQpFwWzicSYeESBlAXiviZkzU2tIm+x2 sVgQ== X-Gm-Message-State: AOAM532+KfKr112jJYtgjoMWF3bXcVEBCA0sJUMirh4NVJ/3vZ1xPj+f 7bfrZjC992aJdbUcvXCMPo3b8te8CKtHIld3E9fqYg== X-Google-Smtp-Source: ABdhPJxhRozQj2gthjN9jZ7rcTVM8P0ha8b631mvo+CQx/FmQrlGK7nzrn9J4SAtqbQU4N469KUXBO7bTZJnRSJIQAQ= X-Received: by 2002:a05:6512:1095:b0:46b:a7a2:8d2b with SMTP id j21-20020a056512109500b0046ba7a28d2bmr3573689lfg.60.1649698956860; Mon, 11 Apr 2022 10:42:36 -0700 (PDT) MIME-Version: 1.0 References: <20220410135445.3897054-7-zokeefe@google.com> <202204110041.MnMCeEi6-lkp@intel.com> In-Reply-To: <202204110041.MnMCeEi6-lkp@intel.com> From: "Zach O'Keefe" Date: Mon, 11 Apr 2022 12:42:00 -0500 Message-ID: Subject: Re: [PATCH 06/12] mm/khugepaged: remove khugepaged prefix from shared collapse functions To: kernel test robot Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A3ADD160003 X-Stat-Signature: w84oxqmmcc8zs1nuqpcc3cuuduhowwkw Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=I8VFIhp0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspam-User: X-HE-Tag: 1649698958-165076 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry about this. Due to a misplaced "#ifdef CONFIG_NUMA". Fixed in "[PATCH 05/12] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse". Fixed now. On Sun, Apr 10, 2022 at 12:06 PM kernel test robot wrote: > > Hi Zach, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on hnaz-mm/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-us= erspace-hugepage-collapse/20220410-215722 > base: https://github.com/hnaz/linux-mm master > config: arc-allyesconfig (https://download.01.org/0day-ci/archive/2022041= 1/202204110041.MnMCeEi6-lkp@intel.com/config) > compiler: arceb-elf-gcc (GCC) 11.2.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/18407cfcbdad0f4e1= 1dfe2e40028687fc64093c5 > git remote add linux-review https://github.com/intel-lab-lkp/linu= x > git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepa= ge-collapse/20220410-215722 > git checkout 18407cfcbdad0f4e11dfe2e40028687fc64093c5 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cro= ss O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > mm/khugepaged.c: In function 'find_pmd_or_thp_or_none': > mm/khugepaged.c:1019:9: warning: ISO C90 forbids mixed declarations an= d code [-Wdeclaration-after-statement] > 1019 | pmd_t pmde; > | ^~~~~ > mm/khugepaged.c: In function 'khugepaged': > mm/khugepaged.c:2355:32: error: initialization of 'struct page * (*)(s= truct collapse_control *, gfp_t, int)' {aka 'struct page * (*)(struct coll= apse_control *, unsigned int, int)'} from incompatible pointer type 'struc= t page * (*)(struct collapse_control *, gfp_t)' {aka 'struct page * (*)(str= uct collapse_control *, unsigned int)'} [-Werror=3Dincompatible-pointer-typ= es] > 2355 | .alloc_hpage =3D &khugepaged_alloc_page, > | ^ > mm/khugepaged.c:2355:32: note: (near initialization for 'cc.alloc_hpag= e') > mm/khugepaged.c: At top level: > mm/khugepaged.c:2469:5: warning: no previous prototype for 'madvise_co= llapse_errno' [-Wmissing-prototypes] > 2469 | int madvise_collapse_errno(enum scan_result r) > | ^~~~~~~~~~~~~~~~~~~~~~ > mm/khugepaged.c:914:12: warning: 'khugepaged_find_target_node' defined= but not used [-Wunused-function] > 914 | static int khugepaged_find_target_node(struct collapse_control= *cc) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/khugepaged.c: In function 'collapse_file': > >> mm/khugepaged.c:863:55: warning: array subscript -2147483648 is below = array bounds of 'int[1]' [-Warray-bounds] > 863 | if (max_value =3D=3D cc->node_load[nid= ]) { > | ~~~~~~~~~~~~~^~~~~ > mm/khugepaged.c:91:13: note: while referencing 'node_load' > 91 | int node_load[MAX_NUMNODES]; > | ^~~~~~~~~ > mm/khugepaged.c: In function 'collapse_huge_page': > >> mm/khugepaged.c:863:55: warning: array subscript -2147483648 is below = array bounds of 'int[1]' [-Warray-bounds] > 863 | if (max_value =3D=3D cc->node_load[nid= ]) { > | ~~~~~~~~~~~~~^~~~~ > mm/khugepaged.c:91:13: note: while referencing 'node_load' > 91 | int node_load[MAX_NUMNODES]; > | ^~~~~~~~~ > cc1: some warnings being treated as errors > > > vim +863 mm/khugepaged.c > > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 847 > 18407cfcbdad0f Zach O'Keefe 2022-04-10 848 static int find_target= _node(struct collapse_control *cc) > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 849 { > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 850 int nid, target_n= ode =3D 0, max_value =3D 0; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 851 > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 852 /* find first nod= e with max normal pages hit */ > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 853 for (nid =3D 0; n= id < MAX_NUMNODES; nid++) > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 854 if (cc->n= ode_load[nid] > max_value) { > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 855 m= ax_value =3D cc->node_load[nid]; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 856 t= arget_node =3D nid; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 857 } > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 858 > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 859 /* do some balanc= e if several nodes have the same hit record */ > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 860 if (target_node <= =3D cc->last_target_node) > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 861 for (nid = =3D cc->last_target_node + 1; nid < MAX_NUMNODES; > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 862 nid+= +) { > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 @863 i= f (max_value =3D=3D cc->node_load[nid]) { > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 864 = target_node =3D nid; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 865 = break; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 866 } > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 867 } > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 868 > b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 869 cc->last_target_n= ode =3D target_node; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 870 return target_nod= e; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 871 } > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 872 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp >