From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7B6C43334 for ; Mon, 6 Jun 2022 16:41:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58C756B0075; Mon, 6 Jun 2022 12:41:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53AB38D0005; Mon, 6 Jun 2022 12:41:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FD6D8D0001; Mon, 6 Jun 2022 12:41:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 307A26B0075 for ; Mon, 6 Jun 2022 12:41:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 03C2C20A00 for ; Mon, 6 Jun 2022 16:40:59 +0000 (UTC) X-FDA: 79548375480.15.8A77E58 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 517394001D for ; Mon, 6 Jun 2022 16:40:55 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id b7so3843298ljr.6 for ; Mon, 06 Jun 2022 09:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7HBqXg4tRUQNBdztfQr93YHdqEttv8d2K+E00E1TwLY=; b=M8NLQpHKNNeUfKGGIK5SjQH3ZOXWfmdol60Du+kiI8/hVzJRJGKykKfygdMwL3l8CI GOGXorAhGi4weZf5YgOaYAI98QrS0sH39k+ZEhe+wI/Gsj1lg8aRoQUGlCZQVDqzkQNH 54xFW84a99Rayi4Z8V04d3++xX0kkKGDkU9lrgX5+ftceiSmQTtQvKaz8ykKWcVoIL8G Nj+DsUdwcMPraEpHkCc3Y50Baqbf0dTJyOtMDue/oeGxV8ibMOJfjEfGGhnwiEAQERa4 qq5Td4BnpaIUonRkoEzMmB4Lbhi7pBluBfwExzqRuBPicVdI9KH6fH6+lXVH3gksxb82 d/rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7HBqXg4tRUQNBdztfQr93YHdqEttv8d2K+E00E1TwLY=; b=qoheRNS7S9eE9FCfqytTBcMB4uEKcNsr63zcVqp4Q3VTcxn9ZSQsmXDB/otbIWQVy3 wbm/Rfvk86cdLEp4GKT7Lcxz4bAZ/m/q+F7ZpQWQmibJm1Dlg/DpKaUxlOGnOa7CIO/K w9apgj5t119NlWlAlhYQbwRy3hMIFHzLJo3/5cNKXB/oGaNoLSmUepLxQAJdeDWJqPL4 KVJygPxazthNf7UzT07kg4M7EH46CrMW0RGMSk5edA7Tk+SLKhmnVylfk8Ngh9ykORgf UvCzoU28OEvd42vj8k1og7SnjzfiFXvKiYKNa1Ez2L1+YVyU9yGBIvXMOZemKZ14g174 N91g== X-Gm-Message-State: AOAM530KRpeZ81tpapZza0kDA8U2QAvntBUbzC8ykcUYDM3MeQRqqnAp 4NIq5gB8mrHaCuNDYjeyYJYl0f2Fy99VyAGyU1cKqQ== X-Google-Smtp-Source: ABdhPJyqd3TpRSvqyp5cCo5gZI147She1g7tPo7FcAdNDkMC7KfJ0XX+KT/rB9HTn2bR+eS8Inm7AJh57t1QV1JL1II= X-Received: by 2002:a2e:9183:0:b0:255:75b7:48ae with SMTP id f3-20020a2e9183000000b0025575b748aemr12030600ljg.466.1654533657346; Mon, 06 Jun 2022 09:40:57 -0700 (PDT) MIME-Version: 1.0 References: <20220604004004.954674-4-zokeefe@google.com> <202206060911.I8rRqGwC-lkp@intel.com> In-Reply-To: <202206060911.I8rRqGwC-lkp@intel.com> From: "Zach O'Keefe" Date: Mon, 6 Jun 2022 09:40:20 -0700 Message-ID: Subject: Re: [PATCH v6 03/15] mm/khugepaged: add struct collapse_control To: kernel test robot Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: mefsrdo6qikttqzh11ztkmfghpd7of8r X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=M8NLQpHK; spf=pass (imf27.hostedemail.com: domain of zokeefe@google.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 517394001D X-HE-Tag: 1654533655-851345 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 5, 2022 at 7:42 PM kernel test robot wrote: > > Hi Zach, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20220606/202206060911.I8rRqGwC-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/d87b6065d6050b89930cca0814921aca7c269286 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220606-012953 > git checkout d87b6065d6050b89930cca0814921aca7c269286 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > mm/khugepaged.c: In function 'khugepaged': > >> mm/khugepaged.c:2284:1: warning: the frame size of 4160 bytes is larger than 2048 bytes [-Wframe-larger-than=] > 2284 | } > | ^ Thanks lkp@intel.com. This is due to config with: CONFIG_FRAME_WARN=2048 CONFIG_NODES_SHIFT=10 Where struct collapse_control has a member int node_load[MAX_NUMNODES], and we stack allocate one. Is this a configuration that needs to be supported? 1024 nodes seems like a lot and I'm not sure if these configs are randomly generated or are reminiscent of real systems. Thanks, Zach > > vim +2284 mm/khugepaged.c > > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2261 > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2262 static int khugepaged(void *none) > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2263 { > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2264 struct mm_slot *mm_slot; > d87b6065d6050b Zach O'Keefe 2022-06-03 2265 struct collapse_control cc = { > d87b6065d6050b Zach O'Keefe 2022-06-03 2266 .last_target_node = NUMA_NO_NODE, > d87b6065d6050b Zach O'Keefe 2022-06-03 2267 }; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2268 > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2269 set_freezable(); > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2270 set_user_nice(current, MAX_NICE); > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2271 > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2272 while (!kthread_should_stop()) { > d87b6065d6050b Zach O'Keefe 2022-06-03 2273 khugepaged_do_scan(&cc); > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2274 khugepaged_wait_work(); > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2275 } > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2276 > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2277 spin_lock(&khugepaged_mm_lock); > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2278 mm_slot = khugepaged_scan.mm_slot; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2279 khugepaged_scan.mm_slot = NULL; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2280 if (mm_slot) > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2281 collect_mm_slot(mm_slot); > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2282 spin_unlock(&khugepaged_mm_lock); > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2283 return 0; > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 @2284 } > b46e756f5e4703 Kirill A. Shutemov 2016-07-26 2285 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp >