From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66139C433F5 for ; Mon, 11 Apr 2022 17:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3B286B0073; Mon, 11 Apr 2022 13:29:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EB9E6B0074; Mon, 11 Apr 2022 13:29:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88BCE6B0075; Mon, 11 Apr 2022 13:29:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 7ADA66B0073 for ; Mon, 11 Apr 2022 13:29:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 988E8A9446 for ; Mon, 11 Apr 2022 17:29:03 +0000 (UTC) X-FDA: 79345283766.25.15FE23A Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf01.hostedemail.com (Postfix) with ESMTP id 2F9AC4000B for ; Mon, 11 Apr 2022 17:29:02 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id b21so27908583lfb.5 for ; Mon, 11 Apr 2022 10:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=r09FjyrPe7ZKVYvyG13yjd5TT8PIAtrjz0XaSmSKn/0=; b=r9tX8ynNW8pZCrvoT+VxadbiudK+CuW0CPSwdQIoTgOiRfprsWO/uOSgr5MMJ+NmJG Q5LOfDkuY/3B0IhHx6sgHvtdE5QewHZdo+ThgBglD18eqv926RWOv4QyLqrgqJeC0K8H 9stBeQfglD//eY0pQnCAe5F1jiXAmt35ZyaAB0Ce9K4PS+x1GtM4Ya3+g+eGOSflpEaC sA03eLoI/J69+X6pQe5EKV7yvJfh/LMqfbwcarIREHJ6AEZFbgmDRjji6nat5mJ76KHT N3OIWki6Zn5fo4JDzzf/beX3bAku+NUQtxZ6hB/lnXpMVAcA5Kj2TMK+2Njhj6HUU0Jk D8HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=r09FjyrPe7ZKVYvyG13yjd5TT8PIAtrjz0XaSmSKn/0=; b=x/MkWyuWjFgdnNAdiFMB9loIY3gIsRtVuil+Rngqs5GVdQGZgLHWaGhw/QesbXxG3l cBbuGGY161boqRtVYZMKWine0oLdqGDJ8vDAhcwcwiBHUaLP4ypzkhb+l5a72Frn2BxA KnnZYaqXfPLKhf5XpaoCzmu8D84qWZerihOQia47uNDCrPd66N4gK6kQE9cvwD57zAbw UpcwnwQTgFup1s+Ek+NJwc3yMl4T7ppGCVCPJ2lKtOOe5Qas83T4NBlCKkzYIrd+pqsx degnIXQxL5gmjxYTUVwWRI0i5QoVEeaRE+OmAz+Pkdlocn8axWWwGxY3LjORhd/2Z2zA iUSA== X-Gm-Message-State: AOAM532LM2zSEpdkPXAhNXV6MzYGBS3TxQal+C1ZO8zDWwQKUQTdCS5A 7PrICsN8rlxM7EvdYU7iXlsW3tHIA2pJjqF71fUk2A== X-Google-Smtp-Source: ABdhPJy9fmcQ/IwXKkPh7ClApkY1eoWIbN2bEQTvg5hZ2Ry9R/2EPdspYNSpzI+lLnrzCkH0rEb/3HDT3KUW2LPjSJ4= X-Received: by 2002:ac2:508b:0:b0:46b:9141:a66f with SMTP id f11-20020ac2508b000000b0046b9141a66fmr8770335lfm.198.1649698141257; Mon, 11 Apr 2022 10:29:01 -0700 (PDT) MIME-Version: 1.0 References: <20220410135445.3897054-4-zokeefe@google.com> <202204110146.7vOFQ9VD-lkp@intel.com> In-Reply-To: <202204110146.7vOFQ9VD-lkp@intel.com> From: "Zach O'Keefe" Date: Mon, 11 Apr 2022 12:28:24 -0500 Message-ID: Subject: Re: [PATCH 03/12] mm/khugepaged: make hugepage allocation context-specific To: kernel test robot Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: dxqh13qfrp1sib3nohjxdkbh4txw47r5 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=r9tX8ynN; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2F9AC4000B X-HE-Tag: 1649698142-327228 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry about this. I thought I had built with !NUMA and TRANSPARENT_HUGEPAGE. Fixed. On Sun, Apr 10, 2022 at 12:48 PM kernel test robot wrote: > > Hi Zach, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on hnaz-mm/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-us= erspace-hugepage-collapse/20220410-215722 > base: https://github.com/hnaz/linux-mm master > config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/202= 20411/202204110146.7vOFQ9VD-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.2.0-19) 11.2.0 > reproduce (this is a W=3D1 build): > # https://github.com/intel-lab-lkp/linux/commit/93731be575c612b28= ee4c7711ebab9e81960f213 > git remote add linux-review https://github.com/intel-lab-lkp/linu= x > git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepa= ge-collapse/20220410-215722 > git checkout 93731be575c612b28ee4c7711ebab9e81960f213 > # save the config file to linux build tree > mkdir build_dir > make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > mm/khugepaged.c: In function 'find_pmd_or_thp_or_none': > mm/khugepaged.c:1006:9: warning: ISO C90 forbids mixed declarations an= d code [-Wdeclaration-after-statement] > 1006 | pmd_t pmde; > | ^~~~~ > mm/khugepaged.c: In function 'khugepaged': > >> mm/khugepaged.c:2339:32: error: initialization of 'struct page * (*)(s= truct collapse_control *, gfp_t, int)' {aka 'struct page * (*)(struct coll= apse_control *, unsigned int, int)'} from incompatible pointer type 'struc= t page * (*)(struct collapse_control *, gfp_t)' {aka 'struct page * (*)(str= uct collapse_control *, unsigned int)'} [-Werror=3Dincompatible-pointer-typ= es] > 2339 | .alloc_hpage =3D &khugepaged_alloc_page, > | ^ > mm/khugepaged.c:2339:32: note: (near initialization for 'cc.alloc_hpag= e') > cc1: some warnings being treated as errors > > > vim +2339 mm/khugepaged.c > > 2333 > 2334 static int khugepaged(void *none) > 2335 { > 2336 struct mm_slot *mm_slot; > 2337 struct collapse_control cc =3D { > 2338 .last_target_node =3D NUMA_NO_NODE, > > 2339 .alloc_hpage =3D &khugepaged_alloc_page, > 2340 }; > 2341 > 2342 set_freezable(); > 2343 set_user_nice(current, MAX_NICE); > 2344 > 2345 while (!kthread_should_stop()) { > 2346 khugepaged_do_scan(&cc); > 2347 khugepaged_wait_work(); > 2348 } > 2349 > 2350 spin_lock(&khugepaged_mm_lock); > 2351 mm_slot =3D khugepaged_scan.mm_slot; > 2352 khugepaged_scan.mm_slot =3D NULL; > 2353 if (mm_slot) > 2354 collect_mm_slot(mm_slot); > 2355 spin_unlock(&khugepaged_mm_lock); > 2356 return 0; > 2357 } > 2358 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp >