From: Bob Liu <lliubbo@gmail.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Hugh Dickins <hughd@google.com>,
akpm@linux-foundation.org, rientjes@google.com,
kamezawa.hiroyu@jp.fujitsu.com, minchan.kim@gmail.com,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] ksm: clean up page_trans_compound_anon_split
Date: Wed, 7 Mar 2012 18:39:12 +0800 [thread overview]
Message-ID: <CAA_GA1d1MSQVcW=pabjVj0+oOyC1OzJmyqry-bNvZ=rDeTp--w@mail.gmail.com> (raw)
In-Reply-To: <20120307002616.GP13462@redhat.com>
Hi Andrea,
On Wed, Mar 7, 2012 at 8:26 AM, Andrea Arcangeli <aarcange@redhat.com> wrote:
> On Wed, Mar 07, 2012 at 01:11:48AM +0100, Andrea Arcangeli wrote:
>> (the function was invoked only on compound pages in the first place).
>
> BTW, most certainly I did at some point this change:
>
> - if (page_trans_compound_anon_split(page))
> + if (PageTransCompound(page) && page_trans_compound_anon_split(page))
>
> Before doing this change, the "cleaned up" version would have been
> broken.
>
I think this patch may still break the origin meaning.
In case PageTransCompound(page) but !PageAnon(head) after this cleanup,
page_trans_compound_anon_split(page) will return 1 instead of 0 which
will cause following
PageAnon check to a compounded page.
So please just ignore this cleanup. Sorry for my noise.
Hugh, Thank you for your review also.
--
Regards,
--Bob
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-07 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:32 Bob Liu
2012-03-01 9:32 ` [PATCH 2/2] ksm: cleanup: introduce ksm_check_mm() Bob Liu
2012-03-01 20:51 ` Andrew Morton
2012-03-02 2:30 ` Bob Liu
2012-03-06 23:42 ` Hugh Dickins
2012-03-06 23:28 ` [PATCH 1/2] ksm: clean up page_trans_compound_anon_split Hugh Dickins
2012-03-07 0:11 ` Andrea Arcangeli
2012-03-07 0:26 ` Andrea Arcangeli
2012-03-07 10:39 ` Bob Liu [this message]
2012-03-07 15:47 ` Andrea Arcangeli
2012-03-07 1:21 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA_GA1d1MSQVcW=pabjVj0+oOyC1OzJmyqry-bNvZ=rDeTp--w@mail.gmail.com' \
--to=lliubbo@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox