linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Bob Liu <lliubbo@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <jweiner@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Larry Woodman <lwoodman@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dave Hansen <dave@sr71.net>, Joe Perches <joe@perches.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Cody P Schafer <cody@linux.vnet.ibm.com>,
	Hugh Dickens <hughd@google.com>,
	Paul Mackerras <paulus@samba.org>, Linux-MM <linux-mm@kvack.org>,
	Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv13 3/4] zswap: add to mm/
Date: Tue, 18 Jun 2013 20:29:22 +0800	[thread overview]
Message-ID: <CAA_GA1cLD7-AW45VkU9Tx9os7Pu5jaW3UkrVaQu--ecQ2x9j_g@mail.gmail.com> (raw)
In-Reply-To: <20130617160200.27bb5d82df09a26adb8efce5@linux-foundation.org>

>
> I'm not sure how representative this is of real workloads, but it does
> look rather fatal for zswap.  The differences are so large, I wonder if
> it's just some silly bug or config issue.
>

In my observation, zswap_pool_pages always close to zswap_stored_pages
in this testing.
I think it means that the fragmentation of zswap is heavy.
Since in idea state number of zswap pool pages should be half of stored pages.

The reason may be this workload is not suitable for compression.
The data of it can't be compressed to a low percent.
It can only compressed to around 70% percent(not exactly but at least
above 50%).

I made a simple patch to limit the fragment of zswap to 70%.
The result can be better but still not positive.
                                         v3.10-rc4                   v3.10-rc4
                               2G-parallio-nozswap     2G-parallio-zswapdefrag
Ops memcachetest-0M              1041.00 (  0.00%)           1058.00 (  1.63%)
Ops memcachetest-198M             973.00 (  0.00%)           1019.00 (  4.73%)
Ops memcachetest-430M             892.00 (  0.00%)            831.00 ( -6.84%)
Ops memcachetest-661M             819.00 (  0.00%)            850.00 (  3.79%)
Ops memcachetest-893M             775.00 (  0.00%)            784.00 (  1.16%)
Ops memcachetest-1125M            764.00 (  0.00%)            766.00 (  0.26%)
Ops memcachetest-1356M            749.00 (  0.00%)            782.00 (  4.41%)
Ops io-duration-0M                  0.00 (  0.00%)              0.00 (  0.00%)
Ops io-duration-198M               21.00 (  0.00%)             28.00 (-33.33%)
Ops io-duration-430M               29.00 (  0.00%)             32.00 (-10.34%)
Ops io-duration-661M               34.00 (  0.00%)             34.00 (  0.00%)
Ops io-duration-893M               36.00 (  0.00%)             42.00 (-16.67%)
Ops io-duration-1125M              43.00 (  0.00%)             47.00 ( -9.30%)
Ops io-duration-1356M              50.00 (  0.00%)             49.00 (  2.00%)
Ops swaptotal-0M               469193.00 (  0.00%)         461146.00 (  1.72%)
Ops swaptotal-198M             496201.00 (  0.00%)         495692.00 (  0.10%)
Ops swaptotal-430M             520400.00 (  0.00%)         520252.00 (  0.03%)
Ops swaptotal-661M             538872.00 (  0.00%)         513541.00 (  4.70%)
Ops swaptotal-893M             522590.00 (  0.00%)         532311.00 ( -1.86%)
Ops swaptotal-1125M            526934.00 (  0.00%)         527089.00 ( -0.03%)
Ops swaptotal-1356M            525241.00 (  0.00%)         525747.00 ( -0.10%)
Ops swapin-0M                  251226.00 (  0.00%)         248426.00 (  1.11%)
Ops swapin-198M                236126.00 (  0.00%)         239031.00 ( -1.23%)
Ops swapin-430M                265193.00 (  0.00%)         266174.00 ( -0.37%)
Ops swapin-661M                280281.00 (  0.00%)         263151.00 (  6.11%)
Ops swapin-893M                263004.00 (  0.00%)         268473.00 ( -2.08%)
Ops swapin-1125M               261962.00 (  0.00%)         264925.00 ( -1.13%)
Ops swapin-1356M               262571.00 (  0.00%)         266695.00 ( -1.57%)
Ops minorfaults-0M             625759.00 (  0.00%)         620448.00 (  0.85%)
Ops minorfaults-198M           769752.00 (  0.00%)         703458.00 (  8.61%)
Ops minorfaults-430M           678590.00 (  0.00%)         686257.00 ( -1.13%)
Ops minorfaults-661M           669308.00 (  0.00%)         668845.00 (  0.07%)
Ops minorfaults-893M           656343.00 (  0.00%)         680286.00 ( -3.65%)
Ops minorfaults-1125M          657954.00 (  0.00%)         655280.00 (  0.41%)
Ops minorfaults-1356M          672035.00 (  0.00%)         659861.00 (  1.81%)
Ops majorfaults-0M              39395.00 (  0.00%)          38828.00 (  1.44%)
Ops majorfaults-198M            38758.00 (  0.00%)          42876.00 (-10.62%)
Ops majorfaults-430M            39819.00 (  0.00%)          38668.00 (  2.89%)
Ops majorfaults-661M            40171.00 (  0.00%)          38443.00 (  4.30%)
Ops majorfaults-893M            37576.00 (  0.00%)          37664.00 ( -0.23%)
Ops majorfaults-1125M           36891.00 (  0.00%)          37527.00 ( -1.72%)
Ops majorfaults-1356M           37123.00 (  0.00%)          37779.00 ( -1.77%)

--
Regards,
--Bob

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-06-18 12:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 20:33 [PATCHv13 0/4] zswap: compressed swap caching Seth Jennings
2013-06-03 20:33 ` [PATCHv13 1/4] debugfs: add get/set for atomic types Seth Jennings
2013-06-03 20:33 ` [PATCHv13 2/4] zbud: add to mm/ Seth Jennings
2013-06-05  6:43   ` Bob Liu
2013-06-05 13:55     ` Seth Jennings
2013-06-03 20:33 ` [PATCHv13 3/4] zswap: " Seth Jennings
2013-06-17  6:20   ` Bob Liu
2013-06-17 23:02     ` Andrew Morton
2013-06-18 11:50       ` Bob Liu
2013-06-18 12:29       ` Bob Liu [this message]
2013-06-19 14:09     ` Seth Jennings
2013-06-19 14:17       ` Bob Liu
2013-06-20  2:37     ` Seth Jennings
2013-06-20  9:42       ` Bob Liu
2013-06-20 14:23         ` Seth Jennings
2013-06-20 14:35           ` Bob Liu
2013-06-21 15:20             ` Dan Magenheimer
2013-06-21 18:33               ` Konrad Rzeszutek Wilk
2013-06-03 20:33 ` [PATCHv13 4/4] zswap: add documentation Seth Jennings
2013-06-13 12:34 ` [PATCHv13 0/4] zswap: compressed swap caching Bob Liu
2013-06-13 19:06   ` Seth Jennings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA_GA1cLD7-AW45VkU9Tx9os7Pu5jaW3UkrVaQu--ecQ2x9j_g@mail.gmail.com \
    --to=lliubbo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=cody@linux.vnet.ibm.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=dave@sr71.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jhopper@us.ibm.com \
    --cc=joe@perches.com \
    --cc=jweiner@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=paulus@samba.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox