From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09B40C83F1A for ; Thu, 17 Jul 2025 17:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42A078D000C; Thu, 17 Jul 2025 13:26:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DA528D0006; Thu, 17 Jul 2025 13:26:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A2388D000C; Thu, 17 Jul 2025 13:26:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1A98E8D0006 for ; Thu, 17 Jul 2025 13:26:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B825712B03A for ; Thu, 17 Jul 2025 17:26:48 +0000 (UTC) X-FDA: 83674436496.01.1C01FA7 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf11.hostedemail.com (Postfix) with ESMTP id D9C0940008 for ; Thu, 17 Jul 2025 17:26:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Jk+BsbrK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of kuniyu@google.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=kuniyu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752773206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vk0vPQ5JFT6HSzwpfrKNRusIzyrzK+g9arxPSMLBTvk=; b=iiHnVBsrEL69qkJyGW+31vD1yFJwMGLcyG+2czmM6Ej4Vp3o/mwZ71M+8lTlgwi8B7ZH+s LCQqLSglsBGRg0z6o3FokAg63pIa0uUjovxNoOJod712z+IRDQkJX+fm0Y0+K3voCPzFV7 u8oQM9GGjYt9x7EblJDCoqg0WfznJzY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752773206; a=rsa-sha256; cv=none; b=2FmO3RytYcpkD2kqpojdrHJr8dlQbjSVWByMYo6SW4cAQYWEIj+YgwSyiu6djc6hK6MuLt 76CbSZ1n5bxpZ4j9KoBUXVrDINGoXRlrhc9i8CD6hljjPuHfnX/y8+y05KPcvWJUDRN9X9 P8X70v/iq/tsPZVl/kV56PyZJaNZswE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Jk+BsbrK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of kuniyu@google.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=kuniyu@google.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-b350704f506so1134725a12.0 for ; Thu, 17 Jul 2025 10:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752773205; x=1753378005; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vk0vPQ5JFT6HSzwpfrKNRusIzyrzK+g9arxPSMLBTvk=; b=Jk+BsbrKklC2nhTq1OmD9YIpeF8niHjSci59C3xLELb3kIH7P/2m9FgEfq+YtgbQAa DPCOsnlm1Qrxuv19ZTRBqtDCEHsKwUDcrezBJVUMQacRBAhXBigzZqBoSQW9qxnfVZc0 D889a6bMyEzGaE0gnmj2PIHFxYSXTnzHnIiCPFcQ5oAKwHEJo4lhbcfTJBNsVqbJm3sC l2IKAXJdMRBvYGX1+QTBkY5G880G/MVdumxt1vbRofq+r21JYSYhWMkQ2nSFg0ZxdHZ+ lIdMaefPqzlIlEWLOpdDDaYl+Ujxup5j9o89Uvpc56f59viaHTuzIkJZJj9TIBbBNd9c sElQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752773205; x=1753378005; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vk0vPQ5JFT6HSzwpfrKNRusIzyrzK+g9arxPSMLBTvk=; b=un2CnGGQS3KfhFx9x4LzA+9u6gsL7e23X9ktzZEwzHIOuZRyl5jAmC2A/CoOcHyPge //iOV3pPwNE4nhh8JZa1TJ26oIvEDeGAW0BYUizMrQiVHLdE4fb7HUuN2y8EvF981EgX gYz3jLAIUUF23sXBZ+T/tVWBVxcyXNbW271OgZnNb3a+mqji2vWlbinOwWe71FqbjLel lmYuoBv9+p7KV68/xjCQwYWGLtREayBpE4ON10CpA84kbEzHvG63JxnQhxfE25z4aDuj oiWDaGbmm4gLK3Y9OyxsE3nif0A84Ud1eDetrtE2jV1d0ozMPuqgES3LX5kt8OOvKkiR UnNQ== X-Forwarded-Encrypted: i=1; AJvYcCXBYuhiNSTNKMknKq8zLGNLdJDjumA/BO6iG0t0CY+zONsAR7aUu8Sg7f260foWUFoI8JgAPR7Wag==@kvack.org X-Gm-Message-State: AOJu0YxA+jYFO7L19gAPzoUtDyritphUi5fvX/V9U5AY1H6gbY8KLNIs 3oh3weMDQtWNZRBlkRxH2LpqjnX//mTGR3PNkAYh2gAKm4n37YoXNPHnvENGKF4RYIIGTqRRtcV jJzaBRSKEprp7JZvHmnAopCvNaY6pMbf2O7Dc9nl3 X-Gm-Gg: ASbGncsBm17vGNb04jYLnyu0hc7pFXGfhnrIB9nOiJDJDWGJ16U1RmXTtSQY10k3xh8 I6ByKO+m69ppGHhS0SZZx6vR78lS8gNUBViHEF7Mhqmj2DXxB3ZfhZD40EEhUWUJmM2oiLc/jIe 6gzCwxcPTsP6wdMFCq8bH6eZw4k301jme+W0oJIqCSANSkfVfp4qcNEwJdu90BFH7qjvFjouYAL h5/O1wPWse/FrzA2rllBH40yCVxQesbVO0sGalO X-Google-Smtp-Source: AGHT+IEDE2E9koWe5tiexoDmWFLniUP7HmR4+lH9wASTsjepELYfnFxnLqTShLNvSMB8kFVLTopS4ykrCW26H+bj/GQ= X-Received: by 2002:a17:90b:5150:b0:311:1617:5bc4 with SMTP id 98e67ed59e1d1-31cc04409aamr708670a91.12.1752773205402; Thu, 17 Jul 2025 10:26:45 -0700 (PDT) MIME-Version: 1.0 References: <20250714143613.42184-1-daniel.sedlak@cdn77.com> <20250714143613.42184-2-daniel.sedlak@cdn77.com> <924f57a8-deaa-4f7d-93ee-4030e2445a01@cdn77.com> In-Reply-To: <924f57a8-deaa-4f7d-93ee-4030e2445a01@cdn77.com> From: Kuniyuki Iwashima Date: Thu, 17 Jul 2025 10:26:33 -0700 X-Gm-Features: Ac12FXxCQNMOK3G4zFCbiVejlOaKSkNVx_IcfAJdZCe4N5jxKb0BeR8m5SOxEPc Message-ID: Subject: Re: [PATCH v2 net-next 1/2] tcp: account for memory pressure signaled by cgroup To: Daniel Sedlak Cc: Shakeel Butt , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Neal Cardwell , David Ahern , Andrew Morton , Yosry Ahmed , linux-mm@kvack.org, netdev@vger.kernel.org, Matyas Hurtik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: dciisayuoxn3wzorrxmf6matw6mi1bdd X-Rspamd-Queue-Id: D9C0940008 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752773206-529451 X-HE-Meta: U2FsdGVkX18LwDbsNLDJab+zt8cUNsVFU6vPBJz+f9hndIHz3ZjSyoMSNRsZs5hBMuXjbDdsAeSYk1SehkrotRJqO2VTTiNFotiRTodrwwtJnRz/MwxJh2LKN9NEJUspUMrE+10T710HPDWAR7pBmiYKP9NXHgjAwogKHoyKLJFWAlYXBSbGszNStDswWXM/uZFpUw02DzPJSwfluLrOZpCY4p9Plvpy6LCiadIweeObhntYnH/5NeafsXJd9xG/PuWREfeqRqgIWsr9XVtbIIxJ0mWO84m35sk3zE22eA62P4EBn1lq3WB7b+Eu7cNFuIwKZom/f4cl94oJdfaFgC3fwl1hb2NGQdjj4HYKkq3I007jrGRI+NPKEYLQXiXr+ZIgqJlV5dOlhDR4toXqKdITDOS/M/8Ap4oW1wgkbWJJrGhpvUi9S6Pl8wvdfaAUn7qoVRnD9mbZ0EXfX0WLTjfx1HfX1L1xoadO27bWN4e11lZNmlczdnrxqlINpSeKYLJFNFG+nAg5Z1PnzkMABnUNyRuQpPxFDzHh37YWSvR0QdFEDDx/0p0T8hxj5BGU6hUHBJiqicVzVDj8shOdDFQ/4I5M6NwQgjC92v0am8fu+0Q3C6OQhQRBzvNSAZLrsTrfakh9Fg7c9PNF8sH7pi+wTTo1FEiJfDMh+2ufd+NmhQZ53XmO5t+V3BajDeCQBdgJIrJEWKCD5Slw9sqkkpEPC3sG9CrVBbVJXRsIU1N9kcPEoUXC6S53MxagVcW7eBsTjBYk+uSHN/rdyixt1N8resGJM9W1HDaPfrdhJS1RdQBM2lpqW4Alxze9Ja2Msxcq6aKLjQKDWTt+oza8NV+fLAfCDvJzbU5ATHUZDJuXJdV5H3SA7djlIHswbGsIlKqxl6mOTgtmP649LZRdqej4tF0VTWwyenHP9wixdR6nDHk38rMaxb/aE4fRVs6wFAVV3vC3SYl9WZpuqy0 tNus4ljx 9zuDbiGIT2xlrTlXA8322fbAjJBEyXdo9UTpY8KmNgrjMpHdTE4XdNRiw8zVvQijJGJ5F2dGQtmyw+9PbcpFzPNIheEj/BxjPmctst+56YAyqNP/y8uZB6wyvZ09TPwKdd5/4zxAJ9IpxGSTv9aekUSyM1hnRf3yyo0zfs6KC99R0r39vCEkedoyqzgJh/Dee7xLQN6qKHKEgH9pUFVlSjxJjIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 8:31=E2=80=AFAM Daniel Sedlak wrote: > > On 7/16/25 8:07 PM, Kuniyuki Iwashima wrote: > >> Incrementing it here will give a very different semantic to this stat > >> compared to LINUX_MIB_TCPMEMORYPRESSURES. Here the increments mean the > >> number of times the kernel check if a given socket is under memcg > >> pressure for a net namespace. Is that what we want? > > > > I'm trying to decouple sk_memcg from the global tcp_memory_allocated > > as you and Wei planned before, and the two accounting already have the > > different semantics from day1 and will keep that, so a new stat having = a > > different semantics would be fine. > > > > But I think per-memcg stat like memory.stat.XXX would be a good fit > > rather than pre-netns because one netns could be shared by multiple > > cgroups and multiple sockets in the same cgroup could be spread across > > multiple netns. > > I can move the counter to memory.stat.XXX in favor of this patch Please do so. Per-netns stats could be confusing in some setup above. Thanks!