From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B20C83F17 for ; Tue, 15 Jul 2025 17:52:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 252A66B0098; Tue, 15 Jul 2025 13:52:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 203166B0099; Tue, 15 Jul 2025 13:52:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB946B009A; Tue, 15 Jul 2025 13:52:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ECC826B0098 for ; Tue, 15 Jul 2025 13:52:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 75E2816012F for ; Tue, 15 Jul 2025 17:52:23 +0000 (UTC) X-FDA: 83667243366.09.03A481F Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf10.hostedemail.com (Postfix) with ESMTP id A1B51C0006 for ; Tue, 15 Jul 2025 17:52:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f2qJfwat; spf=pass (imf10.hostedemail.com: domain of kuniyu@google.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=kuniyu@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752601941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xtI5TVfeROksiTJdvjBPcnmRsk5SRUfXtKYI8vkVdQA=; b=zPLxmLnZKgZwsTyiWwgaxlAunWZjqbo3DSPcaLro6bY1405ruB1oXhV6OzQ5M/ER7aILM9 oS2Kdq+RPpQxqIQfe9i0y4njKyAzrp1VTuBWyurNO2+qFBg9rvbBwbh3x6hWx/ZMyyuiL1 IQRT6DilJRt+J9UNwWbvalt8uO3d47w= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f2qJfwat; spf=pass (imf10.hostedemail.com: domain of kuniyu@google.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=kuniyu@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752601941; a=rsa-sha256; cv=none; b=vUXqet0mfUfP7OXN9RRABKLJQfPu2IEBE1ZWeTUDanutl06RoG6QSFqpeW5TbUyKYYOdOn pUB/Q/6itpZxbtK90QptK9RkyTTp3HYMM96fqTwRaPhzgrYE+7uMUZnopzMG9OPjj/YL9F TpP9fw2Nm8pe0gyPyreFRySJTnG8X+Y= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-7048d8fec46so1816176d6.0 for ; Tue, 15 Jul 2025 10:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752601941; x=1753206741; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xtI5TVfeROksiTJdvjBPcnmRsk5SRUfXtKYI8vkVdQA=; b=f2qJfwatO1AVq4njOkZSRAOSYcrshOKx0v8CMC/8fASEnXPE2IwG84zEE68Q7H9a+5 /iCc1CVwWxtYNos40QrTlbwmHJq0d1OHkrCtvPM5JmlehkgKxLi5Bk9zU0m48Isl6lmX MDSD9mRzh/TNE1W8ZEZgUzEkuG6DL1HpL0gdGDwFvyumlEJPDVqy3TmoBeFBwnMyJ3Vs 8rokjgwzEgnxGOigpgHfkh+mqmwSnmvk6AGZzqn6naldWupnPdUsoymVM8bfTD5g8U40 TxFzV/DT1CFVV/Bv8J4mrjWIyHqrjXRAhG5VsqjRqrPbelPNKPqAATi09fyFq2dzJvKf zsrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752601941; x=1753206741; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xtI5TVfeROksiTJdvjBPcnmRsk5SRUfXtKYI8vkVdQA=; b=iqkORou2shC7O1jVIYG59/mTn01+ViOst54k1ZkP7NTfZhKaq+w5+85USUN5wBE1e8 TAUMuMF1DA1MP6TSoMI+se9L6ofXsi/1URtPzxunZ2aa4moUsjDyeYLA9R1SSguRQEoC ONNBDhzeF9XzIujatT+0s6b2SPF1UWDahayjdhHSgTmPVtRs89q5yDyYNp2GMRakeOzu /V2gXhmhirMFBL/ITqwvsp95YL9lBhD7Yi9Ie+o0qHvl8Ed7ra0xWRSE2J6CsKDuMQa8 mKF9mC9gXXGvfuTsYlqLh0mgJ/fm0EhQJXPfwW7YnqbOb7fuZhGix/zn3qg0di7ozB8s X3Qw== X-Forwarded-Encrypted: i=1; AJvYcCUWh365vRRgVBnxpICgfxmn6Nby16sBsvd5O6UaIZB7PiC6eyg9dyvY4XEDzac17quxFejpy6ffZw==@kvack.org X-Gm-Message-State: AOJu0YwsDtuQW9z58yqsgNNrNZ5v+hRjQKz2hXlGcSjEG/GGBWWW9KEE s7MHmQkB4gydr3OY1ZX2m8aCH2pm5jOGtl3VWM07GWWuCFIBG7vJJBWzAfYqdsYAB8vRUmTyZu4 ErifDPeq1BVOlVmYAIr7qiiLyy1IytnimmakuhuOlIk08mm+HQLOXdRPg3Zsj0w== X-Gm-Gg: ASbGnctQZYCJbtE6/nKueoPmzRbt0+Tmz1BumDPsrSWB6IF5LP9xdvp0DYAKz2xtjb9 2FfVRLLS9RFI/oa9yMQUCv6d3ge9BKeARAo0ZeTUCzlYojc6rdCgo7emisWPxLYI1n+pB6f9pPJ 8E2+d4E1RyicNR/UJ8nUE7WQYHhMbqleq+NKWc9lduomW4hkVrMwbCnpytKotU6fnfS2fcho7cP gq7c0MWzX6C7VSmGYIAVmlCKeUm3nAGse3F7w== X-Google-Smtp-Source: AGHT+IHfCsKu3lQSrTdI7OheuW7x5UPYOpr8U883CkFaQ3jyr7bhPNopPsIhMxRmBOJHKWhV7kmqmZMyKliyM7hEO/U= X-Received: by 2002:a17:90b:4c8c:b0:2fa:42f3:e3e4 with SMTP id 98e67ed59e1d1-31c8f7a0009mr5495202a91.3.1752601624826; Tue, 15 Jul 2025 10:47:04 -0700 (PDT) MIME-Version: 1.0 References: <20250714143613.42184-1-daniel.sedlak@cdn77.com> <20250714143613.42184-3-daniel.sedlak@cdn77.com> <8a7cea99-0ab5-4dba-bc89-62d4819531eb@cdn77.com> In-Reply-To: From: Kuniyuki Iwashima Date: Tue, 15 Jul 2025 10:46:53 -0700 X-Gm-Features: Ac12FXwB4PCIKnOdMppbdcFbf-MhYkOWAqn6Sbv43aI2tWEjulnADX2xLPhXtBU Message-ID: Subject: Re: [PATCH v2 net-next 2/2] mm/vmpressure: add tracepoint for socket pressure detection To: Daniel Sedlak Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Neal Cardwell , David Ahern , Andrew Morton , Shakeel Butt , Yosry Ahmed , linux-mm@kvack.org, netdev@vger.kernel.org, Matyas Hurtik , Daniel Sedlak Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: A1B51C0006 X-Rspamd-Server: rspam06 X-Stat-Signature: u96uxfceim7zrdpz4z3udy8teimennx8 X-HE-Tag: 1752601941-164091 X-HE-Meta: U2FsdGVkX19gOExbC7qG5q3VIzsOgJ/rqoE9fYB/q99i0ZcIMJHX24wNemv23aE0sK/FkQjhe2OnCfZLjOuGlLL388rTNQxSdAd1Bsv2U7efbEZDcqVzLDYqokvwnyZTamihF0d1uHjlhzBZLbdeyDVBpytU8ybRm4KzoqgbsiGlS4P/chNuGaxuf1Fqp0+o3q+yKLyeBscvYLUDo3TknHNQTtiZFUiDdJaIGR7FQj6Hk25PCkvFDXqd6gOP0/vAzrLwQ6IA89HnuQqoUKoVzsjHCX9YQGxI9cPw7d82MKLFHmfuITFLKY7r7UMiMFZUzwVYN8WSSI19dZ9a4Odjest+iopv0Py/Iq/F6vCB4Bvn/I+RXrGBbM0F9QTtbeEMYvO2A8Bt9Tizsps57bnlL0SYe3mJsSjur7QjKHg1yGHbcFB42KJBnnACFRTFYpWlmlrvd6wJ3LiYkBdpx8AazTTwO6n1i3RgdiXvv4t8ripRJjMtgfcdCIJTq171HcXWmDpf+Ac2XN3aVUSnU/aWUxlJz4MLf3pwWWmLW9GCoSgp0D1gtKGQ8qp7Q3Xk6jIIcy4SM3/X7Pc8sFv5+hvG12uNVd32QRjMyudjy+44QOEb8XNx7wemzcgnYuV77SDoP3Lg6xPha/wtEj05dGLQ5Tux1v172Fl6+JZhYREp/MOtoInFP/fuja9hGcoyN/FLZfewj6eHE1wRPIoAUtepvg0vKgR0oj4v0ebScSY9t318U2IY+ekZWEDYGf9NNq/Wv6sYBioX4oiu9nfDHkuR8OoEDOE/za63Cdtimn+KcETt+NROShQcpvaF0obB9mCNVdoA/VcyYKyKkTatVwsiLCS6t4l7n/jSrjBUtA9MVXbFaP1VsTAUcfWOgQOA5GvMv3ZzQEK/DAeTEGXUdgWEXLfbAUFRVB8rxnlFVP9uuAq8FLC3OIY4TqG3cRJ19uxsDMmJLPH1v0LKx8WT4fP 3EYeyGlY x/IeFz9oFjKTu9NUWHvphEofuOXgeEeGeiy2O2zFqzMLRErYY/FxCjftnwRYjBMDHzzRGilbMOLrkkoDYIhGArKBYE/gQ23z0Q+uJoCGpTMuTGEf/ZbTefxzKCUI2OKAR8MNc4Zk9MMMVi52PSSBqh8LNQ3Ypq/UIzhlA+AeJPrls97z152RJ4ChKrZbVICfx81iJSuXp4SJLOlri+dgH3Kup6DR40Y4YWdGqX06wsmVJeZPsv5kaqhloeCU63ovw/tu/fwFZy329pMxlv+dSRE6mcnGesxWRT4PnApxpG9szO+zetbtXDvjPIK98pBd71vRI+8tKtOO2oXfFd/KC3Wekn4g9qlcmQHJwKyT5dhMXkJg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 10:17=E2=80=AFAM Kuniyuki Iwashima wrote: > > On Tue, Jul 15, 2025 at 12:01=E2=80=AFAM Daniel Sedlak wrote: > > > > Hi Kuniyuki, > > > > On 7/14/25 8:02 PM, Kuniyuki Iwashima wrote: > > >> +TRACE_EVENT(memcg_socket_under_pressure, > > >> + > > >> + TP_PROTO(const struct mem_cgroup *memcg, unsigned long scann= ed, > > >> + unsigned long reclaimed), > > >> + > > >> + TP_ARGS(memcg, scanned, reclaimed), > > >> + > > >> + TP_STRUCT__entry( > > >> + __field(u64, id) > > >> + __field(unsigned long, scanned) > > >> + __field(unsigned long, reclaimed) > > >> + ), > > >> + > > >> + TP_fast_assign( > > >> + __entry->id =3D cgroup_id(memcg->css.cgroup); > > >> + __entry->scanned =3D scanned; > > >> + __entry->reclaimed =3D reclaimed; > > >> + ), > > >> + > > >> + TP_printk("memcg_id=3D%llu scanned=3D%lu reclaimed=3D%lu", > > >> + __entry->id, > > > > > > Maybe a noob question: How can we translate the memcg ID > > > to the /sys/fs/cgroup/... path ? > > > > IMO this should be really named `cgroup_id` instead of `memcg_id`, but > > we kept the latter to keep consistency with the rest of the file. > > > > To find cgroup path you can use: > > - find /sys/fs/cgroup/ -inum `memcg_id`, and it will print "path" to th= e > > affected cgroup. > > - or you can use bpftrace tracepoint hooks and there is a helper > > function [1]. > > Thanks, this is good to know and worth in the commit message. > > > > > Or we can put the cgroup_path to the tracepoint instead of that ID, but > > I feel it can be too much overhead, the paths can be pretty long. > > Agree, the ID is good enough given we can find the cgroup by oneliner. > > > > > Link: https://bpftrace.org/docs/latest#functions-cgroup_path [1] > > > It would be nice to place this patch first and the description of > > > patch 2 has how to use the new stat with this tracepoint. > > > > Sure, can do that. However, I am unsure how a good idea is to > > cross-reference commits, since each may go through a different tree > > because each commit is for a different subsystem. They would have to go > > through one tree, right? > > Right. Sorry, I meant to say the two patches don't need to go along to a single tree and you can post them separately as each change is independent. > Probably you can just assume both patches will be merged > and post the tracepoint patch to mm ML first and then add its > lore.kernel.org link and howto in the stat patch and post it to netdev ML= .