From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8254C83F1B for ; Wed, 16 Jul 2025 23:58:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E2A8D0006; Wed, 16 Jul 2025 19:58:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A8468D0001; Wed, 16 Jul 2025 19:58:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 297208D0006; Wed, 16 Jul 2025 19:58:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 169028D0001 for ; Wed, 16 Jul 2025 19:58:45 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8D94D1101E8 for ; Wed, 16 Jul 2025 23:58:44 +0000 (UTC) X-FDA: 83671795368.26.57134D7 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 9EBB01A000A for ; Wed, 16 Jul 2025 23:58:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="vrwq/ujt"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of kuniyu@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=kuniyu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752710322; a=rsa-sha256; cv=none; b=qhJWleeVYcA1LDsA/UKntHSCtuPzb/2S6ixgjhSUvqL/RDQ4MwQevYbeK0edEuoGQDvLD5 d01i6GVTBjZsXiP1pj7V60yT/w4PPOu8n0MeSLc2Cv1D/BUGd8mS/uAzONX0PtSvX3yAPp SjemNMS//aiYA8ClOrVQAMRV2tvdhf0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="vrwq/ujt"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of kuniyu@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=kuniyu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752710322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A73nyLMFTJDdfDDhuJ3iRT0oXpKEtxIgXesg0tqjQtc=; b=AClAK1a319zERtRSbLrLB1F4g0THYefqqaHZahaOdY0rjhjtTf2s3K2+/865we0Eays58c EENWEHkzVMmIRgQt3TwmQzr1dr930MOhpSLFUV4UAcb7ReVws3QF2MgFOAqOzDpMiFZam6 ggKCrQrC2ArJfzTBafX1sfm/XRAff0s= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-23c703c471dso15851835ad.0 for ; Wed, 16 Jul 2025 16:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752710321; x=1753315121; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A73nyLMFTJDdfDDhuJ3iRT0oXpKEtxIgXesg0tqjQtc=; b=vrwq/ujtRNwdT+zux/XghZVrUdEQqgcONblHb5U5IZCEh2bry+vj80OsizLhvb1rcL 3F7sNDmrloGcS/Brq2YTfen6oTFTYed+X1K6T6Svqw7jYz/JDxvWY6z2BgsBClzZVZcD HOYF7s+NV5sD76F1RVOA6bN9aMQBSgk6vmgfHGiBgpDesMiY5/3hrzamBd9cUSpjkgPl 9UHWfesHTmGZ4Lqbq6kindzpenwoPLKVapQRNsoUAoLvPPsJqrv1JRFHBTswsyRVFgRI /0W1IgYs088LQFd0r98KGIyXfRmsKGh2d0hwqQJNAsXND69oirlkPhkN2zvSAiGeg+Pm 3IYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752710321; x=1753315121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A73nyLMFTJDdfDDhuJ3iRT0oXpKEtxIgXesg0tqjQtc=; b=cdztubjpALp/kOOTWzNagg7mxKg/pxmeDOC2NlVDKBtTHY62+E0gp6Kp1HgE8rCH+g ARkk+s1joqOwX6tkwwQbvgVkJv1pTZlNTCdV+8MVHHeCdI58YiANY4VtIM0nslo7Lxot HZ7JldMMa6KZL9jjtyxKUA6RCgcqegLFzNZTiBDJ5JJf74fscbY345s94qcsx5Cnjl5w ouXE6PfVGyxXmmz8dpOMCk164CRn2VItMcC3uPxkJ1sPVspbR9GOaMjCc6cJLQLLRpld yPKEgEKrGuvpuqXJ7ogA4NYqRWHBij5bqan77inNZVmcTwjBIGeepMHqU7/UG5QS4/oK SdyA== X-Forwarded-Encrypted: i=1; AJvYcCVttlNM6BP+opg8ZnVr4M9Pu5Eu9yCmkOZqaSqsPhXfGKspnqFgvFsRqMdHfhMGQsVrNeIWbJxB4A==@kvack.org X-Gm-Message-State: AOJu0YzDuoUf11PJChB6GHibEPBVEaXP+OkURPnn6rF8XClvtxCMJMJs Yrpnc9g0lrxasRqRLRFQR3P1A8KpRG6f4cr9wIJr+6urtcsZBHmLQnSPlOo9znUp0CgXgdAFh1x JsQw1erL/qEqoq0V2Je3P1jJ2DK8VOeAJAt7J24xK X-Gm-Gg: ASbGncuA5jQGFDwtHprImdoI0FrAMcq2zooi3Ehl0pMYqav1lpqIwDyUCMs9b3nBt4W sM1Z3rPqhM9lbNVqcKouiuIwdUD8MIsR/fEu4aq1FDTlYozdGPEsR9AFLVIYwdVWXJfunXzKaoU dqzZumnGjwQO61Pjx7EFgdcu1x6h8EwBAVkPp1MWLOdobqk67atl+5dtp+T38KzoeFoT5djuh6d h3HQAhDNTZRLBbmMPq12xFN1ATJqxdiloBKqRQ2rZRQpURo X-Google-Smtp-Source: AGHT+IGR3HIdXPLlP3XmM0vgWtUk/Uxm3peFwH9lCj5k4ZHSe6482PE7hHVBOPOLQgPSW92MvcRJCdWdHxqnVntCwrM= X-Received: by 2002:a17:903:7cf:b0:234:9fe1:8fc6 with SMTP id d9443c01a7336-23e2f4a4dd4mr12011085ad.18.1752710321267; Wed, 16 Jul 2025 16:58:41 -0700 (PDT) MIME-Version: 1.0 References: <20250716042925.106239-1-kuniyu@google.com> <20250716154315.b49d3af2cd9294faea24d6c2@linux-foundation.org> <20250716165220.4fe0019e7ecfcf73db13b334@linux-foundation.org> In-Reply-To: <20250716165220.4fe0019e7ecfcf73db13b334@linux-foundation.org> From: Kuniyuki Iwashima Date: Wed, 16 Jul 2025 16:58:29 -0700 X-Gm-Features: Ac12FXzbeh53tfYvtuw3GeLxY81t_lHNXMXhD_r_8Fp4S-0eLcS0mkt0VUH7Ej0 Message-ID: Subject: Re: [PATCH] memcg: Keep socket_pressure fresh on 32-bit kernel. To: Andrew Morton Cc: Johannes Weiner , "David S. Miller" , Vladimir Davydov , Kuniyuki Iwashima , linux-mm@kvack.org, Neal Cardwell Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9EBB01A000A X-Stat-Signature: sqa394b17jx837djem9k8qehkjded4qj X-Rspam-User: X-HE-Tag: 1752710322-64324 X-HE-Meta: U2FsdGVkX19EsdD+ZbrCpjXD/wbdN31yKild45l6TN2kgA2R9TR5VYJVvhAzopZVeyVxRO8pqoZOFhFymY3qV0TbRcgH7OAPLfZQ26aVnxdzpdmTTDn7Go0z3bxFvLz9IconAHDL0N8bbMgR6QNoZ29VmZ/h0JSLLM0m9Z8H14gzVvoRSrd+7c8Saz2qkakIYgv6KJSh5CsiQyH8u8FUTL+34ZqS572qaP2xgBl3+piOUfpl0OvP0B0BnAt01m/NPFHIObDmKRU8SAGK7pJMLXMjh0yQx7tv8bAl7tNEdt55nF0ySh9aK0oTBAcRqQK5OoDWPOurWXrTiz0YLdXt3HFmjD0BLH1tDIRVtL1QoSjV/wsvNepYNcZ1kNQeD0gkbAuCCB5ObymCVZvk/MszG0yvnSW6sV5iHtEDw6AiGVGY1k7Iom2Oab395PDUuDuczeXS9ot8QKoKPSfiGWxCzY5tjOCASKlZqvJT9qq1CrpMKT8XPTozurY60SNVhvGFLdJ5Vduwuk4365pZziJAqNhpX8PGYzP/otiTOw/n7+LtJcYU0LTcLJN+5fDnI8UbkV1XMuwh2JqdA2davyg2ntuQjA/MjlvB5Dleo6hCXis9jTr6xe1J/wuq3rNtQUvgZN4Dcvrgd6ZUvNFdyZ2ljZ/DNYnwNh+5BOiL5YoMSqx+qiWvQG91AsjqUWQE67yLkBpkbhnL+9C2vbng/2ip/s2a+USV0pTxNSISyj+1ZngwAnjaYR+94oqyPBa3dX2BgQTkxkoR1XO4U2L1H+WwikhCZkpYko4GjCMpcTZE1eF5ymnNo6u4hW849R407l6EjDYw8VqEFMyqcTdnDj1adipSkdJY40Q1aRJw8kvoIB4St1loMItwx+YKr0eQahOBhy6bFG5pLAowt0fwWy9xNB43qOu8ht6W2nkHnChTNlIbHeKMSaMYxCyHvT0Mlk3HWmbkkYJIlfppvSRCMn/ OMHl0/TA mTPt8N1+bWFAPk+5B7P4IjXxImCJUMUxsJoGN1sygN23jBhhq/C6BGRgI4b5VQ87veoKx1c+VMesI4So1GBmSZWFXMTWDg2K/MhWNoB3SV0YX0bVLpR7yXZ5qmtwhW5lqvS/ESdZoCIvH+M1IMUxYVrjBLRQgvTsPIpCwUcHRYPY7goN663UMoWmutOyWBkVlEDBjRFIkl7aaBm8GoPs22/iqguXOydGZnicySmbROyxOceBQ2M3PxaNGiY+a2Um197dXga53vdKQMoCTAUf0WJyQo3cnZ6OxMnf4mZdFOEQedHuhBhWuWAUUWQxGCa+4hL/fZNgmQpaSzFP5OAZ4/ThpaIdsf0OMQcCEfKntAjUx5T/K/4umdz1ZxQMuIxEkmUgUJaThFNbIz6Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 4:52=E2=80=AFPM Andrew Morton wrote: > > On Wed, 16 Jul 2025 16:13:54 -0700 Kuniyuki Iwashima = wrote: > > > > > Thus, we need to update socket_pressure to a recent timestamp > > > > periodically on 32-bit kernel. > > > > > > > > Let's do that every 24 hours, with a variation of about 0 to 4 hour= s. > > > > > > Can't we simply convert ->socket_preesure to a 64-bit type? > > > timespec64/time64_t/etc? > > > > I think it's doable with get_jiffies_64() & time_before64(). > > > > My thought was a delayed work would be better than adding > > two seqlock in the networking fast path. > > Is it on a very fast path? mem_cgroup_under_socket_pressure() itself > doesn't look very fastpath-friendly and seqcounts are fast. Bearing in > mind that this affects 32-bit machines only. > > If a get_jiffies_64() call is demonstrated to be a performance issue > then perhaps there's something sneaky we can do along the lines of > reading jiffies_64 directly then falling back to get_jiffies_64() in > the rare something-went-wrong path. Haven't thought about it :) > > Dunno, the proposed patch just feels like overkill for a silly > 32/66-bit issue? Fair enough, I'll make it u64 in v2. Thank you!