From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76576C4345F for ; Sun, 28 Apr 2024 12:52:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F40E46B0083; Sun, 28 Apr 2024 08:52:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF2806B0088; Sun, 28 Apr 2024 08:52:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D914E6B0089; Sun, 28 Apr 2024 08:52:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BB7906B0083 for ; Sun, 28 Apr 2024 08:52:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 71D381C143B for ; Sun, 28 Apr 2024 12:52:57 +0000 (UTC) X-FDA: 82058930394.13.DAA4632 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf06.hostedemail.com (Postfix) with ESMTP id 9DB27180003 for ; Sun, 28 Apr 2024 12:52:55 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VXmDoGM4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of skseofh@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=skseofh@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714308775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e1t+DAm/UcjgWEj5zteVdEHb88i/sXfM9ZVZmE5sY4A=; b=PAaqQgfYWetc1qEufWxL1NYK1mW73IG3KxuwFp/JnUNhCoIJMVffgFBEaH9ItnTQfDrTeq fO9omOVH0KIxPAtpFpS9uCjPIxCPvweRw/P/2PulOapb+FB/vkipJuA1YPvU7ZtVke/Sf8 GY6Bhn0yXVS+jc7Anl8biARaBriaSQA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VXmDoGM4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of skseofh@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=skseofh@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714308775; a=rsa-sha256; cv=none; b=ZK/rq/yXOYQwpk0sGZtCeT3ckgOUD+A2FyH98arW3/Hd1Qq5rg616zvQNpPR8xm7RcpFwL +jnAjlQeqDQ1zgodbLPACxH0MBogbVtdK/MmnBg+Fd3fXhQe4VE7H12Z6JPp0ZCSy3abCp biLjSNjulS4Sh6CSmm27TlD3dAYNNDc= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-34c8f393195so1112437f8f.0 for ; Sun, 28 Apr 2024 05:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714308774; x=1714913574; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e1t+DAm/UcjgWEj5zteVdEHb88i/sXfM9ZVZmE5sY4A=; b=VXmDoGM4BJrfsVNJzY5LcfJ+EeqhMjfX4EfQnmmR+eT9XMKFMbCN5ZqcSoTrb8XrGc 2MQS/MgcT/ELTB7hIdKAlKQbGmLDemVQYTI46mBWD5iXg03YME8RAbk5jkczo20MeaIi qcpt3dFgUUiYzU2PMt7DrilU36eDJbf9VI19LPcgvdgYRtnu93dati/u8qeWHbDimNDh C+fSxkZ1Hz5wcesC5XSlPOq5gpl/B9IrGMiKa1fZfPA37TkdnIuDkpNhZ8VC5Nt0nEhF 4enETj9iSl2bYFIwSIb31yfcTpBZEdgmcszdws6sXzJRrZQbg6Q+zFODwgn2vak/5MN3 mNRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714308774; x=1714913574; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e1t+DAm/UcjgWEj5zteVdEHb88i/sXfM9ZVZmE5sY4A=; b=NalliqY1Yg5HDbY8iXpZRI/OM5YCqd02HkA8YjcTwNqH/fkEJVj0jIysQ0L8abzNiT csHcSp5+7HqEqs6bhcC8bYA4AegQRtNXsUg+MCV0lXIDTND3yp4WAtQB7BIopDDPEstt YDRHZYLnHq2jYElCPNm5M5sPmG3PeBMtxNXAJNdSnOyRAeDt2zdfekLO1q/cc7BzB3qO FFOa4NGiHbea5jfuht336X+gdHob+lRRM9NQICa6y4jhkytBzToXhyrke4+Z50ckAaxg OVuHVm400RiuoR+Vp8MGQfnywt30/F+jNknkZnOtLFXWtKZHx7xzYuBS1MzB7Nx4jTQv BXTQ== X-Forwarded-Encrypted: i=1; AJvYcCWRksSQGHBCx9O2cEW02cer9PLM/aEh4IJiyytGAOvVo1GcZLHEgonAPOT9qpfWSBig8m3sR+cEylAFHEnP4iLsT9s= X-Gm-Message-State: AOJu0Yx+GUw5PjZW08e6E76+C4v3iN/SpVR7mVUuSq4+qiVYbA63ag9Q VGLTa7tXqUs5BtG/Cho+15X8xkG+omjSFNF8dXhHSSMaqWSLPB2uyLrNOi4J8TRJFebe5fLZRx9 5ThdL8XdrRqrNr74PEOiRXcDChLE= X-Google-Smtp-Source: AGHT+IFk4s2m4By0fwDK8jV6cj9RlLs4N1Ac1W9zBcBWrStk7pz9SjLguNE0AHswsQkf8U1r+OrAzsbOP41G9LsIR6c= X-Received: by 2002:adf:f8d0:0:b0:346:4d41:8d5a with SMTP id f16-20020adff8d0000000b003464d418d5amr5892887wrq.56.1714308773903; Sun, 28 Apr 2024 05:52:53 -0700 (PDT) MIME-Version: 1.0 References: <20240416120635.361838-2-skseofh@gmail.com> In-Reply-To: From: DaeRo Lee Date: Sun, 28 Apr 2024 21:52:42 +0900 Message-ID: Subject: Re: [PATCH v2] memblock: add no-map alloc functions To: Mike Rapoport Cc: robh@kernel.org, saravanak@google.com, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daero Lee Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9DB27180003 X-Stat-Signature: 13ij3456yrjfxzke3b33o43s64bxdmwf X-HE-Tag: 1714308775-182076 X-HE-Meta: U2FsdGVkX18CgEkICazgcQZzBD0z3mY2Za14ASTMu2Lqp6+Uj0pF/V9RgymoariH6b+GhT0DXRDD5IG/kgGx7Ib0X+NXdIxdFLkJvVfr1dglyRVmOHmzRQDu6UluQtoX2jb6WsurTvqY5KVFVyFpYGxfjSp2BitCcnEXWnzUYunyUBBm3m64byrAF37FUo9TmWBHPcvELRyIwK3NCumaznIaGmgJ0uARYf0HkRtgfd3XcgVRmpFm/L78M/0OVSVBQUPP+7b4LdlNBNSocQyVf+oAwQ3TDXlVW363n17vw4jUbQ65wKg8Ek4+9bvGfSuFH9ECPPBTDsIQAtPrz1AWpySR6XkPpS8S5BEFzsmeRUhmqUo1yd7UkOU0idrWDpBCzy03ej6x40wewyFDU67L2I2Nr75FmSrItl+PVd+Cd2I8Zw6coitO3gsFK09ps23OQLLFKnrtHFTe0Ervu5JuJMBEOmOaH5EFI4DY5zvkrNTHcyLt0F6aDUjbQj06syUaKO/musM8DGBy3J4FS3UU3JbNv+PUbRLMuzceQcmVzPN0hnPpw+BX2nzZ0eWjfLWe4xD89ESChgoJI9sgOo+facWXaQoJW3TIv4TXcvu1Wk5vbsiKLfS/VeOnikYbxIvvjFLsrddnCY+chqwB0K3IF1suLlTzdhd3ayT3ijpPI8/OJqI7F9iYfMR0ReaUnINk/s9wtL1Shf6ZY1x5b5bUKwCZhLjpLmcPXb0/OfKGuaJZrBe1mKH7dWmhO1NMWOlMCI+FYZPvQC3TUb02phzicHeXPIEk/j7UPOjs9VF/QE5qSDBw6YeqIEsZRXK/GrJbGy8ZUbatBpHAyuEYuMXUvOJrPMdrRaIGt/bbKPIfRPAlElzv3H9CdrxSB0SKlMgSAWFU1ZTZaa0gYI1WvfzIHRwaZfZyhtdho/UbEiBa4CUVI1Y5JtlPPbeaEgRKEID8I3EuPoHwUAUflZkO1A5 bT4UMGqv 86LHe4b7OvOdRFvomY0MHwlHPTJQEhKIh/tKZtZp1ktrVgb5728HnwJo+i5j43PPHcEEsiaMjxO3Z/DSFYlAUmzj1/rmxLko7zE6KaJEJbadRBB4lW2B49v1Mj3eOPWHZ/fFJb0AKGAul19tYsZyi3ieJ1hAJ4CXc4ZCJjPMNFHe85Texs36SDo1ljMxWbPHDRlaEgU+wRRCPejcKEbdV/Tlg7EEYi38JiRcslyzMwLX7FevlurVgSospm3sPXEFCGNBh+ml7lWwikda2cdpHmGx76c8m4iisSVTimcJcWgPj++eEgzrru+pgG7mcfAq+TGsSduFBD9zk5qo0vKblJ4/dUMGCHnC0P3fC5wPinil4ux0fetTe/jj+CjsG8bdlBg9qj91wGI/HBueq6vSNTk0EVlkMKwU0pcsn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000347, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 2024=EB=85=84 4=EC=9B=94 28=EC=9D=BC (=EC=9D=BC) =EC=98=A4=ED=9B=84 9:01, M= ike Rapoport =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Sun, Apr 28, 2024 at 07:36:40PM +0900, DaeRo Lee wrote: > > 2024=EB=85=84 4=EC=9B=94 28=EC=9D=BC (=EC=9D=BC) =EC=98=A4=ED=9B=84 3:3= 5, Mike Rapoport =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > > > > > On Sat, Apr 27, 2024 at 07:24:23PM +0900, DaeRo Lee wrote: > > > > 2024=EB=85=84 4=EC=9B=94 27=EC=9D=BC (=ED=86=A0) =EC=98=A4=ED=9B=84= 5:50, Mike Rapoport =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1= : > > > > > > > > > > > > > > So, here is what I think: > > > > > > > - reserved-memory w/ nomap region -> mark only to memblock.me= mory > > > > > > > - reserved-memory w/o nomap region -> add to the memblock.res= erved > > > > > > > > > > NOMAP and memblock.reserved are semantically different, and at ma= kes sense > > > > > to have a "reserved nomap" node in fdt recorded in both memblock.= memory and > > > > > memblock.reserved. > > > > > > > > > > memblock.reserved represents the memory that is used by firmware = or early > > > > > kernel allocation, so reserved memory in fdt should be reserved i= n memblock > > > > > as well. I believe it's an oversight that early_init_dt_reserve_m= emory() > > > > > does not call memblock_reserve() for nomap memory. > > > > > > > > > > NOMAP is a property of a memory region that says that that region= should > > > > > not be mapped in the linear map, it's not necessarily in use. > > > > > > > > I agree that the NOMAP region should be added to memblock.reserved. > > > > > > > > So, I think we need to clean-up memmap_init_reserved_pages, because= in > > > > this function we call reserve_bootmem_region for memblock.reserved = and > > > > memblock.memory with nomap. We don't need to call > > > > reserve_bootmem_region for nomap. > > > > > > Read the comment about memblock_mark_nomap() > > I read the comment about memblock_mark_nomap() and understood that > > regions with nomap flags should be treated as PageReserved. > > But, if we add this nomap region to memblock.reserved, the region with > > nomap flag will be processed in the first for-loop in > > memmap_init_reserved_pages. > > memblock still must make sure that pages in nomap regions get PG_Reserved > to be robust against potential errors and bugs in firmware parsing. Got it. Thank you for your comments. I'll make another patch for just clean-up early_init_dt_reserve_memory() Thank you. Regards, DaeRo Lee