From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D2DC433F5 for ; Thu, 21 Apr 2022 04:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7940F6B0071; Thu, 21 Apr 2022 00:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 742FE6B0073; Thu, 21 Apr 2022 00:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E3676B0074; Thu, 21 Apr 2022 00:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 506F36B0071 for ; Thu, 21 Apr 2022 00:33:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 2337C1213B0 for ; Thu, 21 Apr 2022 04:33:56 +0000 (UTC) X-FDA: 79379618472.26.0E1A947 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by imf30.hostedemail.com (Postfix) with ESMTP id 4028380025 for ; Thu, 21 Apr 2022 04:33:53 +0000 (UTC) Received: by mail-vk1-f178.google.com with SMTP id bi49so1752141vkb.10 for ; Wed, 20 Apr 2022 21:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4NaD3m0FFo+3HdbSRqIQcjJTsM2LT433BpWcHX1lqVY=; b=G6VBySzZ+j1UgjJy1MIdyQsy2GogIefZuA+42NaMjZiVCnQn2fB2ZV7S2GyyqNoj1z IlKOWcxCOmCwdmWnaG605E6ocspt2pmTdRGz21s7l0OOGyUbvcAmkuXF0qlARV6QT4fs 6/W3bI8AmK7MN4pXBbdJOhB2ZgzdUZHY2bW69PIvG+a0vnXgVbmPKz3OTJchiO4kttbc IALguwchYa1lF4m86RqH8vF5DfvHjnQruJSAQGE3dGLezEBVfvsUQYwRpR2cp/bFiQSe BiU8hv9ysxvY25rFz5XLwNTIlb4MSBW6ctF/OVJfqh1j0Zb3yqyFStHZNSJD0A3qoHYi 2+SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4NaD3m0FFo+3HdbSRqIQcjJTsM2LT433BpWcHX1lqVY=; b=y4Bag6qdi2Z4EW2yhinsEdFdwgoUtgWmkhjov78/wZtHnPMhBMgE8dR1fC0wHUL4HA +j9ESqwIfC3MAA1FeAmksf39wM/59AWe3cuBfc9pJHGzmSC8OzMh78PQBv55Wz668ATG 9ZBAoXm4JMkH9Zc/y9MhesPWG1E1kq+VdYbeSoKM5sgIh7aguI82fSapJHaRRGxAFzCm XXtFIvAZkdRAv06CYakMyXusy3R25NkoMZ5GwUbvQX0u8uBP1eOZ8VihNj2rSypJaRPH RGthiw1Wd6ByLbfUQ2AV8jYXh0he7U6A+BTCJk87u93FQ69tiSSzB7TVUFOmRWHwtpp1 hXsQ== X-Gm-Message-State: AOAM533hOr8Re8FTMMxBO4tFwNI+299RtzyperG7SDdXf6WIjyBMKecI oYy1gUfmeOSYVlR6WoazBNLxzfqw/tsCBTbdq/SWQWbQFnc= X-Google-Smtp-Source: ABdhPJz2aVKEpWT0axLPw9Q3y8Srgus56b2bNtZMGaQh7ZeNoiMOZ89rUdAz3ahmu2lwk+s06WB5AwlN6UNFBwjqsFY= X-Received: by 2002:ac5:c3d0:0:b0:344:44f4:25c3 with SMTP id t16-20020ac5c3d0000000b0034444f425c3mr7247079vkk.23.1650515634751; Wed, 20 Apr 2022 21:33:54 -0700 (PDT) MIME-Version: 1.0 References: <20220413092206.73974-1-jvgediya@linux.ibm.com> <20220413092206.73974-3-jvgediya@linux.ibm.com> In-Reply-To: <20220413092206.73974-3-jvgediya@linux.ibm.com> From: Wei Xu Date: Wed, 20 Apr 2022 21:33:43 -0700 Message-ID: Subject: Re: [PATCH v2 2/5] mm: demotion: Add new node state N_DEMOTION_TARGETS To: Jagdish Gediya , Greg Thelen Cc: Linux MM , Linux Kernel Mailing List , Andrew Morton , aneesh.kumar@linux.ibm.com, Baolin Wang , Dave Hansen , Huang Ying Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4028380025 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=G6VBySzZ; spf=pass (imf30.hostedemail.com: domain of weixugc@google.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: oa63rxeuim3nwpdogh5tdemhb3ocdah6 X-HE-Tag: 1650515633-593575 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 13, 2022 at 2:22 AM Jagdish Gediya wrote: > > Current implementation to find the demotion targets works > based on node state N_MEMORY, however some systems may have > dram only memory numa node which are N_MEMORY but not the > right choices as demotion targets. > > Add new state N_DEMOTION_TARGETS, node_states[N_DEMOTION_TARGETS] > then can be used to hold the list of nodes which can be used > as demotion targets. > > Signed-off-by: Aneesh Kumar K.V > Signed-off-by: Jagdish Gediya > --- > drivers/base/node.c | 4 ++++ > include/linux/nodemask.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index ec8bb24a5a22..cd79815b0f7a 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -1038,6 +1038,9 @@ static struct node_attr node_state_attr[] = { > [N_CPU] = _NODE_ATTR(has_cpu, N_CPU), > [N_GENERIC_INITIATOR] = _NODE_ATTR(has_generic_initiator, > N_GENERIC_INITIATOR), > + [N_DEMOTION_TARGETS] = _NODE_ATTR(has_demotion_targets, > + N_DEMOTION_TARGETS), These nodes are demotion targets themselves. It is not the case that they have demotion targets. Let's rename "has_demotion_targets" to "demotion_targets"? > + > }; > > static struct attribute *node_state_attrs[] = { > @@ -1050,6 +1053,7 @@ static struct attribute *node_state_attrs[] = { > &node_state_attr[N_MEMORY].attr.attr, > &node_state_attr[N_CPU].attr.attr, > &node_state_attr[N_GENERIC_INITIATOR].attr.attr, > + &node_state_attr[N_DEMOTION_TARGETS].attr.attr, > NULL > }; > > diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h > index 567c3ddba2c4..17844300fd57 100644 > --- a/include/linux/nodemask.h > +++ b/include/linux/nodemask.h > @@ -400,6 +400,7 @@ enum node_states { > N_MEMORY, /* The node has memory(regular, high, movable) */ > N_CPU, /* The node has one or more cpus */ > N_GENERIC_INITIATOR, /* The node has one or more Generic Initiators */ > + N_DEMOTION_TARGETS, /* Nodes that should be considered as demotion targets */ > NR_NODE_STATES > }; > > -- > 2.35.1 > >