From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80712D3C526 for ; Thu, 17 Oct 2024 18:22:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1591B6B0082; Thu, 17 Oct 2024 14:22:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 109CA6B0083; Thu, 17 Oct 2024 14:22:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F12C66B0085; Thu, 17 Oct 2024 14:21:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D133E6B0082 for ; Thu, 17 Oct 2024 14:21:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 618E4121357 for ; Thu, 17 Oct 2024 18:21:49 +0000 (UTC) X-FDA: 82683912906.05.864D963 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by imf23.hostedemail.com (Postfix) with ESMTP id 4B4E9140018 for ; Thu, 17 Oct 2024 18:21:51 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1TtHciRl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of weixugc@google.com designates 209.85.210.52 as permitted sender) smtp.mailfrom=weixugc@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729189157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0vNuwIkZe438Kvv9BoDJdtP4Yx5fJLEE4DgPHUXL9Wg=; b=CZLX5RXJHBSfTCW10thgdm2nsy0CnqzDKaCpbChSPAJeh2RaO14iO1IuzqKgwbL5738CtG UZ0+0NVxAmuKX/yA39e5a+R35wWHRYAWvaPx5z+CEEfybedelAImpjF+q3iC60Mbaz67Op /5qmuKjqXZhyjyfY01nDALVsnlFPttk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729189157; a=rsa-sha256; cv=none; b=VcaT6bF8sa4emSmYYFb8dL+zX/RRouOo0X2Xm5/gqAmAAnerjD41Ay2oNU6M/afJZY/tZT gkOtzfTNCtlOz2BFCJwvEOlMZwR/wpvNV8dJV8H9Xbe6QjREZlHQVURvn/62szC40b7Usk N8rRtq3AQIW8B5mvsdgb81brEAPvdJ0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1TtHciRl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of weixugc@google.com designates 209.85.210.52 as permitted sender) smtp.mailfrom=weixugc@google.com Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-71806621d42so596038a34.3 for ; Thu, 17 Oct 2024 11:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729189317; x=1729794117; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0vNuwIkZe438Kvv9BoDJdtP4Yx5fJLEE4DgPHUXL9Wg=; b=1TtHciRlh1moBjWvszKutJ6rLHBOG6oEEKzesGByIUxvZYvNbdOw3Z5Me7IP7EQU8w O6O0EsTMd2wR5OWJE41EZtfVbT8ONEZBkNb+PWuX/oCayQhDGgrgeE9s05e2uIKVhzyK laflcjFGl9MANtyMuq8Y1MDl4rq8Nv1XuKUYLIXB2/LMk/+5QjOTn1x2YLpWrO/D5NyB aww46PYQITUddHnVY1XPHsyx/6L/oL5d9NX+4hP9/TfD+cu5wXQy7y5xIwk0CD39lJug BP1Z8bcOIbKeJ35duhTeUjIwYi4OtwV4CSivwwGMXOHfkKSIxuk+Hef5JjcNOI+BriDR 9MGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729189317; x=1729794117; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0vNuwIkZe438Kvv9BoDJdtP4Yx5fJLEE4DgPHUXL9Wg=; b=C6O+dYSYFj58Zat/BtdWd7Wi+1ZBWzPLmC2k6iUJdBOr+kZLnEZ51MG+9w6qpTLK+H vieSdOH64I3HaGbWjBbG+2zpADlpp0xCdua7qRju9m1vBlm1utHafwaguDsbKgvs6cdl OhGaohizU9W41+9hdb6b7np7mZBCBICCwo+Gsr72nIVLA2GdLz5RvabuxwSiyoH5MEF8 FbvNi2J3WJHJbAllcRNJYomLOcWT8oCNEaULTtVskgTUeafTN0kd9GZ+ZZtR5MHLZLaq fyGh0qaAMf5EVz62D9YLoOkhWZFZg1A72brdE2mY2/9qcx2pcypYF78XV822aKa5myH3 EGdw== X-Forwarded-Encrypted: i=1; AJvYcCV/OMjqMNL59VWi8P6xOJmlnn45wia3GCc9FNswuxn4JNzr0JjZEKU5SH1VidpM5w3WgSQVFNxHKQ==@kvack.org X-Gm-Message-State: AOJu0YwZ6opQx2kyungGWxsNVSbCTOEUQK4D9CjqpFVEtMW3mXLQb986 qiejJd4w+uwKKCLc585Urjs6Np/Gdju3LKy7HekErVkmjCuyGlmepJS1TE3wVdYKsGu2ZGz3oIp ZdORX/qA7/ELR8ykPNuC46ZBWrAvu/+EjdvXW X-Google-Smtp-Source: AGHT+IHM6SgvakHOzfMHe+tK8akdryo1YChetAtJK61+k9hGwygT6I8t9ITw0MGJ7Ss0gI7UGwKq/hQASSlBC+NDQfM= X-Received: by 2002:a05:6808:3198:b0:3e6:92:ea86 with SMTP id 5614622812f47-3e60092efc6mr1054575b6e.20.1729189316559; Thu, 17 Oct 2024 11:21:56 -0700 (PDT) MIME-Version: 1.0 References: <20241014221231.832959-1-weixugc@google.com> <20241016155550.9ff2ab4625c7f19b6be8b7e1@linux-foundation.org> In-Reply-To: <20241016155550.9ff2ab4625c7f19b6be8b7e1@linux-foundation.org> From: Wei Xu Date: Thu, 17 Oct 2024 11:21:43 -0700 Message-ID: Subject: Re: [PATCH 2/2] mm/mglru: reset page lru tier bits when activating To: Andrew Morton Cc: Yu Zhao , Brian Geffon , Jan Alexander Steffens , Suleiman Souhlal , Axel Rasmussen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4B4E9140018 X-Stat-Signature: zt3obix7goxuwa6i1dg7oe1w9a1cuuz8 X-Rspam-User: X-HE-Tag: 1729189311-911300 X-HE-Meta: U2FsdGVkX19yqnsyNoPR1rieOtJG2avHiPmP8toHRELodWSgbAN71BPLW73G/p96cG3RvBV6JcPCoX11bAxHQGiIXdKMH2V9/hk5lLkqtkI+1BA8s/+JLCr0QH7cN6LTFcCrhzg2zfr39JAC6EhzOBp6wJ9jK+SmlI7EkRE/MSc8ScC+8iGU2/JJsvsWcoVGT3YJTrjGRSBexTulykmeOvxOhZVPOdS2Oz92bK8ItVPiet/FQvOUKje50F46wzz4vKj8TFe6j75GhdmJfMxHkbeXuTKASJ6ElUIAkc2rjkfdbniIpJnhaBqWA6lpz4abyRIMpnCivdI4h4c+YbfvzDEwy/wQv8GnjazUmY6FlE4T3qazKkF/RwXERmCmdHRshfWqi+DnhcAImlnSedN2ANxlheNgoEEapoKvfVtZw+a0wbHLZhJuq1Sfw9lv3uzxjaFo7sy4MnaPPvT1AgOVZs1in4HMXADaQZhxMXMZCwRz4kSNZhQChAszWO66pHIzfuIcuoHr4+Z+nvKZfFy+Zd9mDMSIYFFuTBLJMRP8zok9guEHogojEp7qIgTWLqShLybSGTZxVRSb2mJqA+Z/+GND3Hacok0HiK3ur1OmSHIoYRBuOjJqoDgU9/asDgYfH+uhKTYceWKZ3BexyNG+x+61HE8FeyaTy9GY+d4otuhLKkCscQTeZfkx6fsW2FJNWn42i+CrNTUUxPojmyAFPANnwIpWOpMGnLAiPFmv5EsoaHqBBcJi+NhQlX0xDuXbDM77StBQuO9/KLMg2OxSUpwMAdo4p7KoZAlibXthFM7EaHtBhyJc3mvM912QjJweFzL5ULzFWsjKB2psvLjwu5AiAwVVrVQezR3T3Zt4fiovGYV5cL6X613qF1qCZnl3W6WvHbCeqOkkfgJYHHnElCqa9+Aymhs41xayW1J5JZIxNsN4m0ufYYtOjVniusk7gmDaOK4XyVgyKLVFCmX jVWI1LTY KBZEjgwyFEqsOPS7fxvpqa3WocpW30Fhw6eZILY61lmcj8cxFqVAdFEexNuMkCoFX2+Uyoz6DOBmZJiTmMYErQigeKBKdr6KlMzOQCjyI6QEhnvMc91zYbvjmpJRNJaNZwQuMimaBqBhgC633gm7ZLdwIW90XV6vCnRJKuSCNqer80UkRv4ySR90oPK/3xgYzlg1d8nUVOgZGaHErcH/JMFCmF04pF0TSsQu1V9vEOa6SPULHD/qMBjfMhAnk3Zt5c3PdncuLLwNXu3tS3BPm1uKHpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 3:55=E2=80=AFPM Andrew Morton wrote: > > On Tue, 15 Oct 2024 22:55:23 -0600 Yu Zhao wrote: > > > > @@ -257,7 +258,9 @@ static inline bool lru_gen_add_folio(struct lruve= c *lruvec, struct folio *folio, > > > gen =3D lru_gen_from_seq(seq); > > > flags =3D (gen + 1UL) << LRU_GEN_PGOFF; > > > /* see the comment on MIN_NR_GENS about PG_active */ > > > - set_mask_bits(&folio->flags, LRU_GEN_MASK | BIT(PG_active), f= lags); > > > + mask =3D LRU_GEN_MASK | BIT(PG_active); > > > + mask |=3D folio_test_active(folio) ? (LRU_REFS_MASK | LRU_REF= S_FLAGS) : 0; > > > > We shouldn't clear PG_workingset here because it can affect PSI > > accounting, if the activation is due to workingset refault. > > Good point. I have addressed this in the v2 patch. > > Also, nit: > > mask =3D LRU_GEN_MASK; > > if (folio_test_active(folio)) > > mask |=3D LRU_REFS_MASK | BIT(PG_active) | BIT(PG_referenced); > > > > Thanks, I'll drop this version of this patch. > > When resending, please include a full description of the userspace-visibl= e > effects of the original flaw, thanks. I have sent out a v2 patch, which includes a description as suggested.