From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B177C54EE9 for ; Fri, 2 Sep 2022 07:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07207800C9; Fri, 2 Sep 2022 03:02:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3C4E8008D; Fri, 2 Sep 2022 03:02:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDD36800C9; Fri, 2 Sep 2022 03:02:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C86E28008D for ; Fri, 2 Sep 2022 03:02:18 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 96C90A099B for ; Fri, 2 Sep 2022 07:02:18 +0000 (UTC) X-FDA: 79866251556.18.379696A Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf04.hostedemail.com (Postfix) with ESMTP id 4933040055 for ; Fri, 2 Sep 2022 07:02:18 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id o4so1164368pjp.4 for ; Fri, 02 Sep 2022 00:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=uXkNYxalU3/JcnK0TgVrr2SUQW7bkm9aHsz+BnGWP4M=; b=bUW/6CvLUDYW0zbfCP9LCMgQ6TAJJPu2/+w9PaaDjrm5uRaLAErHNIrLG35W+7dPBp iz4APoLne29HYgGTr3djCIrRA2QO6RIDrM/7gmuZibGir+ybNjWk4Tc6evIgdn6epN+i 95os2rQS+J+e90fqJA91RsJfiKAKCeWjnEJvgWDKYFrS2wWv0ank1E/tAAEqQfmjIHwm BvgN05t5fibh9LeV1OnGnc875ySVeP090LPZOvIi5iCd+nVfyYOW/7WkGLGDg3EPlPY/ yrZRwr0dC84rQ6GseSm35y1jdepf+X8hFuYHdbS2Mif2s5/rQ0cg2yOa9qq38vFxnf86 56kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=uXkNYxalU3/JcnK0TgVrr2SUQW7bkm9aHsz+BnGWP4M=; b=Q0XUK7n0ZoUJYqYaAl0MtOH98OL5SWSXv+DPvuHvTKtIQ98H+GTBzCyGBRQYO3wyMX /C4fdGijSlmxqi5oFQNkiFkhcpFJbjRraLnflmyZsaMzvfIRJ/VY5ItLpXAqbtARhUTF Ey7p6vD0ISRRr9hCeOigVHF7WtQgoRMPDh66/my7NsowwdNXCoNT2CGVTk/0JqVlzOpj 4sh5nxwmfkOjhQcTfNneLEWEXcHBJUIcjytquOz69U5C8CVPRAxSC4Xl5xsQ8dWsDs0M vSJQn8NlXVOqt7R70yFJRc4pIg1ufz4cX+VYjUnkeNWiU51Z/klPHDiIwILbStON110Y bCYw== X-Gm-Message-State: ACgBeo2ZOc3VoAfsA4kYfDso+X2ldJfNaK7V+d6icGac+iQVsmeM9Iib Z2fM1bkgzhumcDQsrCmlwJHJM3t0ikqkM+L31UMT3w== X-Google-Smtp-Source: AA6agR5uR6LpAtH7c6bzY90OocFiB2zuRBrqhgIN4W1VlfMx9LRsS/Ozz4xK6EFFpJ7aOlMcyK5rZc+IYGh+WDK5hbc= X-Received: by 2002:a17:902:e5cc:b0:16f:1e31:da6c with SMTP id u12-20020a170902e5cc00b0016f1e31da6cmr34239381plf.66.1662102137014; Fri, 02 Sep 2022 00:02:17 -0700 (PDT) MIME-Version: 1.0 References: <20220830081736.119281-1-aneesh.kumar@linux.ibm.com> <87tu5rzigc.fsf@yhuang6-desk2.ccr.corp.intel.com> <87pmgezkhp.fsf@yhuang6-desk2.ccr.corp.intel.com> <87fshaz63h.fsf@yhuang6-desk2.ccr.corp.intel.com> <698120ce-d4df-3d13-dea9-a8f5c298783c@linux.ibm.com> <87bkryz4nh.fsf@yhuang6-desk2.ccr.corp.intel.com> <2b4ddc45-74ae-27df-d973-6724f61f4e18@linux.ibm.com> <877d2mz3c1.fsf@yhuang6-desk2.ccr.corp.intel.com> <45488760-02b5-115b-c16d-5219303f2f33@linux.ibm.com> In-Reply-To: <45488760-02b5-115b-c16d-5219303f2f33@linux.ibm.com> From: Wei Xu Date: Fri, 2 Sep 2022 00:02:05 -0700 Message-ID: Subject: Re: [PATCH v3 updated] mm/demotion: Expose memory tier details via sysfs To: Aneesh Kumar K V Cc: "Huang, Ying" , Johannes Weiner , Linux MM , Andrew Morton , Yang Shi , Davidlohr Bueso , Tim C Chen , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , jvgediya.oss@gmail.com, Bharata B Rao , Greg Thelen , Greg Kroah-Hartman , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662102138; a=rsa-sha256; cv=none; b=YQxCOUIdQr89O5KQVXCH/ZX9OdSErUo6Z/imLTncVgSIfcQdbZmmXEBuM9rOfi9kNBTJsE HRMayuBH/Uf39gaoGCZZ/49lc1+UUXhhG8zOccf5m5BcH/pNuZfNXE82BHEKB9iOehSaQi IYPFy3ssmGrhIHB0RZIjkr/i9VrUjZ0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="bUW/6CvL"; spf=pass (imf04.hostedemail.com: domain of weixugc@google.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662102138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uXkNYxalU3/JcnK0TgVrr2SUQW7bkm9aHsz+BnGWP4M=; b=axWzSzMdtSHLRtphZwEZebNLVmisFbI87HDV866NqrJFZu9Plgypl6RPZlJ9wZT6MPH+NK qzebNFhbLBN6ZwXa3w9qj+Y7oPXWm8dUzxdRPfRvq0w8tr5uGZXiJUvjd10IqsjHaObg1V qsgQMa5TeZWR/TyYyo0i05inrc6YgNQ= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="bUW/6CvL"; spf=pass (imf04.hostedemail.com: domain of weixugc@google.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4933040055 X-Stat-Signature: nbn4inszzh4iyoxtoki7z5pi9fmyyu54 X-HE-Tag: 1662102138-960205 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 1, 2022 at 11:44 PM Aneesh Kumar K V wrote: > > On 9/2/22 12:10 PM, Huang, Ying wrote: > > Aneesh Kumar K V writes: > > > >> On 9/2/22 11:42 AM, Huang, Ying wrote: > >>> Aneesh Kumar K V writes: > >>> > >>>> On 9/2/22 11:10 AM, Huang, Ying wrote: > >>>>> Aneesh Kumar K V writes: > >>>>> > >>>>>> On 9/2/22 10:39 AM, Wei Xu wrote: > >>>>>>> On Thu, Sep 1, 2022 at 5:33 PM Huang, Ying wrote: > >>>>>>>> > >>>>>>>> Aneesh Kumar K V writes: > >>>>>>>> > >>>>>>>>> On 9/1/22 12:31 PM, Huang, Ying wrote: > >>>>>>>>>> "Aneesh Kumar K.V" writes: > >>>>>>>>>> > >>>>>>>>>>> This patch adds /sys/devices/virtual/memory_tiering/ where all memory tier > >>>>>>>>>>> related details can be found. All allocated memory tiers will be listed > >>>>>>>>>>> there as /sys/devices/virtual/memory_tiering/memory_tierN/ > >>>>>>>>>>> > >>>>>>>>>>> The nodes which are part of a specific memory tier can be listed via > >>>>>>>>>>> /sys/devices/virtual/memory_tiering/memory_tierN/nodes > >>>>>>>>>> > >>>>>>>>>> I think "memory_tier" is a better subsystem/bus name than > >>>>>>>>>> memory_tiering. Because we have a set of memory_tierN devices inside. > >>>>>>>>>> "memory_tier" sounds more natural. I know this is subjective, just my > >>>>>>>>>> preference. > >>>>>>>>>> > >>>>>> > >>>>>> > >>>>>> I missed replying to this earlier. I will keep memory_tiering as subsystem name in v4 > >>>>>> because we would want it to a susbsystem where all memory tiering related details can be found > >>>>>> including memory type in the future. This is as per discussion > >>>>>> > >>>>>> https://lore.kernel.org/linux-mm/CAAPL-u9TKbHGztAF=r-io3gkX7gorUunS2UfstudCWuihrA=0g@mail.gmail.com > >>>>> > >>>>> I don't think that it's a good idea to mix 2 types of devices in one > >>>>> subsystem (bus). If my understanding were correct, that breaks the > >>>>> driver core convention. > >>>>> > >>>> > >>>> All these are virtual devices .I am not sure i follow what you mean by 2 types of devices. > >>>> memory_tiering is a subsystem that represents all the details w.r.t memory tiering. It shows > >>>> details of memory tiers and can possibly contain details of different memory types . > >>> > >>> IMHO, memory_tier and memory_type are 2 kind of devices. They have > >>> almost totally different attributes (sysfs file). So, we should create > >>> 2 buses for them. Each has its own attribute group. "virtual" itself > >>> isn't a subsystem. > >> > >> Considering both the details are related to memory tiering, wouldn't it be much simpler we consolidate > >> them within the same subdirectory? I am still not clear why you are suggesting they need to be in different > >> sysfs hierarchy. It doesn't break any driver core convention as you mentioned earlier. > >> > >> /sys/devices/virtual/memory_tiering/memory_tierN > >> /sys/devices/virtual/memory_tiering/memory_typeN > > > > I think we should add > > > > /sys/devices/virtual/memory_tier/memory_tierN > > /sys/devices/virtual/memory_type/memory_typeN > > > > I am trying to find if there is a technical reason to do the same? > > > I don't think this is complex. Devices of same bus/subsystem should > > have mostly same attributes. This is my understanding of driver core > > convention. > > > > I was not looking at this from code complexity point. Instead of having multiple directories > with details w.r.t memory tiering, I was looking at consolidating the details > within the directory /sys/devices/virtual/memory_tiering. (similar to all virtual devices > are consolidated within /sys/devics/virtual/). > > -aneesh Here is an example of /sys/bus/nd/devices (I know it is not under /sys/devices/virtual, but it can still serve as a reference): ls -1 /sys/bus/nd/devices namespace2.0 namespace3.0 ndbus0 nmem0 nmem1 region0 region1 region2 region3 So I think it is not unreasonable if we want to group memory tiering related interfaces within a single top directory. Wei