From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64149C4332F for ; Thu, 20 Oct 2022 03:48:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFE276B0071; Wed, 19 Oct 2022 23:48:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C86456B0073; Wed, 19 Oct 2022 23:48:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B27026B0074; Wed, 19 Oct 2022 23:48:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A05076B0071 for ; Wed, 19 Oct 2022 23:48:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6B06D1C619E for ; Thu, 20 Oct 2022 03:48:55 +0000 (UTC) X-FDA: 80039946630.23.AF7C4D1 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf18.hostedemail.com (Postfix) with ESMTP id 0562B1C0007 for ; Thu, 20 Oct 2022 03:48:54 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id f23so19140841plr.6 for ; Wed, 19 Oct 2022 20:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=B380SWXebweddYWftA/qmfI+PBISJKmsY//1dGFA34Y=; b=BrcYjOt+lNbt807LHYSocYLkoCaQNb83vMwI/1ctLUHaxHhLhyKv9Ij1+8ks4RneKJ J/g8aXjdp3XQ3Etk5c068Ho2u5JmBVPCPpmDcNWojCbnWxaRiBCFlbGvIo2E4zJ4tHH5 ZlTIi0qeIkj7ox9z/VSBhzUptUrnzvGCna5JpAEc1IA3WqmUccttjWVOjUkaUxy6vrt0 n7acSvKhjQs3ihYdWCpf+YU3A0mxgqyv/kGusUeBG+sycELh0aDyOS1pwKmbb5JtMSZj DjUjjgLLeiuKHjPPnYTXOIJ+vHwFS30pDK7J6Fg9sQHpCCWVOoOXDAcnGgFb9fvzrKuj czMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B380SWXebweddYWftA/qmfI+PBISJKmsY//1dGFA34Y=; b=3J1roIPE+F6clqLYbIzx54G6Wp6MW09RS2+bfDnuycJDGXYZPzilT/WYY2z4VV8DBr zpAQj8irnTM0YeXgowEWlQzxakA8wKGM+gBosWPvNhy239frGHjC3KkdV2GUuEmOiH7J rkqqZ1vSpTop/PNMSM3659kweZQyfEOkwHtB+RHFvCVfiUAsCADG9nQvyJguYdC0K+fr C1VFzZ6J7p2CBltEUNOzh30tjgrLRYl4Bc9aZwQGePndFQ/2iE/4OLu7aSCqZ60NygyH XKjh7+h98q/bupobK1i05YlvPlSbAt7QmQJuWFwuAlAbYfepzeNXEfIIJqUic5qdXvUl npdw== X-Gm-Message-State: ACrzQf2+dXzaZaSBg5hy1ZoskKISVGEj3mas+YVSEhp2q9vrLcpafp5T wzRmBAfxWhQtvZ0bm9qlh3H5DJWuiW9wpTFQkECoHQ== X-Google-Smtp-Source: AMsMyM6A31FdFe4Ict2geH7wrxfgdUz7KrLM3nmEIPCNt/BBVnzE9MQUlNTc6j6lJqsIUZHjriQPE4vhPXmq5heIgZE= X-Received: by 2002:a17:90b:1c82:b0:1ee:eb41:b141 with SMTP id oo2-20020a17090b1c8200b001eeeb41b141mr14026932pjb.143.1666237733772; Wed, 19 Oct 2022 20:48:53 -0700 (PDT) MIME-Version: 1.0 References: <20221020015122.290097-1-ying.huang@intel.com> In-Reply-To: <20221020015122.290097-1-ying.huang@intel.com> From: Wei Xu Date: Wed, 19 Oct 2022 20:48:41 -0700 Message-ID: Subject: Re: [PATCH] memory tier, sysfs: rename attribute "nodes" to "nodelist" To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , "Aneesh Kumar K . V" , Alistair Popple , Bharata B Rao , Dan Williams , Dave Hansen , Davidlohr Bueso , Hesham Almatary , Jagdish Gediya , Johannes Weiner , Jonathan Cameron , Michal Hocko , Tim Chen , Yang Shi Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BrcYjOt+; spf=pass (imf18.hostedemail.com: domain of weixugc@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666237735; a=rsa-sha256; cv=none; b=EwPflI0MQMcTmzDtPLvJRooeRqD4IgHcbxSCp4ir9Z6PnqYDKPs+esLA0r3NnKRo3DGjCc oFoK5n638c/uKzb8T62Ksy0XA4Oyg7YKZjhVkameSZgn72KKUjFkrkjCvBprljMvhLeJw5 a4qXWJO1f+EPXtuf8ixVSIP3B9//8RM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666237735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B380SWXebweddYWftA/qmfI+PBISJKmsY//1dGFA34Y=; b=xpLhMggwaYQBHgRviDHIOQPVLGIW/t6e3BQOAh4xU7aONlVo5NSFh/xBigqvYreD+1sGTe E+DN5hiS+7zQAUk28cIsaULitMFHlz2SE2VKG1KU4TMSQgAWI3JfTGDBoMzG5or09z7AnD /s/8hZCqnf6Ah8biJB8CM4Q/LkAuTxQ= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BrcYjOt+; spf=pass (imf18.hostedemail.com: domain of weixugc@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 6hbp9uyyqepe3hut1sseffanau8kr8pg X-Rspamd-Queue-Id: 0562B1C0007 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1666237734-906997 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Acked-by: Wei Xu On Wed, Oct 19, 2022 at 6:51 PM Huang Ying wrote: > > In sysfs, we use attribute name "cpumap" or "cpus" for cpu mask and > "cpulist" or "cpus_list" for cpu list. For example, in my system, > > $ cat /sys/devices/system/node/node0/cpumap > f,ffffffff > $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus > 0,00100004 > $ cat cat /sys/devices/system/node/node0/cpulist > 0-35 > $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus_list > 2,20 > > It looks reasonable to use "nodemap" for node mask and "nodelist" for > node list. So, rename the attribute to follow the naming convention. > > Signed-off-by: "Huang, Ying" > Cc: Aneesh Kumar K.V > Cc: Alistair Popple > Cc: Bharata B Rao > Cc: Dan Williams > Cc: Dave Hansen > Cc: Davidlohr Bueso > Cc: Hesham Almatary > Cc: Jagdish Gediya > Cc: Johannes Weiner > Cc: Jonathan Cameron > Cc: Michal Hocko > Cc: Tim Chen > Cc: Wei Xu > Cc: Yang Shi > --- > Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers | 4 ++-- > mm/memory-tiers.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > index 45985e411f13..721a05b90109 100644 > --- a/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > @@ -10,7 +10,7 @@ Description: A collection of all the memory tiers allocated. > > > What: /sys/devices/virtual/memory_tiering/memory_tierN/ > - /sys/devices/virtual/memory_tiering/memory_tierN/nodes > + /sys/devices/virtual/memory_tiering/memory_tierN/nodelist > Date: August 2022 > Contact: Linux memory management mailing list > Description: Directory with details of a specific memory tier > @@ -21,5 +21,5 @@ Description: Directory with details of a specific memory tier > A smaller value of N implies a higher (faster) memory tier in the > hierarchy. > > - nodes: NUMA nodes that are part of this memory tier. > + nodelist: NUMA nodes that are part of this memory tier. > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index f116b7b6333e..fa8c9d07f9ce 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -131,8 +131,8 @@ static void memory_tier_device_release(struct device *dev) > kfree(tier); > } > > -static ssize_t nodes_show(struct device *dev, > - struct device_attribute *attr, char *buf) > +static ssize_t nodelist_show(struct device *dev, > + struct device_attribute *attr, char *buf) > { > int ret; > nodemask_t nmask; > @@ -143,10 +143,10 @@ static ssize_t nodes_show(struct device *dev, > mutex_unlock(&memory_tier_lock); > return ret; > } > -static DEVICE_ATTR_RO(nodes); > +static DEVICE_ATTR_RO(nodelist); > > static struct attribute *memtier_dev_attrs[] = { > - &dev_attr_nodes.attr, > + &dev_attr_nodelist.attr, > NULL > }; > > -- > 2.35.1 >