From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69BD9ECAAD1 for ; Tue, 30 Aug 2022 15:48:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03B6E8D0003; Tue, 30 Aug 2022 11:48:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2E998D0001; Tue, 30 Aug 2022 11:48:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF4ED8D0003; Tue, 30 Aug 2022 11:48:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D13148D0001 for ; Tue, 30 Aug 2022 11:48:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AFBB4413FA for ; Tue, 30 Aug 2022 15:48:34 +0000 (UTC) X-FDA: 79856691348.20.4BEE80F Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf25.hostedemail.com (Postfix) with ESMTP id 70363A0010 for ; Tue, 30 Aug 2022 15:48:34 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id v5so5296356plo.9 for ; Tue, 30 Aug 2022 08:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=hNllKNHOzYlzwLSe4h2WfwgKyDb/1zfxegYu4XxgzHs=; b=C044xLj4vEPLZD+B4wrql2rOXp3W3xRSPge7WntDuscQ/J/u8b5QjnygLEIDoiwW0w +Dr7VMrbhFYSom+qkV/1RH6bV8OqHsonOo+dMH06uEAdiE9MpOmSff/q38N7NnOLf5jh 4iO7Sd9prXW2z+5O+5E8VFxQj/EOEAPtxfe/5f721t4uqRlgQ5ZUzz2nEB3lov3orfUc g8RGIo227gXxXORc/LABwv/4EoUnkCrewA6q5g2iiAwoHRRKI3Qo2avuC6EoK++3CpM1 AtZxWmoBliHWQmxB42KsVhqecjdXYg28zH4/XcnHWZp0cuyC6DLuhG3nl6Rrg4lK6t8a 0hpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=hNllKNHOzYlzwLSe4h2WfwgKyDb/1zfxegYu4XxgzHs=; b=xj5A5kmcLOaAALPfXlcZ9ISm37cvOz7s8leaMchDo8LnIsQ013FPFe3u4/EwtwWmaE ObHSOG5Sv54dmL+J49sAD6uIRaEuXc/E7dyGRW4rpoocqaMqfxKTZvC8OBkvrz9evTma FQ55Ob0jvPSwvg7tHhewdP9ZkQQlc5NKer9Em5pcwewYMbs1pCqagQdNIGeBn9V8460u k9eUoHHun6+R+GBbu1IbT/LDLanxLafCHE1dLdZRvxOEHPEawx24+LR1ikYJVYCGgV/7 E2G+eY/kk6SjRece5SgLjfxHdvThdXpaknETlD1I898+a6bkHhCsMYRM0xW38jlJNMtb R+DA== X-Gm-Message-State: ACgBeo3VnNlnKGuvqvXBXKrAC+4TV9dgkkD/4sPtl7r2fnb5A1fcsnpd y3RqR8zKpUqwtogPI9+yeFbNLuDAoSED3ThwWcgqcg== X-Google-Smtp-Source: AA6agR6L1SyuMzUf8+xeARTBqavCpRaNKT6T+hGBy6ljvxZOnUHutxr1KeuC5g6EOuuX+XryhF9+3PBL5lvLY4jo71I= X-Received: by 2002:a17:902:f612:b0:172:cbb0:9b4f with SMTP id n18-20020a170902f61200b00172cbb09b4fmr21157414plg.142.1661874513400; Tue, 30 Aug 2022 08:48:33 -0700 (PDT) MIME-Version: 1.0 References: <20220830081457.118960-1-aneesh.kumar@linux.ibm.com> In-Reply-To: <20220830081457.118960-1-aneesh.kumar@linux.ibm.com> From: Wei Xu Date: Tue, 30 Aug 2022 08:48:22 -0700 Message-ID: Subject: Re: [PATCH mm-unstable] mm/demotion: Make toptier_distance inclusive upper bound of toptiers To: "Aneesh Kumar K.V" Cc: Linux MM , Andrew Morton , Huang Ying , Yang Shi , Davidlohr Bueso , Tim C Chen , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Johannes Weiner , jvgediya.oss@gmail.com, Bharata B Rao Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=C044xLj4; spf=pass (imf25.hostedemail.com: domain of weixugc@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661874514; a=rsa-sha256; cv=none; b=yMUX7UY+aFwvCWcsL0u/uHcBWMJjXf2Bj9lln3RXhN61/82a7TVCAp815M98YRwGgle70o nkxbhaQa0J2vViA/PDiuiyRsd5g4n+oEcn4Qp0KpoOGUzgiwbykNIgRCnnOAdSl6zcoOWP ZA5l9GEPLayA1dDeyQos57p//mcuRJ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661874514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hNllKNHOzYlzwLSe4h2WfwgKyDb/1zfxegYu4XxgzHs=; b=ThrSXIgcw3mcLPBptdwNyFkp+IV+Fn8sYdf1LpBCxdSYvv+0cZIrZFZKlFJUsSxpf0T0rL IgCyn2051LpGJlHgyGSwuDPStr5VCRGkQUxa3wWMQPuSZ01ofchi/6GjEwdgEw1ow4aSv4 51JeHL55+hye6LFEM/gD7zAdRxORPVA= X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=C044xLj4; spf=pass (imf25.hostedemail.com: domain of weixugc@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam02 X-Stat-Signature: sdsej7swzp6c3rftibecck9o1tfxcsu6 X-Rspamd-Queue-Id: 70363A0010 X-HE-Tag: 1661874514-581268 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 1:15 AM Aneesh Kumar K.V wrote: > > Based on suggestion from Wei Xu , having an > inclusive upper bound is found simpler. > > Fixes: mm/demotion: Update node_is_toptier to work with memory tiers > Signed-off-by: Aneesh Kumar K.V > --- > mm/memory-tiers.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index c4bd6d052a33..c82eb0111383 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -179,7 +179,7 @@ bool node_is_toptier(int node) > toptier = true; > goto out; > } > - if (memtier->adistance_start < top_tier_adistance) > + if (memtier->adistance_start <= top_tier_adistance) > toptier = true; > else > toptier = false; > @@ -361,7 +361,8 @@ static void establish_demotion_targets(void) > * abstract distance below the max value of this memtier below -> up to ? Looks good to me otherwise. Wei > * is considered toptier. > */ > - top_tier_adistance = memtier->adistance_start + MEMTIER_CHUNK_SIZE; > + top_tier_adistance = memtier->adistance_start + > + MEMTIER_CHUNK_SIZE - 1; > break; > } > } > -- > 2.37.2 >